Thanks, I've applied the attached patch to fix these.
John
On Mon, 2004-11-29 at 20:45 +0100, Georg Baum wrote:
> I get the following warnings:
>
> ../../../../src/frontends/gtk/FileDialogPrivate.h: In constructor `
> FileDialog::Private::Private(const std::string&, kb_action,
> std::pair<std::string, std::string>, std::pair<std::string,
> std::string>)':
> ../../../../src/frontends/gtk/FileDialogPrivate.h:40: warning: `
> FileDialog::Private::action_' will be initialized after
> ../../../../src/frontends/gtk/FileDialogPrivate.h:39: warning: `
> Gtk::FileChooserDialog FileDialog::Private::fileChooser_'
> ../../../../src/frontends/gtk/FileDialogPrivate.C:32: warning: when
> initialized here
> ../../../../src/frontends/gtk/FileDialogPrivate.C:79:66: warning:
> multi-character character constant
>
> The reason for the second one is probably a typo.
? tmp
Index: FileDialogPrivate.C
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/gtk/FileDialogPrivate.C,v
retrieving revision 1.12
diff -u -p -r1.12 FileDialogPrivate.C
--- FileDialogPrivate.C 26 Nov 2004 16:09:11 -0000 1.12
+++ FileDialogPrivate.C 29 Nov 2004 21:21:23 -0000
@@ -76,7 +76,7 @@ FileDialog::Result const FileDialog::Pri
{
lyxerr[Debug::GUI] << "File Dialog with path \"" << path
<< "\", mask \"" << filters.as_string()
- << "\", suggested \"" << suggested << '"\n';
+ << "\", suggested \"" << suggested << "\"\n";
for (lyx::support::FileFilterList::size_type i = 0; i < filters.size(); ++i) {
typedef lyx::support::FileFilterList::Filter::glob_iterator glob_iterator;
Index: FileDialogPrivate.h
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/gtk/FileDialogPrivate.h,v
retrieving revision 1.7
diff -u -p -r1.7 FileDialogPrivate.h
--- FileDialogPrivate.h 26 Nov 2004 15:32:37 -0000 1.7
+++ FileDialogPrivate.h 29 Nov 2004 21:21:23 -0000
@@ -36,8 +36,8 @@ public:
std::string const & suggested);
private:
- Gtk::FileChooserDialog fileChooser_;
kb_action action_;
+ Gtk::FileChooserDialog fileChooser_;
};
#endif
