Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> This is the final NVI patch for the inset hierarchy.
>>
>> Please have a look if interested.
>>
>> I'll try to break out some of the non-mechanical changes into
>> separate
>> patches before applying this: Some functions do not need to be
>> virtual, some are unused. (or only used in one place).
>
| Why this. It looks functional? Are you sure it's correct? Doesn't
| belong in this patch anyway.
| @@ -968,10 +971,6 @@ bool LCursor::goUpDown(bool up)
| - // try current cell for e.g. text insets
| - if (inset().idxUpDown2(*this, up))
| - return true;
This is one of the things I will break out into a separate patch.
idxUpdown2 always have the value "false"
>
| The patch is too large for me to look at it carefully now, but the
| basic idea is sound enough. Mechanical application of a coding idiom,
| if I understand correctly, no?
mechanical, but manually. So I have cleaned up small stuff as I have
gone along. Always use virtual on virtual functions etc. Corrected
some return values. stuff like that.
--
Lgb
