Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

LGTM Trevor https://codereview.appspot.com/108270043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

Other than that LGTM. Sorry for holding this up for so long. https://codereview.appspot.com/108270043/diff/60001/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/108270043/diff/60001/Documentation/notation/ancient.itely#newc

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

I hope this is close to what is required... https://codereview.appspot.com/108270043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/21 17:50:15, Trevor Daniels wrote: Let's see if I understand the issue here. Because the incipit is generated as a separate score hidden inside a music function it is not possible to use the usual override mechanism to change any values set inside the music function, including t

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

Let's see if I understand the issue here. Because the incipit is generated as a separate score hidden inside a music function it is not possible to use the usual override mechanism to change any values set inside the music function, including the value of InstrumentName.self-aligment-X. The defa

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; ; ; ; Cc: ; Sent: Thursday, August 21, 2014 1:55 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/06/29 13:51:33, PhilEHolmes wrote: Please review. Sorry to step in like that. I'm not

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/21 12:55:37, Jean-Charles wrote: On 2014/06/29 13:51:33, PhilEHolmes wrote: > Please review. Sorry to step in like that. I'm not able to comment on the code, but have just one question, since I don't use incipits: does it happen that the original score reproduced in an incipit

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/06/29 13:51:33, PhilEHolmes wrote: Please review. Sorry to step in like that. I'm not able to comment on the code, but have just one question, since I don't use incipits: does it happen that the original score reproduced in an incipit happens to be on a four lines staff? How would it t

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

"Phil Holmes" writes: > - Original Message - > From: > To: ; ; > >> On 2014/08/21 10:21:18, mail_philholmes.net wrote: >> >>> There's nothing wrong in changing a poor default to a good one, and >>> then allowing the user to restore the poor one. >> >> But you are not "changing a poor de

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; ; ; Cc: ; Sent: Thursday, August 21, 2014 12:31 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/08/21 10:21:18, mail_philholmes.net wrote: There's nothing wrong in changing a poor defau

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/21 10:21:18, mail_philholmes.net wrote: There's nothing wrong in changing a poor default to a good one, and then allowing the user to restore the poor one. But you are not "changing a poor default to a good one". You are overriding locally, as the default of a single command, wha

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

Sorry - the images were not helpful. It looks like my mailer adds the image when it's sent, not when it's attached. Here they are again. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lil

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; ; ; Cc: ; Sent: Wednesday, August 20, 2014 9:40 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/08/20 08:17:01, email_philholmes.net wrote: >> ly/property-init.ly:303: ragged-last

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/20 08:17:01, email_philholmes.net wrote: >> ly/property-init.ly:303: ragged-last = ##f >> wouldn't we also want system-count = 1 here? >> >> https://codereview.appspot.com/108270043/ > > Possibly. I'd be happy to add that prior to push. > > -- > Phil Holmes Actually, I've just chec

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: "Phil Holmes" To: ; ; ; ; ; Cc: ; Sent: Tuesday, August 19, 2014 9:21 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) - Original Message - From: To: ; ; ; ; Cc: ; Sent: Tuesday, August

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; ; ; Cc: ; Sent: Tuesday, August 19, 2014 9:55 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly#newcode293 > ly/property-init.ly:

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/19 20:22:01, email_philholmes.net wrote: - Original Message - From: To: ; ; ; ; Cc:

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; ; ; Cc: ; Sent: Tuesday, August 19, 2014 6:11 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly File ly/property-init.ly (right

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly File ly/property-init.ly (right): https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly#newcode293 ly/property-init.ly:293: \once \override Staff.InstrumentName.self-alignment-X = #RIGHT I don't think we sh

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

TBH I've sung from a lot of music with incipits and have never seen more than one note: finding a sole example on Wikipedia from an author who does not appear to have a username isn't categorical! However, Grove says "A 'melodic incipit' or 'musical incipit' is the opening fragment of m

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/17 09:56:32, email_philholmes.net wrote: - Original Message - From: To: ; ; Cc: ;

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; Cc: ; Sent: Saturday, August 16, 2014 9:38 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) Minor typo, otherwise LGTM Trevor https://codereview.appspot.com/108270043/diff/40001/Documentation

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

Minor typo, otherwise LGTM Trevor https://codereview.appspot.com/108270043/diff/40001/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/108270043/diff/40001/Documentation/notation/ancient.itely#newcode2651 Documentation/nota

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; Cc: ; Sent: Saturday, August 16, 2014 2:53 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/08/16 13:12:56, PhilEHolmes wrote: Please review further updates to this patch Ok, this version does

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/16 13:12:56, PhilEHolmes wrote: Please review further updates to this patch Ok, this version does not offer any "Huh?" experiences apart from the primitive-eval which has sort of an easy to understand cause and no really convincing workaround. Have you checked that something useful

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

Please review further updates to this patch https://codereview.appspot.com/108270043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

"Phil Holmes" writes: > - Original Message - I am not convinced that the results are "correct" when they are not scaled the same as every other measure including "\mm". Have you tried my proposal? >> >> I repeat: have you tried my proposal of treating incipit-width e

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: "David Kastrup" To: "Phil Holmes" Cc: Sent: Tuesday, August 12, 2014 4:00 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) "Phil Holmes" writes: - Original Message -

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

"Phil Holmes" writes: > - Original Message - > From: > To: ; ; > ; > Cc: ; > Sent: Tuesday, August 12, 2014 3:17 PM > Subject: Re: Adds incipit section to NR (issue 108270043 by > philehol...@googlemail.com) > > >> On 2014/08/12 13:58:44,

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; ; Cc: ; Sent: Tuesday, August 12, 2014 3:17 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/08/12 13:58:44, mail_philholmes.net wrote: The problem is the other way round. incipit-width is

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

"Phil Holmes" writes: > - Original Message - > From: > >> On 2014/08/12 12:16:12, mail_philholmes.net wrote: >>> From: >> >>> > >>> > Yes, I would object to scaling the dimensions of the incipit >>> > line-width >>> > and indent by the 1.76 factor since that is jus

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/12 13:58:44, mail_philholmes.net wrote: The problem is the other way round. incipit-width is not scaled within the layout block, and so produces correct results for width. I am not convinced that the results are "correct" when they are not scaled the same as every other measure i

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; ; Cc: ; Sent: Tuesday, August 12, 2014 1:56 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/08/12 12:16:12, mail_philholmes.net wrote: - Original Message - From: <mailto:d...@gnu.

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; ; ; Cc: ; Sent: Tuesday, August 12, 2014 2:01 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/08/12 12:16:12, mail_philholmes.net wrote: - Original Message - From: <mailto:d...@gnu.

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/12 12:16:12, mail_philholmes.net wrote: - Original Message - From: > > Yes, I would object to scaling the dimensions of the incipit line-width > and indent by the 1.76 factor since that is just an ad-hoc approximation > for a single case. Shame y

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/12 12:16:12, mail_philholmes.net wrote: - Original Message - From: To: ; ; Cc: ;

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/08/12 11:54:38, email_philholmes.net wrote: I can post this as a bug, but I'm guessing it would be tricky to fix. Would you object to scaling the dimensions of the incipit (in the incipit code) line-width and indent by the 1.76 factor, to work round the problem? Yes, I would object

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; Cc: ; Sent: Tuesday, August 12, 2014 12:46 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) https://codereview.appspot.com/108270043/diff/20001/ly/property-init.ly File ly/property-init.ly (right): https

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

https://codereview.appspot.com/108270043/diff/20001/ly/property-init.ly File ly/property-init.ly (right): https://codereview.appspot.com/108270043/diff/20001/ly/property-init.ly#newcode298 ly/property-init.ly:298: scale-factor = #1757/1000 Uh what? Why are you overriding the scale-factor here?

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

Please review. https://codereview.appspot.com/108270043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/06/29 16:51:06, email_philholmes.net wrote: You seem to have missed the point. Snippets are not judged by the lilypond code, but by the ability of the writer to include them into the documentation. I did not need to do this as a snippet, so I didn't. Not so. Please read Section 5.

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/06/29 16:51:06, email_philholmes.net wrote: - Original Message - From: To: ; Cc: ; Sent: Sunday, June 29, 2014 5:26

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; Cc: ; Sent: Sunday, June 29, 2014 5:26 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/06/29 15:15:51, email_philholmes.net wrote: From: <mailto:d...@gnu.org> To: <mailto

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/06/29 15:15:51, email_philholmes.net wrote: From: To: Cc: ; Sent: Sunday, June 29, 2014 3:44 PM Subject: Re: Adds incipit section to NR (issue 108270043

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: Cc: ; Sent: Sunday, June 29, 2014 3:44 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) https://codereview.appspot.com/108270043/diff/1/Documentation/notation/ancient.itely File Documentation/notation

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

https://codereview.appspot.com/108270043/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/108270043/diff/1/Documentation/notation/ancient.itely#newcode2663 Documentation/notation/ancient.itely:2663: incipit = That's not

Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

Reviewers: , Message: Please review. Description: Adds incipit section to NR Please review this at https://codereview.appspot.com/108270043/ Affected files (+126, -4 lines): M Documentation/notation/ancient.itely ___ lilypond-devel mailing list