----- Original Message -----
From: <d...@gnu.org>
To: <philehol...@googlemail.com>; <tdanielsmu...@googlemail.com>;
<em...@philholmes.net>; <m...@philholmes.net>; <benko....@gmail.com>
Cc: <lilypond-devel@gnu.org>; <re...@codereview-hr.appspotmail.com>
Sent: Thursday, August 21, 2014 12:31 PM
Subject: Re: Adds incipit section to NR (issue 108270043 by
philehol...@googlemail.com)
On 2014/08/21 10:21:18, mail_philholmes.net wrote:
There's nothing wrong in changing a poor default to a good one, and
then
allowing the user to restore the poor one.
But you are not "changing a poor default to a good one". You are
overriding locally, as the default of a single command, what you
perceive as a poor overall default. If the default is poor, changing
it is reasonably. Scattering different defaults everywhere where
someone adds code isn't.
Please note that if the incipit command changes some _entirely_
_unrelated_ default, then the description of the incipit would need to
include "as one side effect, the alignment of the instrument name is
changed from its default of #CENTER to #RIGHT because #CENTER looks
ugly anyway." Not in relation to incipits, but anyway.
I'm failing to understand something here. I'm assuming the line at issue is
this:
\once \override Staff.InstrumentName.self-alignment-X = #RIGHT
which is the line that sets the instrument alignment of the incipit
instrument itself. My assumption is that, since is is using \once, then it
is not changing another entirely unrelated default. Please could you
explain how/why/whether this is incorrect, and how/whether it could be
fixed. I really don't like having to specify \incipit \with { \override
InstrumentName.self-alignment-X = #RIGHT } because I do believe that this
should be default behaviour in this situation.
--
Phil Holmes
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
