On 2014/08/19 20:22:01, email_philholmes.net wrote:
----- Original Message -----
From: <mailto:d...@gnu.org>
To: <mailto:philehol...@googlemail.com>;
<mailto:tdanielsmu...@googlemail.com>;
<mailto:em...@philholmes.net>; <mailto:m...@philholmes.net>;
<mailto:benko....@gmail.com>
Cc: <mailto:lilypond-devel@gnu.org>;
<mailto:re...@codereview-hr.appspotmail.com>
Sent: Tuesday, August 19, 2014 6:11 PM
Subject: Re: Adds incipit section to NR (issue 108270043 by
mailto:philehol...@googlemail.com)
>
>
https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly
> File ly/property-init.ly (right):
>
>
https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly#newcode293
> ly/property-init.ly:293: \once \override
> Staff.InstrumentName.self-alignment-X = #RIGHT
> I don't think we should prescribe
Staff.InstrumentName.self-alignment-X
> here. That is a user preference. While it would be nice to glean
that
> information from the outer Staff.InstrumentName.self-alignment-X,
that's
> likely tricky to do while at the same time overriding the
> Staff.InstrumentName settings.
>
> So I'd rather suggest the syntax
> \incipit \with { \override InstrumentName.self-alignment-X = #RIGHT
}
> {...}
Don't agree at all. I'd accept it if you proposed an alternative that
left
aligned the instrument name as a possible option,
The optional context mod obviously allows choosing any default that can
be explicitly overridden by the user.
but as it is, I believe
right alignment is the correct option here.
Why would the correct default alignment for an instrument name before an
incipit be explicitly different from the correct default alignment for
an instrument name before an incipit-less staff?
Don't accept this change should delay pushing this patch.
So what is the reasoning behind changing the default instrument
placement before an incipit?
https://codereview.appspot.com/108270043/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
