----- Original Message ----- From: <d...@gnu.org>
To: <philehol...@googlemail.com>; <tdanielsmu...@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <re...@codereview-hr.appspotmail.com>
Sent: Saturday, August 16, 2014 2:53 PM
Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)


On 2014/08/16 13:12:56, PhilEHolmes wrote:
Please review further updates to this patch

Ok, this version does not offer any "Huh?" experiences apart from the
primitive-eval which has sort of an easy to understand cause and no
really convincing workaround.  Have you checked that something useful
happens when incipit-width is undefined?  Half of the time I stare at
that false-if-exception I am not really sure it will trigger at the
right moment.

https://codereview.appspot.com/108270043/

Yes, I have. As hoped for, it the incipit staff is half the width of the indent.

--
Phil Holmes

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to