[
https://issues.apache.org/jira/browse/KAFKA-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946361#comment-17946361
]
Edoardo Comar commented on KAFKA-19026:
---
[~showuon] the impact is that the a polic
showuon commented on PR #19518:
URL: https://github.com/apache/kafka/pull/19518#issuecomment-2820654909
@frankvicky @mumrah , I just cherry-pick to 3.9 branch and ran the release
script, [the
tag](https://github.com/apache/kafka/commit/1f18da31126f47bc751cbe813302df9b853c2b96)
showed corre
showuon merged PR #19518:
URL: https://github.com/apache/kafka/pull/19518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-19166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-19166.
---
Fix Version/s: 3.9.1
Resolution: Fixed
> Release tags are orphaned
>
FrankYang0529 opened a new pull request, #19532:
URL: https://github.com/apache/kafka/pull/19532
The remote storage reader thread pool use same count for both maximum and
core size. If users adjust the pool size larger than original value, it throws
`IllegalArgumentException`. Updated both
apoorvmittal10 merged PR #19200:
URL: https://github.com/apache/kafka/pull/19200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.
johnny94 commented on PR #19306:
URL: https://github.com/apache/kafka/pull/19306#issuecomment-2820420761
@chia7712 Thanks. Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
AndrewJSchofield opened a new pull request, #19533:
URL: https://github.com/apache/kafka/pull/19533
Small improvements to share consumer javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
lucasbru commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2053570555
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -182,6 +186,7 @@ public void testDowngradeWithReleaseVersion(ClusterInstance
cluster) {
dejan2609 commented on PR #19200:
URL: https://github.com/apache/kafka/pull/19200#issuecomment-2820292214
@apoorvmittal10 Changes are rebased onto trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AndrewJSchofield merged PR #19378:
URL: https://github.com/apache/kafka/pull/19378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
[
https://issues.apache.org/jira/browse/KAFKA-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-19057.
--
Fix Version/s: 4.1.0
Resolution: Fixed
> Stabilize KIP-932 Kafka protocol RPC d
aliehsaeedii commented on PR #19450:
URL: https://github.com/apache/kafka/pull/19450#issuecomment-2820937618
> Would be good to at least add one more test to `StreamsTaskTest`;
something like `shouldNotGetOffsetsIfPerpareCommitDirty()` verifying that we
return `null`, and ideally also that
[
https://issues.apache.org/jira/browse/KAFKA-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chirag Wadhwa updated KAFKA-19181:
--
Description:
The nightly runs for system tests has picked failures for the following 2 tests
ableegoldman commented on code in PR #19400:
URL: https://github.com/apache/kafka/pull/19400#discussion_r2053464025
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1205,45 +1200,9 @@ private Optional removeStreamThread(final long
timeoutMs) throws Ti
priyankaku commented on PR #19449:
URL: https://github.com/apache/kafka/pull/19449#issuecomment-2820558235
@FrankYang0529 : If you get sometime , Could you please re review the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
AndrewJSchofield commented on code in PR #19505:
URL: https://github.com/apache/kafka/pull/19505#discussion_r2053974468
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigTest.java:
##
@@ -89,24 +87,6 @@ public void testInvalidConf
showuon opened a new pull request, #19534:
URL: https://github.com/apache/kafka/pull/19534
Ran system test based on 3.9 branch, but got the error:
`Did expect to read 'Kafka version.*3.9.1.*SNAPSHOT' from ducker@ducker04`.
It's because the version should be `3.9.1` without snapshot. Upda
showuon commented on PR #19534:
URL: https://github.com/apache/kafka/pull/19534#issuecomment-2821142000
@frankvicky , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
OmniaGM commented on PR #15968:
URL: https://github.com/apache/kafka/pull/15968#issuecomment-2821525320
> @OmniaGM : Thanks for the updated PR. A few more comments.
>
> Also, could you run producer performance test to make sure there is no
performance degradation with this PR? Thanks.
frankvicky commented on PR #19531:
URL: https://github.com/apache/kafka/pull/19531#issuecomment-2821209765
Hi @RaphaelFakhri
As @FrankYang0529 said, if you are willing to contribute, please refer to
the [contributing guide](https://kafka.apache.org/contributing.html).
If you are willi
frankvicky merged PR #19534:
URL: https://github.com/apache/kafka/pull/19534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
FrankYang0529 commented on PR #19531:
URL: https://github.com/apache/kafka/pull/19531#issuecomment-2821177507
Hi @RaphaelFakhri, I will handle the issue KAFKA-19183. Could you check with
Jira owner before creating PR next time? Thanks.
--
This is an automated message from the Apache Git S
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054229795
##
raft/src/main/java/org/apache/kafka/raft/internals/KRaftVersionUpgrade.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054236070
##
raft/src/main/java/org/apache/kafka/raft/internals/UpdateVoterHandler.java:
##
@@ -104,26 +111,39 @@ public CompletableFuture
handleUpdateVoterRequest(
AndrewJSchofield merged PR #19533:
URL: https://github.com/apache/kafka/pull/19533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054309528
##
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##
@@ -250,6 +251,26 @@ public Optional updateVoter(VoterNode voter) {
return Optional.empty();
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054312236
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java:
##
@@ -2085,8 +2091,8 @@ void testFollowerSendsUpdateVoter() throws Exception {
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054315940
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java:
##
@@ -2085,8 +2091,8 @@ void testFollowerSendsUpdateVoter() throws Exception {
kirktrue commented on code in PR #19440:
URL: https://github.com/apache/kafka/pull/19440#discussion_r2054567227
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -3799,10 +3799,11 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES, n
[
https://issues.apache.org/jira/browse/KAFKA-15615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946415#comment-17946415
]
appchemist edited comment on KAFKA-15615 at 4/22/25 1:01 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-15615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946415#comment-17946415
]
appchemist commented on KAFKA-15615:
Is this patch no longer necessary?
If no longer
apoorvmittal10 merged PR #19500:
URL: https://github.com/apache/kafka/pull/19500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.
OmniaGM commented on PR #15968:
URL: https://github.com/apache/kafka/pull/15968#issuecomment-2821595902
> > @OmniaGM : Thanks for the updated PR. A few more comments.
> > Also, could you run producer performance test to make sure there is no
performance degradation with this PR? Thanks.
Alieh Saeedi created KAFKA-19185:
Summary: Logging Enhancements in the FETCH requests and their
correlation IDs
Key: KAFKA-19185
URL: https://issues.apache.org/jira/browse/KAFKA-19185
Project: Kafka
apoorvmittal10 opened a new pull request, #19536:
URL: https://github.com/apache/kafka/pull/19536
This PR marks the records as non-nullable for ShareFetch.
This PR is as per the changes for Fetch:
https://github.com/apache/kafka/pull/18726 and some work for ShareFetch was
done here:
ahuang98 commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054482950
##
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##
@@ -250,6 +251,26 @@ public Optional updateVoter(VoterNode voter) {
return Optional.empty();
ahuang98 commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054487522
##
raft/src/main/java/org/apache/kafka/raft/internals/UpdateVoterHandler.java:
##
@@ -104,26 +111,39 @@ public CompletableFuture
handleUpdateVoterRequest(
mumrah commented on PR #19518:
URL: https://github.com/apache/kafka/pull/19518#issuecomment-2821294785
thanks @showuon!
@frankvicky, if we see that error again, we might need to include
"--ff-only" to the merge command to prevent the merge commit. You might be
seeing that due to loc
[
https://issues.apache.org/jira/browse/KAFKA-19159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-19159.
---
Resolution: Fixed
> Remove time based eviction of share sessions from the cache
> --
[
https://issues.apache.org/jira/browse/KAFKA-19159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal updated KAFKA-19159:
--
Fix Version/s: 4.1.0
> Remove time based eviction of share sessions from the cache
> -
AndrewJSchofield commented on code in PR #19508:
URL: https://github.com/apache/kafka/pull/19508#discussion_r2054264463
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3524,44 +3524,62 @@ void handleResponse(AbstractResponse abstractResponse
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2051808839
##
raft/src/main/java/org/apache/kafka/raft/internals/Pair.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * cont
FrankYang0529 opened a new pull request, #19535:
URL: https://github.com/apache/kafka/pull/19535
1. Replace `Pool.scala` with `ConcurrentHashMap`.
2. Remove `PoolTest.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-16906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaushik Raina updated KAFKA-16906:
--
Fix Version/s: 4.1.0
> Add consistent error handling for Transactions
> --
chirag-wadhwa5 opened a new pull request, #19541:
URL: https://github.com/apache/kafka/pull/19541
The system test `ShareConsumerTest.test_share_multiple_partitions` started
failing because of the recent change in the SimpleAssignor algorithm. The tests
assumed that if a share group is subsc
[
https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946407#comment-17946407
]
Stanislav Spiridonov commented on KAFKA-18713:
--
[~mjsax] Do you know the es
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054252657
##
raft/src/main/java/org/apache/kafka/raft/internals/UpdateVoterHandler.java:
##
@@ -104,26 +111,39 @@ public CompletableFuture
handleUpdateVoterRequest(
Abhinav Dixit created KAFKA-19187:
-
Summary: MINOR: Disallow raw types and fail build for test files
Key: KAFKA-19187
URL: https://issues.apache.org/jira/browse/KAFKA-19187
Project: Kafka
Iss
DL1231 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2055365066
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -3003,24 +3014,32 @@ private boolean hasOngoingStateTransition() {
* if the state update is
rreddy-22 closed pull request #19530: KAFKA-19082:[3/4] Add prepare txn method
(KIP-939)
URL: https://github.com/apache/kafka/pull/19530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054345436
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java:
##
@@ -2130,6 +2136,444 @@ void testFollowerSendsUpdateVoter() throws Exception {
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054351475
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -609,6 +708,161 @@ public void testBeginQuorumEpochTimer(boolean
withDirectoryId) {
as
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054506081
##
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##
@@ -250,6 +251,26 @@ public Optional updateVoter(VoterNode voter) {
return Optional.empty();
junrao commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2054494297
##
core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala:
##
@@ -85,4 +85,80 @@ class ProducerSendWhileDeletionTest extends
IntegrationTestHarne
[
https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946481#comment-17946481
]
Matthias J. Sax commented on KAFKA-18713:
-
It's active WIP – but alway hard to k
dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2055327871
##
clients/src/main/resources/common/message/OffsetCommitRequest.json:
##
@@ -36,8 +36,11 @@
//
// Version 9 is the first version that can be used with the new cons
David Jacot created KAFKA-19186:
---
Summary: Mark OffsetCommit and OffsetFetch APIs as stable
Key: KAFKA-19186
URL: https://issues.apache.org/jira/browse/KAFKA-19186
Project: Kafka
Issue Type: Su
dajac merged PR #19461:
URL: https://github.com/apache/kafka/pull/19461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-19185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alieh Saeedi reassigned KAFKA-19185:
Assignee: Alieh Saeedi
> Logging Enhancements in the FETCH requests and their correlation
jolshan commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2055103683
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Ot
mjsax commented on code in PR #19538:
URL: https://github.com/apache/kafka/pull/19538#discussion_r2055095933
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java:
##
@@ -131,6 +131,7 @@ public RequestFuture send(Node node,
Clie
AndrewJSchofield commented on PR #19536:
URL: https://github.com/apache/kafka/pull/19536#issuecomment-2822398563
> So in this PR: https://github.com/apache/kafka/pull/19131/files the field
was made nullable again. I aligned the changes as per regular Fetch behaviour.
I know there was
bbejeck commented on PR #18673:
URL: https://github.com/apache/kafka/pull/18673#issuecomment-2822420681
merged #18673 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
lianetm commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2054800972
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -727,7 +727,7 @@ public NetworkClientDelegate.UnsentRequest
toUns
bbejeck merged PR #18673:
URL: https://github.com/apache/kafka/pull/18673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-19185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alieh Saeedi updated KAFKA-19185:
-
Description:
We need to gather more logs, particularly focusing on the {{FETCH}} requests
and t
[
https://issues.apache.org/jira/browse/KAFKA-18572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-18572:
Fix Version/s: 4.1.0
> Update Kafka Streams metric documenation
>
cmccabe merged PR #19416:
URL: https://github.com/apache/kafka/pull/19416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
k-raina commented on code in PR #17022:
URL: https://github.com/apache/kafka/pull/17022#discussion_r2054686862
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -737,14 +737,25 @@ public synchronized void
maybeTransitionToErrorS
kevin-wu24 opened a new pull request, #19537:
URL: https://github.com/apache/kafka/pull/19537
add ipv6 support to `ducker-ak`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
apoorvmittal10 commented on PR #19536:
URL: https://github.com/apache/kafka/pull/19536#issuecomment-2822302346
> Should the `records` field in the `ShareFetchResponse.json` be
non-nullable too? I notice that it permits nulls.
So in this PR: https://github.com/apache/kafka/pull/19131/f
junrao commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2054969905
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Oth
junrao commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2055067721
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Oth
aliehsaeedii opened a new pull request, #19538:
URL: https://github.com/apache/kafka/pull/19538
This PR aims at enhancing logging in `Consumer` request/response as follows:
- Logging when a FETCH request is generated, including the correlation ID.
- Logging the response received before
jolshan commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2054791143
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Ot
k-raina commented on code in PR #17022:
URL: https://github.com/apache/kafka/pull/17022#discussion_r2054686862
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -737,14 +737,25 @@ public synchronized void
maybeTransitionToErrorS
k-raina commented on code in PR #17022:
URL: https://github.com/apache/kafka/pull/17022#discussion_r2054686862
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -737,14 +737,25 @@ public synchronized void
maybeTransitionToErrorS
jolshan commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2055013844
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Ot
DL1231 opened a new pull request, #19540:
URL: https://github.com/apache/kafka/pull/19540
Enhance AuthorizerIntegrationTest for share group APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
DL1231 commented on PR #19540:
URL: https://github.com/apache/kafka/pull/19540#issuecomment-2822945010
https://github.com/apache/kafka/blob/b97a130c0874bae0ad47a903921074405ac3c4df/core/src/main/scala/kafka/server/KafkaApis.scala#L3667C1-L3670C6
If `authorizedTopics` is empty, an empty re
github-actions[bot] commented on PR #19476:
URL: https://github.com/apache/kafka/pull/19476#issuecomment-2822959679
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18912:
URL: https://github.com/apache/kafka/pull/18912#issuecomment-2822959986
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
[
https://issues.apache.org/jira/browse/KAFKA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-17939:
---
Assignee: Siddhartha Devineni
> Kafka Streams API exposes org.apache.kafka.common.u
84 matches
Mail list logo
