AndrewJSchofield commented on code in PR #19508:
URL: https://github.com/apache/kafka/pull/19508#discussion_r2054264463


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -3524,44 +3524,62 @@ void handleResponse(AbstractResponse abstractResponse) {
                 for (final Node node : allNodes) {
                     final long nowList = time.milliseconds();
                     runnable.call(new Call("listGroups", deadline, new 
ConstantNodeIdProvider(node.id())) {
+
+                        // If only regular consumer group types are required, 
we can try an earlier request version if
+                        // UnsupportedVersionException is thrown
+                        final boolean canTryEarlierRequestVersion = 
options.regularConsumerGroupTypes();

Review Comment:
   I've taken this suggestion and tweaked it a bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to