lianetm commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2054800972
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -727,7 +727,7 @@ public NetworkClientDelegate.UnsentRequest
toUnsentRequest() {
lastEpochSentOnCommit = Optional.empty();
}
- OffsetCommitRequest.Builder builder = new
OffsetCommitRequest.Builder(data);
+ OffsetCommitRequest.Builder builder =
OffsetCommitRequest.Builder.forTopicNames(data);
Review Comment:
just for the record, this I expect is temporary and will change to
forTopicIdsOrNames once we include client support for the new RPC versions
##########
clients/src/main/resources/common/message/OffsetCommitRequest.json:
##########
@@ -36,8 +36,11 @@
//
// Version 9 is the first version that can be used with the new consumer
group protocol (KIP-848). The
// request is the same as version 8.
- "validVersions": "2-9",
+ //
+ // Version 10 adds support for topic ids and removes support for topic names
(KIP-848).
+ "validVersions": "2-10",
"flexibleVersions": "8+",
+ "latestVersionUnstable": true,
Review Comment:
do we need a Jira to mark this as stable later on? (I guess we'll wait to
complete the broker side, and the client side, just in case we decide to adjust
something along the way?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
