aliehsaeedii commented on PR #19450: URL: https://github.com/apache/kafka/pull/19450#issuecomment-2820937618
> Would be good to at least add one more test to `StreamsTaskTest`; something like `shouldNotGetOffsetsIfPerpareCommitDirty()` verifying that we return `null`, and ideally also that `committableOffsetsAndMetadata()` was not called (the second check is more tricky -- need some creativity I guess). I think the 2nd check is not necessary since if `committableOffsetsAndMetadata()` is called, then `prepareCommit(bool)` would return a map and not `NULL`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
