ahuang98 commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2054482950
##########
raft/src/main/java/org/apache/kafka/raft/VoterSet.java:
##########
@@ -250,6 +251,26 @@ public Optional<VoterSet> updateVoter(VoterNode voter) {
return Optional.empty();
}
+ /**
+ * Update a voter by only comparing the node id.
+ *
+ * This update voter operation doesn't compare the directory id. This is
useful when upgrading
+ * from a voter set that doesn't support directory id to one that supports
directory ids.
Review Comment:
I see, and we allow updating a voter after a disk replacement in this manner
only w/ kraft.version 0? In kraft.version 1 would we necessarily have to remove
and then add voter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
