junrao commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2054969905
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2468,7 +2483,7 @@ class KafkaApis(val requestChannel: RequestChannel,
} else {
// Otherwise, the regular appendRecords path is used for all the
non __consumer_offsets
// partitions or for all partitions when the new group coordinator
is disabled.
- controlRecords += partition ->
MemoryRecords.withEndTransactionMarker(
+ controlRecords += replicaManager.topicIdPartition(partition) ->
MemoryRecords.withEndTransactionMarker(
Review Comment:
Yes, if AddPartitionsToTxnRequest and WriteTxnMarkersRequest both use
topicId, we could use it directly here.
Do you still have any concerns on this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
