jsancio commented on code in PR #19416: URL: https://github.com/apache/kafka/pull/19416#discussion_r2054315940
########## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ########## @@ -2085,8 +2091,8 @@ void testFollowerSendsUpdateVoter() throws Exception { .withLocalListeners(localListeners) .build(); - // waiting for 3 times the fetch timeout sends an update voter - for (int i = 0; i < 3; i++) { + // waiting for FETCH request until the UpdateRaftVoter request is set + for (int i = 0; i < NUMBER_FETCH_TIMEOUTS_IN_UPDATE_PERIOD; i++) { Review Comment: No but that's because I changed the update voter timer from `3 * fetch timeout` to just `fetch timeout`. I figured that I should leave it parametrized incase we later decide to change the update voter timer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org