[GitHub] [flink] JingsongLi commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp…

JingsongLi commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp… URL: https://github.com/apache/flink/pull/8397#issuecomment-492102837 I think you should add some detailed benchmarks, as we discussed in JIRA. --

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283648244 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283644686 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/t

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283644935 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283645956 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283643553 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/t

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283646821 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283645513 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache

[GitHub] [flink] YueYeShen commented on issue #8384: [FLINK-11610][docs-zh] Translate the "Examples" page into Chinese

YueYeShen commented on issue #8384: [FLINK-11610][docs-zh] Translate the "Examples" page into Chinese URL: https://github.com/apache/flink/pull/8384#issuecomment-492102056 > Thanks @YueYeShen , the translation looks good to me now. > > Will merge it. Thank you , Jark

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283644316 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/t

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283646615 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/

[GitHub] [flink] twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

twalthr commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283645152 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/

[GitHub] [flink] JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

JingsongLi commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283645950 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apac

[GitHub] [flink] dawidwys commented on issue #8419: [hotfix][examples] Fix the streaming example of TopSpeedWindowing 's increased distance in 100ms

dawidwys commented on issue #8419: [hotfix][examples] Fix the streaming example of TopSpeedWindowing 's increased distance in 100ms URL: https://github.com/apache/flink/pull/8419#issuecomment-492100427 @flinkbot approve description --

[GitHub] [flink] flinkbot edited a comment on issue #8419: [hotfix][examples] Fix the streaming example of TopSpeedWindowing 's increased distance in 100ms

flinkbot edited a comment on issue #8419: [hotfix][examples] Fix the streaming example of TopSpeedWindowing 's increased distance in 100ms URL: https://github.com/apache/flink/pull/8419#issuecomment-491564526 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot

[GitHub] [flink] liyafan82 commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp…

liyafan82 commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp… URL: https://github.com/apache/flink/pull/8397#issuecomment-492099582 Hi @KurtYoung , would you please help review this PR? It also fix a bug in the code-gen logic. -

[GitHub] [flink] dawidwys commented on issue #8418: [FLINK-12491][docs][configuration] Fix incorrect javadoc for path sep…

dawidwys commented on issue #8418: [FLINK-12491][docs][configuration] Fix incorrect javadoc for path sep… URL: https://github.com/apache/flink/pull/8418#issuecomment-492097883 What do you think @aljoscha? Which separators should we support? -

[jira] [Commented] (FLINK-5243) Implement an example for BipartiteGraph

[ https://issues.apache.org/jira/browse/FLINK-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839117#comment-16839117 ] Ivan Mushketyk commented on FLINK-5243: --- Sure Jasleen. Go ahead. > Implement an

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283635811 ## File path: flink-core/src/main/java/org/apache/flink/cor

[GitHub] [flink] wuchong commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

wuchong commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#discussion_r283635271 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/

[GitHub] [flink] yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink

yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067#issuecomment-492088145 @twalthr , @rmetzger, @fhueske could you help to review this pr, or point us to the right person for reviewing? we h

[GitHub] [flink] yuyang08 commented on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink

yuyang08 commented on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067#issuecomment-492088145 @twalthr , @rmetzger could you help to review this pr, or point us to the right person for reviewing? we have tested this ch

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283633644 ## File path: flink-python/pyflink/table/table_config.py ## @@ -44,18 +47,55 @@

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283633442 ## File path: flink-python/pyflink/table/table.py ## @@ -118,3 +463,112 @@ def i

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283633425 ## File path: flink-python/pyflink/table/table.py ## @@ -118,3 +463,112 @@ def i

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283633274 ## File path: flink-python/pyflink/table/table.py ## @@ -118,3 +463,112 @@ def i

[jira] [Commented] (FLINK-5243) Implement an example for BipartiteGraph

[ https://issues.apache.org/jira/browse/FLINK-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839089#comment-16839089 ] Jasleen Kaur commented on FLINK-5243: - [~ivan.mushketyk] Can I take this issue? > Im

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283632066 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def w

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283632055 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def w

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283631890 ## File path: flink-python/pyflink/table/tests/test_batch_table_api.py ## @@ -0,

[GitHub] [flink] wuchong commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

wuchong commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283631948 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def wher

[GitHub] [flink] wuchong opened a new pull request #8436: [FLINK-12507][table-runtime-blink] Fix AsyncLookupJoin doesn't close all generated ResultFutures

wuchong opened a new pull request #8436: [FLINK-12507][table-runtime-blink] Fix AsyncLookupJoin doesn't close all generated ResultFutures URL: https://github.com/apache/flink/pull/8436 ## What is the purpose of the change The `AsyncLookupJoin` doesn't close all the genera

[jira] [Updated] (FLINK-12507) Fix AsyncLookupJoin doesn't close all generated ResultFutures

[ https://issues.apache.org/jira/browse/FLINK-12507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12507: --- Labels: pull-request-available (was: ) > Fix AsyncLookupJoin doesn't close all generated Re

[GitHub] [flink] flinkbot commented on issue #8436: [FLINK-12507][table-runtime-blink] Fix AsyncLookupJoin doesn't close all generated ResultFutures

flinkbot commented on issue #8436: [FLINK-12507][table-runtime-blink] Fix AsyncLookupJoin doesn't close all generated ResultFutures URL: https://github.com/apache/flink/pull/8436#issuecomment-492084529 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I hel

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283631291 ## File path: flink-python/pyflink/table/window.py ## @@ -0,0 +1,482 @@ +###

[jira] [Created] (FLINK-12507) Fix AsyncLookupJoin doesn't close all generated ResultFutures

Jark Wu created FLINK-12507: --- Summary: Fix AsyncLookupJoin doesn't close all generated ResultFutures Key: FLINK-12507 URL: https://issues.apache.org/jira/browse/FLINK-12507 Project: Flink Issue Ty

[GitHub] [flink] wuchong commented on issue #8384: [FLINK-11610][docs-zh] Translate the "Examples" page into Chinese

wuchong commented on issue #8384: [FLINK-11610][docs-zh] Translate the "Examples" page into Chinese URL: https://github.com/apache/flink/pull/8384#issuecomment-492083048 Thanks @YueYeShen , the translation looks good to me now. Will merge it. ---

[GitHub] [flink] bowenli86 removed a comment on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

bowenli86 removed a comment on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#issuecomment-492080766 @xuefuz @irui-apache @zjuwangg can you please take a look? --

[GitHub] [flink] bowenli86 commented on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

bowenli86 commented on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#issuecomment-492080788 @xuefuz @irui-apache @zjuwangg can you please take a look? --

[GitHub] [flink] bowenli86 opened a new pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

bowenli86 opened a new pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434 ## What is the purpose of the change This PR supports view related operations in `HiveCatalog` and creates `HiveCatalogView`.

[GitHub] [flink] bowenli86 closed pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

bowenli86 closed pull request #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [flink] bowenli86 commented on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog

bowenli86 commented on issue #8434: [FLINK-12234][hive] Support view related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8434#issuecomment-492080766 @xuefuz @irui-apache @zjuwangg can you please take a look? --

[GitHub] [flink] bowenli86 commented on issue #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses

bowenli86 commented on issue #8433: [FLINK-12505][hive] Unify database operations to HiveCatalogBase from its subclasses URL: https://github.com/apache/flink/pull/8433#issuecomment-492080742 @xuefuz @irui-apache @zjuwangg can you please take a look?

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283624288 ## File path: flink-python/pyflink/table/table_config.py ## @@ -44,18 +47,55 @@

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283622904 ## File path: flink-python/pyflink/table/table.py ## @@ -118,3 +463,112 @@ def i

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283622685 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def w

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283622697 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def w

[GitHub] [flink] WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283622709 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def w

[GitHub] [flink] zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#issuecomment-492074867 As for `ResultPartitionFactory`: The `ShuffleService` already takes the role of facto

[GitHub] [flink] zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#issuecomment-492072639 Commits for `PartitionBufferPoolFactory`: In my previous review I saw it was not in t

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283619819 ## File path: flink-runtime/src/main/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283619661 ## File path: flink-runtime/src/main/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#issuecomment-492070855 @azagrebin thanks for the confirmation. As for `PartitionBufferPoolFactory`:

[GitHub] [flink] godfreyhe commented on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

godfreyhe commented on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8389#issuecomment-492069318 @walterddr thanks for the fix. It's a little difficult for users to understand `explainSource` and

[GitHub] [flink] godfreyhe commented on a change in pull request #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

godfreyhe commented on a change in pull request #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8389#discussion_r283616783 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/fl

[GitHub] [flink] WeiZhong94 commented on issue #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API.

WeiZhong94 commented on issue #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API. URL: https://github.com/apache/flink/pull/8392#issuecomment-492064023 @sunjincheng121 Thanks for your review! Sorry for these mistakes. I have fixed them in the new commit and ensure

[GitHub] [flink] wuchong commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

wuchong commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283609527 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/

[GitHub] [flink] Mr-Nineteen closed pull request #8229: [FLINK-12273]The default value of CheckpointRetentionPolicy should be …

Mr-Nineteen closed pull request #8229: [FLINK-12273]The default value of CheckpointRetentionPolicy should be … URL: https://github.com/apache/flink/pull/8229 This is an automated message from the Apache Git Service. To respo

[GitHub] [flink] Mr-Nineteen commented on issue #8229: [FLINK-12273]The default value of CheckpointRetentionPolicy should be …

Mr-Nineteen commented on issue #8229: [FLINK-12273]The default value of CheckpointRetentionPolicy should be … URL: https://github.com/apache/flink/pull/8229#issuecomment-492060134 @StephanEwen Ok. I think it's important to change this default.If some users don't know much about fli

[jira] [Updated] (FLINK-12443) Replace InternalType with LogicalType in blink runner

[ https://issues.apache.org/jira/browse/FLINK-12443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12443: --- Labels: pull-request-available (was: ) > Replace InternalType with LogicalType in blink run

[GitHub] [flink] flinkbot commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

flinkbot commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435#issuecomment-492059404 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] JingsongLi opened a new pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

JingsongLi opened a new pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435 ## What is the purpose of the change Use new LogicalType in blink planner. NOTE: Use only LogicalType to ove

[jira] [Updated] (FLINK-12405) Introduce BLOCKING_PERSISTENT result partition type

[ https://issues.apache.org/jira/browse/FLINK-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruidong Li updated FLINK-12405: --- Description: The new {{ResultPartitionType}} : {{BLOCKING_PERSISTENT}} is similar to {{BLOCKING}} e

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283604284 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283603446 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283603987 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283603486 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283598406 ## File path: flink-table/flink-table-planner-blink/src/main/scala/or

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283607890 ## File path: flink-table/flink-table-planner-blink/src/test/scala/or

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283603324 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283602389 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[jira] [Closed] (FLINK-12380) Add thread name in the log4j.properties

[ https://issues.apache.org/jira/browse/FLINK-12380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-12380. Resolution: Information Provided > Add thread name in the log4j.properties > -

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283604242 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283604194 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283604565 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283604420 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283600244 ## File path: flink-table/flink-table-planner-blink/src/main/scala/or

[GitHub] [flink] KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283598342 ## File path: flink-table/flink-table-planner-blink/src/main/scala/or

[jira] [Created] (FLINK-12506) Add more over window unit tests

Kurt Young created FLINK-12506: -- Summary: Add more over window unit tests Key: FLINK-12506 URL: https://issues.apache.org/jira/browse/FLINK-12506 Project: Flink Issue Type: Improvement

[GitHub] [flink] Armstrongya commented on a change in pull request #8366: [FLINK-12415][doc-zh]Translate HistoryServer page into Chinese

Armstrongya commented on a change in pull request #8366: [FLINK-12415][doc-zh]Translate HistoryServer page into Chinese URL: https://github.com/apache/flink/pull/8366#discussion_r283605925 ## File path: docs/monitoring/historyserver.zh.md ## @@ -22,62 +22,62 @@ specific la

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283605276 ## File path: flink-python/pyflink/table/tests/test_batch_table_api.py ## @@ -0,0 +1

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283604935 ## File path: flink-python/pyflink/table/table_config.py ## @@ -44,18 +47,55 @@ def

[GitHub] [flink] kisimple commented on issue #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor

kisimple commented on issue #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor URL: https://github.com/apache/flink/pull/7757#issuecomment-492054384 Highly appreciate your review :) @azagrebin I have addressed the comments. --

[GitHub] [flink] flinkbot edited a comment on issue #8420: [FLINK-12408][python] Allow to define the data types in Python

flinkbot edited a comment on issue #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#issuecomment-491604302 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revie

[GitHub] [flink] sunjincheng121 commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python

sunjincheng121 commented on issue #8420: [FLINK-12408][python] Allow to define the data types in Python URL: https://github.com/apache/flink/pull/8420#issuecomment-492054007 @flinkbot attention @twalthr This is an automated

[jira] [Assigned] (FLINK-12494) JDBCOutputFormat support reconnect when link failure and flush by timeInterval

[ https://issues.apache.org/jira/browse/FLINK-12494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaoshijie reassigned FLINK-12494: -- Assignee: zhaoshijie > JDBCOutputFormat support reconnect when link failure and flush by time

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283585908 ## File path: flink-python/pyflink/table/tests/test_batch_table_api.py ## @@

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283601896 ## File path: flink-python/pyflink/table/table_config.py ## @@ -44,18 +47,55

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283588400 ## File path: flink-python/pyflink/table/query_config.py ## @@ -0,0 +1,108 @

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283589060 ## File path: flink-python/pyflink/table/query_config.py ## @@ -0,0 +1,108 @

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283588406 ## File path: flink-python/pyflink/table/query_config.py ## @@ -0,0 +1,108 @

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283589635 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ d

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283586736 ## File path: flink-python/pyflink/table/tests/test_batch_table_api.py ## @@

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283596541 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ d

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283589608 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ d

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283602349 ## File path: flink-python/pyflink/table/table_config.py ## @@ -44,18 +47,55

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283590341 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ d

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283590748 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ d

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283601943 ## File path: flink-python/pyflink/table/table_config.py ## @@ -44,18 +47,55

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283583541 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ d

  1   2   3   4   >