zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#issuecomment-492072639 Commits for `PartitionBufferPoolFactory`: In my previous review I saw it was not in the constructor of `NetworkEnvironment` in that commit, and then changed into the constructor in the following commit. So I mean the first introduced commit should be squashed with following commit to make sure it is in the constructor when introduced. Now I see it is already in right state, maybe some UI issue for commit sequence you confirmed before. :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services