twalthr commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r283648244
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/DeclarativeAggregateFunction.java
##########
@@ -62,7 +62,7 @@
/**
* All types of the aggregate buffer.
*/
- public abstract InternalType[] getAggBufferTypes();
+ public abstract LogicalType[] getAggBufferTypes();
Review comment:
The user should not be confronted to two different type stacks. That's why
the description in `DataType` calls it "hints", a user should always use
DataType. If he adds a hint where it is not appropriate, we just don't need to
use those hints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
