zhijiangW commented on issue #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#issuecomment-492074867 As for `ResultPartitionFactory`: The `ShuffleService` already takes the role of factory for creating partition/gate. Of course we could further extract a specific factory component from `ShuffleService`. But I think the factory might be different for different `ShuffleService` implementations, and it is regarded as a private tool inside specific `ShuffleService` implementation. E.g. for `FSShuffleService#FSResultPartition`, we might do not need the institute of `subpartition`, only need the logic `subpartition` index. Also for interactive queries, if it wants to reuse the `ResultPartitionWriter`, it also does not need to construct `subpartition` inside specific instance.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
