sunjincheng121 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283601896
########## File path: flink-python/pyflink/table/table_config.py ########## @@ -44,18 +47,55 @@ def parallelism(self): def parallelism(self, parallelism): self._parallelism = parallelism + @property + def timezone(self): + return self._j_table_config.getTimeZone().getID() + + @timezone.setter + def timezone(self, timezone_id): Review comment: Add some Doc, such as: `the timezone_id for a timezone, either an abbreviation such as "PST", a full name such as "America/Los_Angeles", or a custom timezone_id such as "GMT-8:00". ` What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services