wuchong commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r283635271
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/DeclarativeAggregateFunction.java
##########
@@ -62,7 +62,7 @@
/**
* All types of the aggregate buffer.
*/
- public abstract InternalType[] getAggBufferTypes();
+ public abstract LogicalType[] getAggBufferTypes();
Review comment:
Regarding to `DeclarativeAggregateFunction`, I think it is an API expose to
"users" or out of table system. Maybe we should use `DataType` for
`getAggBufferTypes` and `getResultType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
