KurtYoung commented on a change in pull request #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#discussion_r283598342
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecOverAggregate.scala ########## @@ -17,25 +17,35 @@ */ package org.apache.flink.table.plan.nodes.physical.stream -import org.apache.flink.streaming.api.transformations.StreamTransformation -import org.apache.flink.table.CalcitePair -import org.apache.flink.table.api.{StreamTableEnvironment, TableException} -import org.apache.flink.table.calcite.FlinkTypeFactory -import org.apache.flink.table.dataformat.BaseRow -import org.apache.flink.table.plan.nodes.exec.{ExecNode, StreamExecNode} -import org.apache.flink.table.plan.util.RelExplainUtil - import org.apache.calcite.plan.{RelOptCluster, RelOptCost, RelOptPlanner, RelTraitSet} import org.apache.calcite.rel.`type`.RelDataType import org.apache.calcite.rel.core.Window.Group import org.apache.calcite.rel.core.{AggregateCall, Window} import org.apache.calcite.rel.metadata.RelMetadataQuery import org.apache.calcite.rel.{RelNode, RelWriter, SingleRel} import org.apache.calcite.rex.RexLiteral +import org.apache.calcite.rel.RelFieldCollation.Direction.ASCENDING Review comment: Please keep import order align with other files, you can find some explaination here: https://flink.apache.org/contribute-code.html#imports ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services