twalthr commented on a change in pull request #8435:
[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in
blink
URL: https://github.com/apache/flink/pull/8435#discussion_r283645956
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/codegen/LongHashJoinGenerator.scala
##########
@@ -44,11 +44,12 @@ object LongHashJoinGenerator {
joinType == HashJoinType.ANTI ||
joinType == HashJoinType.PROBE_OUTER) &&
filterNulls.forall(b => b) &&
- keyType.getFieldTypes.length == 1 && {
- val t = keyType.getTypeAt(0)
- t == InternalTypes.LONG || t == InternalTypes.INT || t ==
InternalTypes.SHORT ||
- t == InternalTypes.BYTE || t == InternalTypes.FLOAT || t ==
InternalTypes.DOUBLE ||
- t.isInstanceOf[DateType] || t.isInstanceOf[TimestampType] || t ==
InternalTypes.TIME
+ keyType.getFieldCount == 1 && {
+ keyType.getTypeAt(0) match {
+ case _: BigIntType | _: IntType | _: SmallIntType | _: TinyIntType |
Review comment:
Use type families instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
