RE: [Patch, ARM/Thumb1]Add a Thumb1 insn pattern to legalize the instruction that moves pc to low register

2015-01-08 Thread Terry Guo
> -Original Message- > From: Richard Earnshaw > Sent: Monday, December 08, 2014 7:31 PM > To: Terry Guo; gcc-patches@gcc.gnu.org > Cc: Ramana Radhakrishnan > Subject: Re: [Patch, ARM/Thumb1]Add a Thumb1 insn pattern to legalize the > instruction that moves pc to low register > > On 08/12

Re: [PATCHv2] New check and updates in check_GNU_style script

2015-01-08 Thread Jeff Law
On 12/11/14 03:24, Yury Gribov wrote: Hi all, Attached patch adds new check (all blocks of 8 spaces are replaced with tabs) to contrib/check_GNU_style.sh. It also changes the script to allow reading patches from stdin and strengthens the "Dot, space, space, new sentence." check. Is this ok to c

Re: [PATCH][rtlanal.c][BE][1/2] Fix vector load/stores to not use ld1/st1

2015-01-08 Thread Jeff Law
On 12/12/14 04:07, Alan Hayward wrote: [Cleaning this thread up to submit patch again, with better explanation] This patch causes subreg_get_info() to exit early in the simple cases where we are extracting a whole register from a multi register. In aarch64 for Big Endian we were producing a sub

[PATCH] rs6000: Fix recip tests for -m32 -mpowerpc64

2015-01-08 Thread Segher Boessenkool
This fixes gcc.target/powerpc/recip-[67].c with -m32 -mpowerpc64. Tested etc.; okay for mainline? Segher 2015-01-08 Segher Boessenkool gcc/testsuite/ * gcc.target/powerpc/recip-test.h (_ARCH_PPC64): Use __LP64__ instead. --- gcc/testsuite/gcc.target/powerpc/recip-test.h | 2 +- 1

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Bin.Cheng
On Fri, Jan 9, 2015 at 6:03 AM, Jeff Law wrote: > On 01/08/15 08:58, Kito Cheng wrote: >> >> Hi Jeff: >> >> After discussion with Bin, he prefer just use >> gcc.c-torture/execute/scal-to-vec1.c >> instead of introduce new one, do you have any further comment on this >> patch? > > Ah, if there's an

Re: [PATCH] Fix for PR64081 in RTL loop unroller

2015-01-08 Thread Jeff Law
On 12/19/14 03:20, Zamyatin, Igor wrote: Hi! This is an attempt to extend RTL unroller to allow cases like mentioned in the PR - namely when loop has duplicated exit blocks and back edges. Bootstrapped and regtested on x86_64, also checking wide range of benchmarks - spec2K, spec2006, EEMBC I

Re: [PATCH/expand] PR64011 Adjust bitsize when partial overflow happen for big-endian

2015-01-08 Thread Jeff Law
On 12/30/14 03:21, Jiong Wang wrote: PR64011 is actually a general problem on all target support bit insertion instructions. we overflow check at the start of store_bit_field_1, but that only check the situation where the field lies completely outside the register, while there do have situation

Re: [PATCH] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2015-01-08 Thread Andrew Pinski
On Thu, Jan 8, 2015 at 9:35 PM, Jeff Law wrote: > On 01/05/15 14:18, Mike Stump wrote: >> >> On Dec 24, 2014, at 9:28 AM, Dimitris Papavasiliou >> wrote: >>> >>> The attached patch fixes an issue reported a couple of years ago in Bug >>> 51891 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51891).

Re: [PATCH] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2015-01-08 Thread Andrew Pinski
On Wed, Dec 24, 2014 at 9:28 AM, Dimitris Papavasiliou wrote: > Hello, > > The attached patch fixes an issue reported a couple of years ago in Bug > 51891 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51891). The problem is > caused because classes without instance variables have no ivar list at

Re: [PATCH] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2015-01-08 Thread Jeff Law
On 01/05/15 14:18, Mike Stump wrote: On Dec 24, 2014, at 9:28 AM, Dimitris Papavasiliou wrote: The attached patch fixes an issue reported a couple of years ago in Bug 51891 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51891). The problem is caused because classes without instance variables

Re: Patch ping

2015-01-08 Thread Jeff Law
On 01/05/15 14:39, Jakub Jelinek wrote: On Mon, Jan 05, 2015 at 02:27:41PM -0700, Jeff Law wrote: On 01/05/15 06:53, Jakub Jelinek wrote: Hi! I'd like to ping 3 patches: http://gcc.gnu.org/ml/gcc-patches/2014-12/msg01519.html - PR64344 - -fsanitize=float-cast-overflow fix - the C FE part

Re: [PING] Add refers_to_regno_p overload to simplify callers

2015-01-08 Thread Jeff Law
On 01/05/15 15:06, Oleg Endo wrote: Though I think further patches of this nature should probably wait until stage1 reopens. Also for non-functional stuff like changing more return values / args from int to bool where it's obvious? Yea, we're supposed to be locking things down in preparation

Re: [PATCH] IPA ICF: add comparison for target and optimization nodes

2015-01-08 Thread Jeff Law
On 01/07/15 04:38, Martin Liška wrote: Hello. Following patch adds support for target and optimization nodes comparison, which is based on Honza's newly added infrastructure. Apart from that, there's a small hunk that corrects formatting and removes unnecessary call to a comparison function. H

Re: [PATCH] Fix for PR ipa/64503

2015-01-08 Thread Jeff Law
On 01/07/15 03:55, Uros Bizjak wrote: On Tue, Jan 6, 2015 at 7:25 PM, Uros Bizjak wrote: There's suggested patch for PR ipa/64503 that was tested on x86_64 and it works. I would like to ask Uros to test it on an aplha machine before we install the patch. Yes, this works for me on all IPA tes

Re: [doc] fix documentation of -fvtable-verify and related options

2015-01-08 Thread Jeff Law
On 01/08/15 15:08, Sandra Loosemore wrote: This patch cleans up the documentation of -fvtable-verify, -fvtv-debug, and -fvtv-counts. The substantive change is to correct the location of the debug log files per discussion here: https://gcc.gnu.org/ml/gcc/2015-01/msg00029.html but I ended up doi

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2015-01-08 Thread Allan McRae
On 31/12/14 07:23, Magnus Granberg wrote: > fredag 14 november 2014 23.31.48 skrev Magnus Granberg: >> måndag 10 november 2014 21.26.39 skrev Magnus Granberg: Rainer >>> >>> Thanks Rainer for the nits and comments. >>> Have updated the patches and Changelogs. >>> But i still use PIE_DRIVE

Re: [Patch docs 2/5] Update "Instruction Patterns" in md.texi

2015-01-08 Thread Segher Boessenkool
On Thu, Jan 08, 2015 at 03:00:02PM -0700, Jeff Law wrote: > On 01/06/15 04:21, James Greenhalgh wrote: > >-A @code{define_insn} is an RTL expression containing four or five > >operands: > >+A @code{define_insn} contains either four or five components: > How about > A @code{define_insn} contains th

Re: [Patch docs 1/5] Update the first section of md.texi

2015-01-08 Thread Segher Boessenkool
On Thu, Jan 08, 2015 at 02:43:27PM -0700, Jeff Law wrote: > >A section that describes the lexical structure and syntax of .md files? > Seems reasonable. However, is that too heavyweight? > > ISTM we have, effectively 3 items. > > Directives that start with an open-paren and end with their associa

[PATCH] rs6000: Fix TARGET_PROMOTE_FUNCTION_MODE

2015-01-08 Thread Segher Boessenkool
As the existing comment explains, we should always promote function arguments and return values. However, notwithstanding its name, default_promote_function_mode_always_promote does not always promote. Importantly, it does not for libcalls. This makes ftrapv-[12].c fail with 64-bit ABIs. This pa

[PATCH] testsuite/lib/target-supports.exp: Fix check_effective_target_lto

2015-01-08 Thread Ilya Verbin
Hi! Currently check_effective_target_lto properly works only in gcc/testsuite/ dir, since it checks for ENABLE_LTO, which is defined in gcc/configure.ac. But it doesn't work in other subdirectories, e.g. in libgomp/testsuite/. This patch fixes it. make check and check-target-libgomp passed with/wi

Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex

2015-01-08 Thread Jonathan Wakely
On 08/01/15 11:44 -0800, Tim Shen wrote: On Wed, Jan 7, 2015 at 4:39 AM, Jonathan Wakely wrote: No blank line here in the ChangeLog. Done. This is swapping iterators, which can be user-defined types, so it should support finding a swap function by ADL, i.e. Done. Also, there should be a

Re: [Ada] Fix bootstrapping on darwin9/10 (PR ada/64349).

2015-01-08 Thread Iain Sandoe
On 8 Jan 2015, at 13:52, Tristan Gingold wrote: > >> On 08 Jan 2015, at 13:49, Iain Sandoe wrote: >> >> Hi Tristan, >> >> On 7 Jan 2015, at 10:15, Arnaud Charlet wrote: >> >>> Use _NSGetEnviron to get environment. >>> >>> Tested on x86_64-pc-linux-gnu, committed on trunk >>> >>> 2015-01-07

RE: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-08 Thread Bernd Edlinger
On Thu, 8 Jan 2015 14:05:32, Mike Stump wrote: > > On Jan 8, 2015, at 1:27 PM, Jakub Jelinek wrote: >>> Any objections to approving it now? >> >> LGTM. > > Patch is Ok. If you could send the clang folks a heads up, I’ve love to see > them adopt the style. Thanks, I am glad that we finally have

Re: [ping**3] Re: [patch, ARM] Add support for crtfastmath.o

2015-01-08 Thread Sandra Loosemore
On 12/17/2014 03:21 PM, Sandra Loosemore wrote: On 12/07/2014 01:52 PM, Sandra Loosemore wrote: On 11/08/2014 08:57 AM, Sandra Loosemore wrote: 2014-11-08 Sandra Loosemore Chris Jones Joshua Conner gcc/ * config/arm/unknown-elf.h (STARTFILE_SPEC): Add condit

Re: [ping**2] Re: [patch, arm] align saved FP regs on stack

2015-01-08 Thread Sandra Loosemore
On 12/17/2014 03:18 PM, Sandra Loosemore wrote: On 11/14/2014 05:46 PM, Sandra Loosemore wrote: 2014-11-14 Sandra Loosemore Joshua Conner Chris Jones gcc/ * doc/invoke.texi (Option Summary): Add -malign-saved-fp-regs. (ARM options): Document it. * config/

[PATCH, committed] libgccjit.h: Fix description of struct gcc_jit_context

2015-01-08 Thread David Malcolm
libgccjit.h's description of gcc_jit_context talks about contexts having two states: before vs after compilation. This hasn't been the case for a long time, and it's long been possible to compile a context more than once, getting a different gcc_jit_result each time (assuming no errors happen). F

[doc] fix documentation of -fvtable-verify and related options

2015-01-08 Thread Sandra Loosemore
This patch cleans up the documentation of -fvtable-verify, -fvtv-debug, and -fvtv-counts. The substantive change is to correct the location of the debug log files per discussion here: https://gcc.gnu.org/ml/gcc/2015-01/msg00029.html but I ended up doing a pretty much total rewrite of the text

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-08 Thread Mike Stump
On Jan 8, 2015, at 1:27 PM, Jakub Jelinek wrote: >> Any objections to approving it now? > > LGTM. Patch is Ok. If you could send the clang folks a heads up, I’ve love to see them adopt the style.

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2015-01-08 Thread Iain Sandoe
Jack, I haven't had time to look at the outstanding issues, and won't realistically before stage3 ends - so I don't suppose it will be eligible for GCC5 :( Iain On 8 Jan 2015, at 21:56, Jack Howarth wrote: > Iain, > Were you planning to try to get this committed before stage4 or > will it

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Jeff Law
On 01/08/15 08:58, Kito Cheng wrote: Hi Jeff: After discussion with Bin, he prefer just use gcc.c-torture/execute/scal-to-vec1.c instead of introduce new one, do you have any further comment on this patch? Ah, if there's an existing test, then we certainly don't need a new one. Jeff

Re: [Patch docs 2/5] Update "Instruction Patterns" in md.texi

2015-01-08 Thread Jeff Law
On 01/06/15 04:21, James Greenhalgh wrote: Hi, This patch updates the second section of md.texi - "Everything about Patterns". I was aiming to: * Remove outdated details of the compiler. * Remove long or obscure words that, while accurate, only served to obfuscate a simple idea.

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2015-01-08 Thread Jack Howarth
Iain, Were you planning to try to get this committed before stage4 or will it have to wait for the next major gcc release? Jack On Thu, Nov 13, 2014 at 3:34 PM, Iain Sandoe wrote: > Hello Richard, Joseph, > > Thanks for your reviews, > > On 13 Nov 2014, at 07:40, Richard He

[PATCH, committed] jit: New API entrypoint: gcc_jit_context_get_last_error

2015-01-08 Thread David Malcolm
This is of use when writing bindings for higher-level languages that support exception-handling. An example of using this is: https://bitbucket.org/pypy/pypy/commits/6b48e7ef126a50f0bd181f59a827244e0b3e2a00 where I use it in my experimental PyPy backend in order to raise meaningful RPython excep

Re: Patch RFA: Support for building Go tools

2015-01-08 Thread pinskia
> On Jan 8, 2015, at 1:35 PM, Ian Lance Taylor wrote: > > This patch adds support to the GCC tree for building tools that are > used with Go. There are two external used tools (go, gofmt) and one > tool used internally by go (cgo). This patch is pure machinery, with > no source code. The t

Re: [Patch docs 1/5] Update the first section of md.texi

2015-01-08 Thread Jeff Law
On 01/06/15 11:55, Joseph Myers wrote: On Tue, 6 Jan 2015, James Greenhalgh wrote: -The @file{.md} file for a target machine contains a pattern for each -instruction that the target machine supports (or at least each instruction -that is worth telling the compiler about). It may also contain c

Re: [RFA:] Fix test-suite regressions from PR62250 due to -latomic always added

2015-01-08 Thread Mike Stump
On Jan 7, 2015, at 6:32 PM, Hans-Peter Nilsson wrote: > PR62250 (r219171) was about some fortran tests that used atomic > operations but failing on systems where -latomic is required. > The fix was to always add -latomic. That caused test-suite > regressions for targets that don't have libatomic

Patch RFA: Support for building Go tools

2015-01-08 Thread Ian Lance Taylor
This patch adds support to the GCC tree for building tools that are used with Go. There are two external used tools (go, gofmt) and one tool used internally by go (cgo). This patch is pure machinery, with no source code. The tools are not built by default, only when go is enabled using --enable-

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-08 Thread Jakub Jelinek
On Thu, Jan 08, 2015 at 01:07:02PM -0800, Mike Stump wrote: > On Jan 8, 2015, at 11:29 AM, Jakub Jelinek wrote: > > I disagree. Busy waiting of this kind is not appropriate for the test > > suite, > > What busy waiting, there is none in the last version of the patch? It was still while (... !=

Re: [PATCH] Fix up DSE - PR middle-end/64388, target/55023

2015-01-08 Thread Jeff Law
On 01/06/15 07:08, Jakub Jelinek wrote: Hi! On Mon, Jan 05, 2015 at 10:31:17PM +0100, Jakub Jelinek wrote: Or you could e.g. do the if (HARD_FRAME_POINTER_IS_ARG_POINTER && !reload_completed && SIBLING_CALL_P (insn)) { add_wild_read (bb_info); return; } case first, then co

Re: [RFC PATCH] Handle sequence in reg_set_p

2015-01-08 Thread Jeff Law
On 01/08/15 05:23, Oleg Endo wrote: Hi, Currently reg_set_p doesn't handle sequence rtx, which I've identified as the root cause of PR 64479. There is another alternative fix for the PR, but I'd like to get some comments regarding letting reg_set_p also handle sequence rtx: Index: gcc/rtlanal.

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Jeff Law
On 01/08/15 08:58, Kito Cheng wrote: Hi Jeff: After discussion with Bin, he prefer just use gcc.c-torture/execute/scal-to-vec1.c instead of introduce new one, do you have any further comment on this patch? If you can use the existing test, then that's good for me. I believe that was the last q

Re: [PATCH] Small step towards tree-ssa-strlen improvements (PR tree-optimization/63989)

2015-01-08 Thread Jeff Law
On 01/08/15 10:47, Jakub Jelinek wrote: Hi! This patch is a small step towards fixing that PR that I had sitting on my disk for quite a while, but didn't get to further steps so far. I'll try to at least get to the multibyte memcpy/memmove expanded as load followed by store, if the '\0' is known

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-08 Thread Mike Stump
On Jan 8, 2015, at 11:29 AM, Jakub Jelinek wrote: > I disagree. Busy waiting of this kind is not appropriate for the test suite, What busy waiting, there is none in the last version of the patch? > tsan can't intercept the calls that you do through dlsym, because you > explicitly bypass tsan in

Re: RFA: PATCH to factor out no_sanitize_undefined attribute check

2015-01-08 Thread Jakub Jelinek
On Thu, Jan 08, 2015 at 03:57:17PM -0500, Jason Merrill wrote: > I noticed that we were repeating the same long test in lots of places and > factored it out into a separate function. I'm not attached to the name. > > Tested x86_64-pc-linux-gnu, OK for trunk? As the predicate is very simple, woul

RFA: PATCH to factor out no_sanitize_undefined attribute check

2015-01-08 Thread Jason Merrill
I noticed that we were repeating the same long test in lots of places and factored it out into a separate function. I'm not attached to the name. Tested x86_64-pc-linux-gnu, OK for trunk? commit 5a5f850a4d40a25cc3b1fc0120e844b1ac3f3eb0 Author: Jason Merrill Date: Wed Jan 7 17:29:36 2015 -050

Re: [PATCH][ARM] FreeBSD ARM support, EABI, v3

2015-01-08 Thread Andreas Tobler
On 08.01.15 17:27, Richard Earnshaw wrote: On 29/12/14 18:44, Andreas Tobler wrote: All, here is the third attempt to support ARM with FreeBSD. In the meantime we found another issue in the unwinder where I had to adapt some stuff. The unwind_phase2_forced function in libgcc calls a stop_fn f

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-08 Thread Patrick Wollgast
A short recap again: Latest patch, changelog and a test program (further information about the program in the mail): https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html Approved: * gcc/config/i386/* * libgcc/* * libstdc++-v3/* * libvtv/* (Some changes made to three of these fil

libgo patch committed: Use default constant to set gccgo in go tool

2015-01-08 Thread Ian Lance Taylor
This patch to libgo modifies the gccgo version of the go tool to use a builtin constant to set the gccgo compiler to use. This will permit the go tool built as part of a GCC build to use the gccgo compiler built as part of the same build, rather than whatever gccgo happens to be on PATH. This pat

Re: [PATCH][ARM] FreeBSD arm support, EABI, v2

2015-01-08 Thread Andreas Tobler
On 08.01.15 17:22, Richard Earnshaw wrote: On 27/11/14 20:56, Andreas Tobler wrote: Hi all, this is the second attempt. I reworked the issues Richard mentioned in the previous review. I also found one issue which will break build/bootstrap if I pass --enable-gnu-indirect-function, also fixed.

Re: [PATCH, fortran] PR fortran/60255 Deferred character length

2015-01-08 Thread Paul Richard Thomas
Dear Andre, Thanks for the patch. As I have said to you, off list, I think that the _size field in the vtable should contain the kind information and that the _len field should carry the length of the string in bytes. I think that it is better to optimise array access this way than to avoid the di

Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex

2015-01-08 Thread Tim Shen
On Wed, Jan 7, 2015 at 4:39 AM, Jonathan Wakely wrote: > No blank line here in the ChangeLog. Done. > This is swapping iterators, which can be user-defined types, so it > should support finding a swap function by ADL, i.e. Done. > Also, there should be a new test, since apparently we don't hav

[PATCH, committed] New jit API entrypoint: gcc_jit_context_set_logfile

2015-01-08 Thread David Malcolm
When attempting to debug libgccjit embedded inside PyPy I found I needed a detailed log that tracked the various activity within the library. This commit adds a new API entrypoint: gcc_jit_context_set_logfile allowing detailed information to be logged to a FILE *, with logging being mostly a no-

Re: [PATCH] Fix for PR ipa/64503

2015-01-08 Thread Mike Stump
On Jan 8, 2015, at 9:04 AM, Jakub Jelinek wrote: > I don't know how portable scalbnl actually is in reality, so it would be > nice to hear from port maintainers whether say newlib, android, darwin, > cygwin, aix etc. have it. darwin has it.

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-08 Thread Jakub Jelinek
On Thu, Jan 08, 2015 at 11:24:21AM -0800, Mike Stump wrote: > On Jan 7, 2015, at 2:44 PM, Bernd Edlinger wrote: > > Here is a new patch, that uses this method on all tsan tests, > > which seem to depend on sleep(1), and which have unstable results > > because of that. > > > OK for trunk? > > No.

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-08 Thread Mike Stump
On Jan 7, 2015, at 2:44 PM, Bernd Edlinger wrote: > Here is a new patch, that uses this method on all tsan tests, > which seem to depend on sleep(1), and which have unstable results > because of that. > OK for trunk? No. So, I think this is wrong. The problem is that any synchronizing primiti

Re: [PATCH] Fix ix86_expand_int_movcc (PR target/64338)

2015-01-08 Thread Jakub Jelinek
On Thu, Jan 08, 2015 at 07:37:44PM +0100, Uros Bizjak wrote: > Please put std::swap at the top, above code= assignment. Cosmetic, but > I noticed this during std::swap conversion. ;) Ok. Put there also the diff = -diff; assignment and cf = ct; ct = 0; swap to keep the order that used to be there

Re: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C

2015-01-08 Thread Mike Stump
On Jan 7, 2015, at 12:23 AM, Jakub Jelinek wrote: > > I'm fine with adding the no_sanitize_thread attribute, the patch LGTM Thanks, I checked it in, the doc seemed trivial enough. * tsan.c (pass_tsan::gate): Add no_sanitize_thread support. (pass_tsan_O0::gate): Likewise.

Re: [PATCH] Fix for PR ipa/64503

2015-01-08 Thread Jakub Jelinek
On Thu, Jan 08, 2015 at 07:42:32PM +0100, Uros Bizjak wrote: > > I don't know how portable scalbnl actually is in reality, so it would be > > nice to hear from port maintainers whether say newlib, android, darwin, > > cygwin, aix etc. have it. > > Newlib has it. > > Other than that: > >e

Re: [PATCH] Fix for PR ipa/64503

2015-01-08 Thread Uros Bizjak
On Thu, Jan 8, 2015 at 6:04 PM, Jakub Jelinek wrote: > On Wed, Jan 07, 2015 at 01:43:59PM +0100, Uros Bizjak wrote: >> Hello! >> >> There's suggested patch for PR ipa/64503 that was tested on x86_64 and >> it works. >> I would like to ask Uros to test it on an aplha machine before

Re: [PATCH] Fix ix86_expand_int_movcc (PR target/64338)

2015-01-08 Thread Uros Bizjak
On Thu, Jan 8, 2015 at 6:09 PM, Jakub Jelinek wrote: > Hi! > > The recent ifcvt changes result in movcc being attempted with > comparisons like (ltgt (reg:CCFPU flags) (const_int 0)). > I see several issues with the current ix86_expand_int_movcc code: > 1) the code was unprepared to handle *revers

Re: [Patch, Fortran] Fix previous patch

2015-01-08 Thread Tobias Burnus
Paul Richard Thomas wrote: It looks to me as if you had to do a fair amount of detective work there! The patch is OK for trunk. Thanks for the review - which didn't make it to mailing list for some reasons (text+HTML email?). Committed as Rev. 219354 Tobias Thanks for your efforts Paul

[PATCH] Small step towards tree-ssa-strlen improvements (PR tree-optimization/63989)

2015-01-08 Thread Jakub Jelinek
Hi! This patch is a small step towards fixing that PR that I had sitting on my disk for quite a while, but didn't get to further steps so far. I'll try to at least get to the multibyte memcpy/memmove expanded as load followed by store, if the '\0' is known not to appear at all, or known to appear

[PATCH] Fix ix86_expand_int_movcc (PR target/64338)

2015-01-08 Thread Jakub Jelinek
Hi! The recent ifcvt changes result in movcc being attempted with comparisons like (ltgt (reg:CCFPU flags) (const_int 0)). I see several issues with the current ix86_expand_int_movcc code: 1) the code was unprepared to handle *reverse_condition* failures (returns of UNKNOWN) 2) for CCFP/CCFPU mode

Re: [PATCH] Fix for PR ipa/64503

2015-01-08 Thread Jakub Jelinek
On Wed, Jan 07, 2015 at 01:43:59PM +0100, Uros Bizjak wrote: > Hello! > > There's suggested patch for PR ipa/64503 that was tested on x86_64 and > it works. > I would like to ask Uros to test it on an aplha machine before we > install the patch. > >>> > >>> Yes, this works fo

Re: [patch] libstdc++/60132 deprecate C++0x has_trivial_xxx traits

2015-01-08 Thread Jonathan Wakely
On 08/01/15 16:24 +, Jonathan Wakely wrote: Now that we provide the std::is_trivially_xxxible traits we don't need to keep the has_trivial_xxx ones from the earlier C++0x drafts. This patch marks them as deprecated so we can remove them in future. I'll update the changes.html notes too. He

Re: OMP builtins in offloading (was: [PATCH 1/4] Add mkoffload for Intel MIC)

2015-01-08 Thread Jakub Jelinek
On Thu, Jan 08, 2015 at 07:32:13PM +0300, Ilya Verbin wrote: > On 08 Jan 16:49, Jakub Jelinek wrote: > > BTW, today when looking at the TARGET_OPTION_NODE streaming caused > > regressions, I've discovered that it is very hard to debug issues in the > > offloading compiler. Would be nice if > > -sa

Re: OMP builtins in offloading (was: [PATCH 1/4] Add mkoffload for Intel MIC)

2015-01-08 Thread Ilya Verbin
On 08 Jan 16:49, Jakub Jelinek wrote: > BTW, today when looking at the TARGET_OPTION_NODE streaming caused > regressions, I've discovered that it is very hard to debug issues in the > offloading compiler. Would be nice if > -save-temps -v > printed enough information that it is actually possible t

Re: [PATCH][ARM] FreeBSD ARM support, EABI, v3

2015-01-08 Thread Richard Earnshaw
On 29/12/14 18:44, Andreas Tobler wrote: > All, > > here is the third attempt to support ARM with FreeBSD. > > In the meantime we found another issue in the unwinder where I had to > adapt some stuff. > > The unwind_phase2_forced function in libgcc calls a stop_fn function. > This stop_fn is i

[patch] libstdc++/60132 deprecate C++0x has_trivial_xxx traits

2015-01-08 Thread Jonathan Wakely
Now that we provide the std::is_trivially_xxxible traits we don't need to keep the has_trivial_xxx ones from the earlier C++0x drafts. This patch marks them as deprecated so we can remove them in future. I'll update the changes.html notes too. Tested x86_64-linux, committed to trunk. commit 2ca

Re: [gofrontend-dev] [PATCH 1/2, libgo] Add reflection support to gccgo for ppc64, ppc64le in gcc 4.9

2015-01-08 Thread Lynn A. Boger
The only bugs I am aware of when using reflection on ppc64 & ppc64le in gcc 4.9 are in the gccgo testcase recover.go and what is needed to build Docker. When I run the gccgo testsuite and see a failing testcase with a panic message saying that a function is not implemented it makes me think so

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-01-08 Thread Thomas Schwinge
Hi! On Thu, 8 Jan 2015 07:02:19 -0800, "H.J. Lu" wrote: > On Thu, Jan 8, 2015 at 6:59 AM, Thomas Schwinge > wrote: > > commit c049b358f961f72d0c0cf61a707e9a5855b12b28 > > Author: tschwinge > > Date: Thu Jan 8 14:58:45 2015 + > > > > intelmic-mkoffload: Deal with linker defaulting to

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-08 Thread Thomas Schwinge
Hi! On Fri, 26 Dec 2014 22:15:24 +0300, Ilya Verbin wrote: > On 22 Dec 12:48, Thomas Schwinge wrote: > > Here is a patch to correctly match intelmic in $offload_targets; OK to > > commit, I assume? I suppose I'm the first one to ever do build-tree > > testing? (Jakub?) > OK, thanks. > I verifi

Re: [PATCH] LRA: Fix caller-save store/restore instruction for large mode

2015-01-08 Thread Kito Cheng
Hi Jeff: After discussion with Bin, he prefer just use gcc.c-torture/execute/scal-to-vec1.c instead of introduce new one, do you have any further comment on this patch? On Thu, Jan 8, 2015 at 9:29 AM, Bin.Cheng wrote: > On Wed, Jan 7, 2015 at 8:28 PM, Kito Cheng wrote: >> Hi Bin: >> >> It's 2 m

Re: OMP builtins in offloading (was: [PATCH 1/4] Add mkoffload for Intel MIC)

2015-01-08 Thread Jakub Jelinek
Hi! On Thu, Jan 08, 2015 at 04:41:50PM +0100, Thomas Schwinge wrote: > On Fri, 26 Dec 2014 16:22:43 +0300, Ilya Verbin wrote: BTW, today when looking at the TARGET_OPTION_NODE streaming caused regressions, I've discovered that it is very hard to debug issues in the offloading compiler. Would be

Re: OMP builtins in offloading (was: [PATCH 1/4] Add mkoffload for Intel MIC)

2015-01-08 Thread Thomas Schwinge
Hi! On Fri, 26 Dec 2014 16:22:43 +0300, Ilya Verbin wrote: > On 22 Dec 12:26, Jakub Jelinek wrote: > > On Mon, Dec 22, 2014 at 12:20:58PM +0100, Thomas Schwinge wrote: > > > What is the reason that you're adding -fopenmp here? I assume it is that > > > otherwise you'd get tree streaming errors b

Re: [PATCH][ARM][4.9]Backport "Fix definition of __ARM_SIZEOF_WCHAR_T"

2015-01-08 Thread Richard Earnshaw
On 07/01/15 13:53, Renlin Li wrote: > Hi all, > > This is a backport patch for > https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=213864 > > arm-none-eabi regression test has been done, no new issues. > Okay for branch 4.9? > > gcc/ChangeLog > > Fix PR target/61413 > Backport from mainli

Re: [debug-early] reuse variable DIEs and fix their context

2015-01-08 Thread Aldy Hernandez
Jason suggested keeping it in the branch since it doesn't fix any regressions, so it's living there for now. AldyOn Jan 8, 2015 4:24 AM, Richard Biener wrote: > > On Sat, Dec 20, 2014 at 5:49 AM, Aldy Hernandez wrote: > > On 12/19/14 11:03, Jason Merrill wrote: > > > > First of all, my bad R

[Patch, Fortran] PR64522 - reinstate truncation diagnostic

2015-01-08 Thread Tobias Burnus
For fixed-form source code, it is not unusual that after the 72 columns, comments are added - like sequence numbers with punch cards or later code comments. For free-form source code, that's very uncommon - especially as several compilers do not honour the line limit of 132 characters (with defaul

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-01-08 Thread H.J. Lu
On Thu, Jan 8, 2015 at 6:59 AM, Thomas Schwinge wrote: > Hi! > > On Mon, 22 Dec 2014 12:28:20 +0100, Jakub Jelinek wrote: >> On Mon, Dec 22, 2014 at 12:25:32PM +0100, Thomas Schwinge wrote: >> > On Wed, 22 Oct 2014 22:57:01 +0400, Ilya Verbin wrote: >> > > --- /dev/null >> > > +++ b/gcc/config/i

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-01-08 Thread Thomas Schwinge
Hi! On Mon, 22 Dec 2014 12:28:20 +0100, Jakub Jelinek wrote: > On Mon, Dec 22, 2014 at 12:25:32PM +0100, Thomas Schwinge wrote: > > On Wed, 22 Oct 2014 22:57:01 +0400, Ilya Verbin wrote: > > > --- /dev/null > > > +++ b/gcc/config/i386/intelmic-mkoffload.c > > > @@ -0,0 +1,541 @@ > > > +/* Offloa

Re: [gofrontend-dev] [PATCH 1/2, libgo] Add reflection support to gccgo for ppc64, ppc64le in gcc 4.9

2015-01-08 Thread Ian Lance Taylor
On Thu, Jan 8, 2015 at 5:44 AM, Lynn A. Boger wrote: > > Also as was noted below, some level of reflection support is needed to build > Docker. Sorry to be so pedantic, but I'm just trying to clarify that you keep saying "reflection support," but reflection support is there. What is missing is a

Re: [PATCH 3/4] Add libgomp plugin for Intel MIC

2015-01-08 Thread Thomas Schwinge
Hi! On Fri, 12 Dec 2014 10:42:30 +0100, I wrote: > On Mon, 10 Nov 2014 17:30:38 +0300, Ilya Verbin wrote: > > --- /dev/null > > +++ b/liboffloadmic/plugin/Makefile.am > > @@ -0,0 +1,123 @@ > > +# Plugin for offload execution on Intel MIC devices. > > + AM_LDFLAGS = -L$(liboffload_dir)/.libs -L$

Re: LTO streaming of TARGET_OPTIMIZE_NODE

2015-01-08 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 01:27:08PM +0100, Bernd Schmidt wrote: > On 11/13/2014 05:06 AM, Jan Hubicka wrote: > >this patch adds infrastructure for proper streaming and merging of > >TREE_TARGET_OPTION. > > This breaks the offloading path via LTO since it introduces an > incompatibility in LTO forma

Re: [Ada] Fix bootstrapping on darwin9/10 (PR ada/64349).

2015-01-08 Thread Tristan Gingold
> On 08 Jan 2015, at 13:49, Iain Sandoe wrote: > > Hi Tristan, > > On 7 Jan 2015, at 10:15, Arnaud Charlet wrote: > >> Use _NSGetEnviron to get environment. >> >> Tested on x86_64-pc-linux-gnu, committed on trunk >> >> 2015-01-07 Tristan Gingold >> >> PR ada/64349 >> * env.c (_

Re: [gofrontend-dev] [PATCH 1/2, libgo] Add reflection support to gccgo for ppc64, ppc64le in gcc 4.9

2015-01-08 Thread Lynn A. Boger
If this change is not included, in the gcc go testsuite, the recover.go testcase fails with this error: panic: reflect.makeMethodValue not implemented for ppc64le when running this test: func test9reflect1() { f := reflect.ValueOf(&T1{}).Method(0).Interface().(func()) defer f()

Re: [RFA:] Fix test-suite regressions from PR62250 due to -latomic always added

2015-01-08 Thread John David Anglin
On 2015-01-07, at 9:32 PM, Hans-Peter Nilsson wrote: > gcc/testsuite: > PR testsuite/62250 > * lib/target-supports.exp (check_effective_target_libatomic_available): > New. > * gfortran.dg/coarray/caf.exp: Only add -latomic for > targets that match effective-target lib

[patch] Use std::__bool_constant instead of duplicating it

2015-01-08 Thread Jonathan Wakely
This is a tiny patch to use the new __bool_constant helper in hashtable_policy.h instead of defining another identical alias. Tested x86_64-linux, committed to trunk. commit 3fa3e0af59fa4371f61e95eeaab240d3b974b62e Author: Jonathan Wakely Date: Wed Apr 16 18:20:30 2014 +0100 * include/b

Re: [C++ Patch] PR 60753

2015-01-08 Thread Jason Merrill
OK. Jason

Re: [Ada] Fix bootstrapping on darwin9/10 (PR ada/64349).

2015-01-08 Thread Iain Sandoe
Hi Tristan, On 7 Jan 2015, at 10:15, Arnaud Charlet wrote: > Use _NSGetEnviron to get environment. > > Tested on x86_64-pc-linux-gnu, committed on trunk > > 2015-01-07 Tristan Gingold > > PR ada/64349 > * env.c (__gnat_environ): Adjust for darwin9/darwin10. > > So my original

Re: #pragma GCC unroll support

2015-01-08 Thread Richard Biener
On Mon, Dec 22, 2014 at 10:13 PM, Mike Stump wrote: > So, I have a rough cut of a new feature to add pragma GCC unroll support to > gcc. It is safe wrt the test suite and code-gen, but there are some corners > that I need help or suggestions on how to round off nicely. > > Things to think about

Re: [match-and-simplify] Remove printing "for expression"

2015-01-08 Thread Richard Biener
On Sun, 21 Dec 2014, Prathamesh Kulkarni wrote: > Hi, > I removed printing "for expression:" from print_matches. I think it > is out of place tvim here and we call print_matches after lowering. > OK to commit ? Hum, it's now a very simple wrapper around print_operand - why not replace the two cal

Re: [PATCH v3] Use strtoll instead of atoll in gcov-tool.c

2015-01-08 Thread Richard Biener
On Sat, Dec 20, 2014 at 11:51 PM, John David Anglin wrote: > Ping. Ok. Thanks, Richard. > > On 24-Nov-14, at 7:38 PM, John David Anglin wrote: > >> On 15-Sep-14, at 5:40 AM, Richard Biener wrote: >> >>> Let's wait for other opinions. >> >> >> We now have implementations of strtol and strtoll in

Re: [debug-early] reuse variable DIEs and fix their context

2015-01-08 Thread Richard Biener
On Sat, Dec 20, 2014 at 5:49 AM, Aldy Hernandez wrote: > On 12/19/14 11:03, Jason Merrill wrote: > > First of all, my bad Richard. I vaguely remember you mentioning something > about Java, but it was early enough in the project that I had no idea what > you were talking about. Thanks for your pa

[RFC PATCH] Handle sequence in reg_set_p

2015-01-08 Thread Oleg Endo
Hi, Currently reg_set_p doesn't handle sequence rtx, which I've identified as the root cause of PR 64479. There is another alternative fix for the PR, but I'd like to get some comments regarding letting reg_set_p also handle sequence rtx: Index: gcc/rtlanal.c

[SH][committed] Don't emit tstsi_t insn with const_int as first operand

2015-01-08 Thread Oleg Endo
Hi, While doing some other work on the tst insns, I ran into the issue that in sh-mem.cc the tstsi_t insn is emitted with the const_int operand being the first operand. Normally reload fixes this afterwards, but let's not stress that. Tested with make -k check RUNTESTFLAGS="--target_board=sh-sim

Re: [RFC PATCH 8/9] [SH] Add splitter to addsi3_compact

2015-01-08 Thread Oleg Endo
On Thu, 2014-12-18 at 10:04 +0900, Kaz Kojima wrote: > This patch is discussed in PR55212 > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55212#c65 > > and is to make LRA's register elimination work well on SH. > The problem is SH has very limited add instructions only and expands > rA := rB + N

[hsa] Fix wrong conversion ode and verification fallout

2015-01-08 Thread Martin Jambor
Hi, the following patch fixes three different minor problems. It makes us produce the rounding flag required by HSAIL specification when converting an integer to a floating point type, not ICE on an invariant in a return gimple statement and relax verification so that it is OK with HSA SSA names

Re: RFC: C++ PATCH to do bounds sanitation for VLA initialization

2015-01-08 Thread Marek Polacek
On Wed, Jan 07, 2015 at 11:56:58PM -0500, Jason Merrill wrote: > My recent patch to remove the C++ VLA semantics that didn't make it into > C++14 missed a couple of spots. While I was looking at that I noticed that > we weren't sanitizing VLA initialization, which we ought to do; this patch > impl

Re: [4.8] Request to backport patch to the 4.8 branch

2015-01-08 Thread Richard Biener
On Wed, 24 Dec 2014, Bin.Cheng wrote: > On Wed, Dec 24, 2014 at 4:35 PM, zhangjian > wrote: > > Hi, guys > > > > I encounter a gcc failure when I build mysql on opensuse[1] > > 5.6.17/storage/perfschema/pfs_account.cc:320:1: error: could not split insn > > [ 1245s] } > > [ 1245s] ^ > > [ 1245s

[patch committed SH] Fix PR target/64533

2015-01-08 Thread Kaz Kojima
I've committed the attached patch to fix PR target/64533 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64533 which is a 5.0 regression. Splitting rA := rB + N to rA := N and rA := rA + rB isn't safe when rA is the stack pointer. If someone interrupts between these 2 set insns, we could see a bad va

  1   2   >