Hi! On Fri, 12 Dec 2014 10:42:30 +0100, I wrote: > On Mon, 10 Nov 2014 17:30:38 +0300, Ilya Verbin <iver...@gmail.com> wrote: > > --- /dev/null > > +++ b/liboffloadmic/plugin/Makefile.am > > @@ -0,0 +1,123 @@ > > +# Plugin for offload execution on Intel MIC devices.
> > + AM_LDFLAGS = -L$(liboffload_dir)/.libs -L$(libgomp_dir)/.libs
> > -loffloadmic_target -lcoi_device -lmyo-service -lgomp -rdynamic
>
> Given that this plugin wishes to link against libgomp, don't we have to
> make sure that libgomp has actually been built before that is attempted,
> and the following (untested) patch would be required?
As shown by a »make -j1« build: yes, we have to. As obvious, committed
to trunk in r219344:
commit fb5eef67f6b041cd0bc4f1f8d62c1a000d59f497
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Thu Jan 8 14:46:22 2015 +0000
liboffloadmic/plugin: Depend on libgomp being built.
[...]
Making all in plugin
make[6]: Entering directory
`[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/liboffloadmic/plugin'
[...]
[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/./gcc/xg++
-B[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/./gcc/ -nostdinc++
-nostdinc++
-I[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/include/x86_64-intelmicemul-linux-gnu
-I[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/include
-I[...]/source-gcc/libstdc++-v3/libsupc++
-I[...]/source-gcc/libstdc++-v3/include/backward
-I[...]/source-gcc/libstdc++-v3/testsuite/util
-L[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/src
-L[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/src/.libs
-L[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/libsupc++/.libs
-B/x86_64-intelmicemul-linux-gnu/bin/ -B/x86_64-intelmicemul-linux-gnu/lib/
-isystem /x86_64-intelmicemul-linux-gnu/include -isystem
/x86_64-intelmicemul-linux-gnu/sys-include -m32 -L./../.libs
-L./../../libgomp/.libs -loffloadmic_target -lcoi_device -lmyo-service -lgomp
-rdynamic ../ofldbegin.o offload_target_main.o ../ofldend.o -o
offload_target_main
/usr/bin/ld: cannot find -lgomp
collect2: error: ld returned 1 exit status
* Makefile.def (dependencies) <all-target-liboffloadmic>: Depend on
all-target-libgomp.
* Makefile.in: Regenerate.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@219344
138bc75d-0d04-0410-961f-82ee72b054a4
---
ChangeLog | 6 ++++++
Makefile.def | 2 +-
Makefile.in | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git ChangeLog ChangeLog
index 325f4cc..9012087 100644
--- ChangeLog
+++ ChangeLog
@@ -1,3 +1,9 @@
+2015-01-08 Thomas Schwinge <tho...@codesourcery.com>
+
+ * Makefile.def (dependencies) <all-target-liboffloadmic>: Depend on
+ all-target-libgomp.
+ * Makefile.in: Regenerate.
+
2015-01-06 Eric Botcazou <ebotca...@adacore.com>
* MAINTAINERS (CPU Port Maintainers): Add myself for Visium port.
diff --git Makefile.def Makefile.def
index ffab409..15ab613 100644
--- Makefile.def
+++ Makefile.def
@@ -551,7 +551,7 @@ dependencies = { module=configure-target-libvtv;
on=all-target-libstdc++-v3; };
// generated by the libgomp configure. Unfortunately, due to the use of
// recursive make, we can't be that specific.
dependencies = { module=all-target-libstdc++-v3; on=configure-target-libgomp;
};
-dependencies = { module=all-target-liboffloadmic; on=configure-target-libgomp;
};
+dependencies = { module=all-target-liboffloadmic; on=all-target-libgomp; };
dependencies = { module=install-target-libgo; on=install-target-libatomic; };
dependencies = { module=install-target-libgfortran;
on=install-target-libquadmath; };
diff --git Makefile.in Makefile.in
index 7355bf1..428898a 100644
--- Makefile.in
+++ Makefile.in
@@ -48893,7 +48893,7 @@ all-stage3-target-libstdc++-v3:
maybe-configure-stage3-target-libgomp
all-stage4-target-libstdc++-v3: maybe-configure-stage4-target-libgomp
all-stageprofile-target-libstdc++-v3:
maybe-configure-stageprofile-target-libgomp
all-stagefeedback-target-libstdc++-v3:
maybe-configure-stagefeedback-target-libgomp
-all-target-liboffloadmic: maybe-configure-target-libgomp
+all-target-liboffloadmic: maybe-all-target-libgomp
install-target-libgo: maybe-install-target-libatomic
install-target-libgfortran: maybe-install-target-libquadmath
install-target-libgfortran: maybe-install-target-libgcc
Grüße,
Thomas
signature.asc
Description: PGP signature
