On 01/05/15 14:39, Jakub Jelinek wrote:
On Mon, Jan 05, 2015 at 02:27:41PM -0700, Jeff Law wrote:
On 01/05/15 06:53, Jakub Jelinek wrote:
Hi!
I'd like to ping 3 patches:
http://gcc.gnu.org/ml/gcc-patches/2014-12/msg01519.html
- PR64344 - -fsanitize=float-cast-overflow fix - the C FE part
is approved, but not the sanitizer bits outside of the FE
OK.
http://gcc.gnu.org/ml/gcc-patches/2014-12/msg01271.html
- PR64265 - tsan support for exceptions
OK.
http://gcc.gnu.org/ml/gcc-patches/2014-12/msg00297.html
- -fsanitize=vptr support
How is this different from vtable pointer verification that we already
support? Is there some reason we can't just use that instead?
I don't now the current vtable pointer verification too much, but my
understanding of it is that it is hardly usable, because e.g. it requires
libstdc++ to be rebuilt with the verification enabled, otherwise you can't
verify stuff, and that means a performance penalty even for code you don't
want to verify. Unlike that, -fsanitize=vptr is lightweight, and you only
rebuild with it what you want and can have other code kept as is, not
recompiled.
OK. I'd forgotten about the "recompile libstdc++" aspect. Sigh.
The language independent stuff looks reasonable to me -- you know this
code better than I, so it was just a cursory look. Jason should ack the
C++ bits.
jeff
