I see this in your trace:
> /builddir/build/BUILD/trafficserver-10.0.2-build/trafficserver-10.0.2/lib/swoc/include/swoc/Errata.h:1002
Looking at:
https://github.com/apache/trafficserver-libswoc/blob/SolidWallOfCode-patch-1/code/include/swoc/Errata.h
The file is under 1000 lines. Perhaps you ar
In 2021, Yahoo tried to open source this plugin. But the effort fizzled:
https://github.com/apache/trafficserver/pull/7598 .
The plugin now has preliminary support for client screening using an HTTP
header that an Amazon Application Load Balancer can be configured to add to
incoming requests.
Hmm ts_util is a utility currently only used by txn_box. It uses libswoc,
as do other parts of our code.
We have already decided to bring ts_util into our repo. We already have to
maintain it. It's a question of whether we want to get more use out of
it. If we don't think it's of significant v
wrapper as an independent
> library.
>
> On Wed, Apr 17, 2024 at 7:15 PM Walt Karas
> wrote:
>
> > The atscppapi was deprecated because it was buggy and had bad
> performance.
> >
> > On Wed, Apr 17, 2024 at 4:36 PM Masakazu Kitajo
> wrote:
> >
> >
many questions to throw +1 for this. Since the wrapper is just a
> wrapper, we can see if it's good without having it as TS API. Do we have a
> reason to skip doing that?
>
> On Wed, Apr 17, 2024 at 1:06 PM Walt Karas
> wrote:
>
> > The atscppapi had problems, but I don&#
e of libswoc, etc.). One might
> make a better wrapper. I don't see a reason to have such things as TS API
> and maintain it by ourselves. IMO, TS API should provide minimal things
> which can be only done by API.
>
>
> On Wed, Apr 10, 2024 at 2:50 PM Walt Karas
> wrote:
&g
C
> APIs in C++?
>
> — Leif
>
> On Mon, Apr 8, 2024 at 13:28 Walt Karas
> wrote:
>
> > That is move
> plugins/experimental/txn_box/plugin/include/txn_box/ts_util.h
> > to include/ts, and plugins/experimental/txn_box/plugin/src/ts_util.cc to
> > src/api .
> >
&
That is move plugins/experimental/txn_box/plugin/include/txn_box/ts_util.h
to include/ts, and plugins/experimental/txn_box/plugin/src/ts_util.cc to
src/api .
May involve some picking and choosing. ts_util.h includes common.h. I
don't think we want to bring all of common.h into the TS API.
Why not more const safe?
const char *TSHttpTxnErrorBodyGet(TSHttpTxn txnp, size_t *buflength, const
char **mimetype);
On Thu, Mar 14, 2024 at 5:09 PM Leif Hedstrom wrote:
> We have an existing API to set the error body (TSHttpTxnErrorBodyGet() ),
> and I’d like to add the corresponding Get’er f
Has anyone written an Au test where the actual body size does not match the
size given in the Content-Length header field? If not, that would be a
good addition.
On Wed, Jan 3, 2024 at 11:25 AM Walt Karas wrote:
> Have you considered removing cached objects with PURGE requests (sent w
Have you considered removing cached objects with PURGE requests (sent with
curl)?
https://docs.trafficserver.apache.org/admin-guide/storage/index.en.html#removing-an-object-from-the-cache
On Wed, Jan 3, 2024 at 9:13 AM amirhossein ramezan
wrote:
> Dear Sir/madam
> I just had two questions for yo
Is the current naming based on some SNMP MIB spec?
Personally, my indifference is boundless. This change will I think lead to
some logistic aggravation, due to scripts that take metrics output as input.
Any chance it's worth it to make the prefix configurable?
On Mon, Dec 18, 2023 at 9:41 PM Ja
Have you read this part of the documentation yet?
https://docs.trafficserver.apache.org/developer-guide/debugging/index.en.html
Other sections of the documentation cover building ATS from source and
installing it. Autotools are used for the current version, ATS 9, and
cmake is used for the versio
anism) to do the cleanup on TXN_CLOSE.\
>
I don't see how your answers are related to my questions so I'll let others
consider this.
> -Original Message-
> From: Walt Karas
> Sent: Thursday, December 7, 2023 9:27 AM
> To: dev@trafficserver.apache.org
> Subject: Re: [E] [TSAPI] TSTxnAlloc
>
>
>
ot ATS resources.
>
> -Original Message-
> From: Walt Karas
> Sent: Wednesday, December 6, 2023 9:25 PM
> To: dev@trafficserver.apache.org
> Subject: Re: [E] [TSAPI] TSTxnAlloc
>
> Could we move Arena.h to tscpp/util, and just add:
>
> Arena & tsapi::txnArena(T
Could we move Arena.h to tscpp/util, and just add:
Arena & tsapi::txnArena(TSHttpTxn txn);
For your finalizer example, when would that be better than using
Cleanup.h? That is, when would it be better than having the vector be a
data member of the TxnAuxData class you provide as a parameter to th
...@yahooinc.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
;CN=Walt Karas;X-NUM-GUESTS=0:mailto:wka...@yahooinc.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
;CN=Brian Neradt;X-NUM-GUESTS=0:mailto:brian.ner...@yahooinc.com
ATTENDEE
-GUESTS=0:mailto:damian.me...@yahooinc.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
E;CN=Walt Karas;X-NUM-GUESTS=0:mailto:wka...@yahooinc.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
;CN=Brian Neradt;X-NUM-GUESTS=0:mailto:brian.ner
er.apache.org
> Subject: Re: What should we do with noncopyable.h?
>
> I'd say get rid of it (when we delete the C++ API). I don't like having
> that kind of general utility in our tree.
>
> Masakazu
>
> On Fri, Oct 27, 2023 at 7:20 AM Walt Karas
> wrote:
>
https://github.com/apache/trafficserver/blob/master/include/tscpp/api/noncopyable.h
Given that the C++ API is deprecated in 10 and will be deleted in 11.
Should we get rid of noncopyable (since it's less useful in C++11 and
later)? Or, move it to tscpp/util ?
I checked Jason's Yahoo internal release build of ATS, and it does put the
path to the Magick libs in the plugin rpaths. So, apparently that's my
bad, I'm missing some configure option or double secret environment
variable.
On Fri, Oct 20, 2023 at 10:22 AM Walt Karas wrote:
>
Using ldd, I get this list of libraries that my installed developer build
of ATS depends on. That is, the libraries used by the installed
executables and libraries, including all core plugins, experimental or not.
libbrotlicommon.so.1 => /opt/edge/brotli/1.0/lib/libbrotlicommon.so.1
libbrotlienc.
I think each company should successfully build their internal version with
cmake before autotools goes away. I don't think Yahoo has done this yet.
On Thu, Oct 19, 2023 at 11:55 AM Brian Neradt
wrote:
> +1
>
> Maintaining both build tools would be very burdensome.
>
> On Thu, Oct 19, 2023 at 10
I'd strongly recommend putting the relevant autotools config.nice (or a
hopefully-exisitng cmake equivalent) in the issue. Has information like
whether you used gcc or clang.
On Fri, Sep 15, 2023 at 10:56 AM Walt Karas wrote:
> When you write an issue for a memory leak, please make
When you write an issue for a memory leak, please make it clear whether you
found it building (assuming autotools) with the configure option
--enable-asan, or --enable-lsan . This may be important in reproducing the
issue.
On the master branch, cstdint is already included:
https://github.com/apache/trafficserver/blob/master/lib/swoc/include/swoc/TextView.h
On Mon, Sep 11, 2023 at 10:30 AM jean-frederic clere
wrote:
> On 9/11/23 15:59, jean-frederic clere wrote:
> > On 9/11/23 15:40, jean-frederic clere wrote:
> >>
iod != Cript::string::npos) {
plugin_debug_tag = plugin_debug_tag.substr(slash + 1, period - slash - 1);
}
dbg_ctl_cript = TSDbgCtlCreate(plugin_debug_tag.c_str());
On Thu, Sep 7, 2023 at 10:21 PM James Peach wrote:
>
> > On 6 Sep 2023, at 10:30 am, Walt Karas
> wrote:
> &g
+1 as long as I don't have to do it.
On Wed, Sep 6, 2023 at 10:39 PM Brian Neradt wrote:
> +1
>
> We already have a TSVConnFdCreate, so it seems appropriate to add a getter.
>
> On Wed, Sep 6, 2023 at 5:26 PM SUSAN HINRICHS
> wrote:
>
> > I would like to add a convenience API to fetch the file
See https://github.com/apache/trafficserver/pull/10375 .
ail secure email.
>
> --- Original Message ---
> On Tuesday, September 5th, 2023 at 11:37 AM, Walt Karas
> wrote:
>
>
> > Would it be possible to propose concrete alternatives? We can't just
> > simply delete Cleanup.h, the xdebug plugin won't c
on Mail secure email.
>
> --- Original Message ---
> On Tuesday, September 5th, 2023 at 10:53 AM, Masakazu Kitajo <
> m4s...@gmail.com> wrote:
>
>
> > I was not talking about the need to use RAII. I just don't think we
> should
> > promote Cleanup.h.
It seems that some are not convinced of the need to use RAII. I won' t get
into that, it's easy to find writeups advocating for it, which are better
than anything I could write.
I have no strong feelings about how things are spelled or abbreviated.
On Sat, Sep 2, 2023 at 11:22 PM James Peach wr
behavior change. Then ours would be
> useless. It's not only about "helmet". Any utilities would have this issue.
> This is why I'm skeptical to have utilities as TS API and asking all if we
> want to do this.
>
> On Thu, Aug 31, 2023 at 1:35 PM Walt Karas
> wro
ary after we make it better.
>
> Not discarding Cleanup.h and promoting it to TS API are different things.
> TS API is not something we can casually change or remove. I'd rather not
> add a short lifetime temporary solution to TS API.
>
>
>
> On Wed, Aug 30, 2023 at 12:19
API?
>
> -- Masakazu
>
> On Tue, Aug 22, 2023 at 11:48 AM Walt Karas
> wrote:
>
> > See the PR
> https://urldefense.com/v3/__https://github.com/apache/trafficserver/pull/10231__;!!Op6eflyXZCqGR5I!HHlP-H_IgX9Ah46LlOiHqX--VcnzF3Dp5uG2JI_JXBmG8c_jMQNpsYQPvyDaaAsympzb7neltiG
See the PR https://github.com/apache/trafficserver/pull/10231 . Cleanup.h
is currently available to plugins in include/tscpp/api . The proposal is
to move it to include/ts . The declarations currently in the
atscppapi namespace are moved to the tsapi::c_support namespace. The
c_support sub-name
/apache/trafficserver/pull/10231
On Wed, Aug 16, 2023 at 6:18 PM Walt Karas wrote:
> +1
>
> On Wed, Aug 16, 2023 at 2:39 PM Chris McFarlen wrote:
>
>> The cpp plugin API is being deprecated for 10.0 (tscpp/api/*). I'd like
>> to just remove the examples immediately
+1
On Wed, Aug 16, 2023 at 2:39 PM Chris McFarlen wrote:
> The cpp plugin API is being deprecated for 10.0 (tscpp/api/*). I'd like to
> just remove the examples immediately for 10.0 since we don't need examples
> for a deprecated API. Removing them now will also create less work for the
> CMake
something wrong…
>
>
>
> PS: I didn’t found any issue on github about it.
>
>
>
> Thanks again
>
> Nuno Baeta
>
>
>
> *From:* Walt Karas
> *Sent:* 1 de junho de 2023 16:06
> *To:* Nuno Jose Baeta
> *Subject:* Fwd: [E] How to log total server resp
As a background question, is there a trie somewhere that the HTTP header
parser (in the core) uses to return WKS pointers for WKSs in the headers?
I'm having trouble seeing how the speedup of comparing to WKS pointers is
not negated by the time needed to detect WKSs in HTTP headers.
On Sun, May 14
Yes, but Yahoo won't be using that plugin with open source 9.2.x .
On Thu, Apr 27, 2023 at 7:03 PM James Peach wrote:
>
>
> > On 28 Apr 2023, at 5:16 am, Walt Karas
> wrote:
> >
> > It's like there are some cases where these functions do work. But
>
It's like there are some cases where these functions do work. But noone's
responded and said they've successfully used them. I'd hope anyone writing
plugins is subscribed to this mailing list.
On Thu, Apr 27, 2023 at 12:17 AM James Peach wrote:
>
>
> > On 27
Everything I know is in this issue:
https://github.com/apache/trafficserver/issues/9562 ? Are you saying you
don't understand it? Can you be more specific about what isn't clear?
On Wed, Apr 26, 2023 at 9:48 PM James Peach wrote:
>
>
> > On 25 Apr 2023, at 1:01 p
Speak now or forever hold you peace.
On Mon, Apr 24, 2023 at 10:01 PM Walt Karas wrote:
> https://github.com/apache/trafficserver/pull/9587 indicates they do not
> work. There are no definite plans to fix them. So, seems they are
> unlikely to be fixed before the release of 9.2.1.
https://github.com/apache/trafficserver/pull/9587 indicates they do not
work. There are no definite plans to fix them. So, seems they are
unlikely to be fixed before the release of 9.2.1. Fixing or removing them
in 10.0 is a related but separate issue.
I believe there's a concern about io_uring in that using it means ATS can
now crash the kernel, which is harder to debug than a process crash.
On Mon, Apr 3, 2023 at 12:38 PM Chris McFarlen wrote:
> I would like to remove this disk IO mode from ATS. If nobody is using it,
> then I'd like to dele
x27;d deprecate the old API and remove it in the future.
> That's a lot of work.
>
> I feel like introducing TSVarLenData has more downside than the upside.
>
> On Wed, Jan 4, 2023 at 9:13 AM Walt Karas
> wrote:
>
> > They could make the returned structure a nesting stru
>
> > On Jan 4, 2023, at 3:03 PM, Walt Karas
> wrote:
> >
> > There are people at Yahoo who have written plugins in straight C, and
> don't
> > want to change to C++.
>
> They can continue to write plugins in C, just have to compile with a C++
> compile
g plug-ins with C but require C++? Then we can introduce nice
> things in ts.h. The old C plugins just have to be changed to compile with
> C++, and ABI compatibility within major version must be enforced.
>
> — Leif
>
> > On Sep 6, 2022, at 10:24, Walt Karas
> wrote:
>
ght want
> to store the returned pointer into a user-defined structure.
>
>
>
> On Tue, Sep 6, 2022 at 10:24 AM Walt Karas
> wrote:
>
> > Presumably we don't need to allow for use of antiquated C compilers that
> > don't allow structures as return valu
void TSDbgCtlDestroy(TSDbgCtl const *dbg_ctl);
Destroys a TSDbgCtl created by a call to TSDbgCtlCreate().
This is needed so that the data structure containing all of the TSDbgCtl
instances is not destroyed until all references to it have been destroyed.
(The references are counted.)
A small chage is proposed in this PR:
https://github.com/apache/trafficserver/pull/9187
In Cleanup.h, allow the continuation of TxnAuxDataMgr to be used for
general purposes.
TSCont TSContWhenCreate(TSEventFunc funcp, TSMutex mutexp);
With this change, TSCont objects will have an implicit "retry" flag. The
retry flag will be true when the TSCont is created with
TSContWhenCreate(). The flag will be false when the TSCont is created with
TSContCreate().
If the retry fl
FYI, this is a way to make your (non-core) plugin build with the new (much
lower overhead) debug interface, or the old one if the the new one is not
available in the ATS version you need the .so to run with:
#if defined(TSDbg)
const TSDbgCtl *dbg_ctl_yada = TSDbgCtlCreate("yada");
#define DBG_YAD
nges, the fix and the new
> API, should be made like 1 + 1, but not 1.5 + 0.5 nor 1 + 0.5 + 0.5.
>
> Masakazu
>
> On Thu, Sep 1, 2022 at 10:08 AM Walt Karas
> wrote:
>
> > As a rule of thumb, I prefer using encapsulation/data abstraction. I
> think
> > perhaps
ug 31, 2022 at 8:36 AM Masakazu Kitajo wrote:
> >
> > What's the advantage of using TSHeapBuf? What issue does it solve?
> >
> >
> > On Wed, Aug 31, 2022 at 7:48 AM Walt Karas
> > wrote:
> >
> > > Described here:
> > >
> > >
&
Wow, your question is actually answered in docs:
https://docs.trafficserver.apache.org/developer-guide/introduction/header-file-structure.en.html?highlight=cppapi
. Run out and buy a lottery ticket, the goddess of good fortune is smiling
upon you today.
On Wed, Aug 31, 2022 at 7:44 PM Walt Karas
wrote:
> Can someone tell me what should be under tscpp/api and tscpp/util ?
>
> On Wed, Aug 31, 2022 at 5:07 AM Walt Karas
> wrote:
>
> > I propose moving Cleanup.h from plugins/xdebug to include/ts/api as a
> part
> > of
> https://urldefense.com/v3/__https://git
Described here:
https://github.com/apache/trafficserver/blob/os_pkey_cnf_reload/doc/developer-guide/api/functions/TSHeapBuf.en.rst#tsheapbufdata
,
In PR https://github.com/apache/trafficserver/pull/8790 .
This allows a dynamically allocated buffer, of any reasonable length, to be
returned by a TS
I propose moving Cleanup.h from plugins/xdebug to include/ts/api as a part
of https://github.com/apache/trafficserver/pull/9044 .
There is a way to do this in the C API (global arguments with
TSUserArgSet/Get). But it doesn't look like these functions are supported
in the Lua API. Can you keep the data in a file, perhaps on a RAM disk to
make access fast?
On Wed, Jul 13, 2022 at 4:41 AM Vishal Garg
wrote:
> Hey,
> ATS Ve
What's at line 200 in your remap.config file?
On Thu, Jun 23, 2022 at 2:25 PM Vasanth Sekkar
wrote:
> Hi,
>
> I am facing issue after enabling FQ pacing plugin in remap.config. I am
> seeing the following error log in diags.log. Can you please guide me on
> this?
>
> [Jun 23 18:53:01.590] traffi
If we really want to swing for the bleachers, we could move all config into
a plugin. In a way that would allow a proxy to be managed with SNMP, gRPC,
etc. by replacing the plugin.
On Tue, Oct 5, 2021 at 12:33 PM Robert O Butts wrote:
> +1
>
> IMO we should have APIs for all SSL/SNI data.
>
> O
Oh I see, for cases where there is no status?
On Tue, Jun 1, 2021 at 10:13 AM Walt Karas wrote:
> Hmm, you can't use TSHttpHdrStatusGet() ?
>
> On Sat, May 29, 2021 at 9:19 AM Sanjay Singh
> wrote:
>
>> Hi all,
>>
>> I'd like to propose a chan
Hmm, you can't use TSHttpHdrStatusGet() ?
On Sat, May 29, 2021 at 9:19 AM Sanjay Singh
wrote:
> Hi all,
>
> I'd like to propose a change to an existing TS API, "TSHttpTxnAborted".
>
> The current function signature:
> TSReturnCode
> TSHttpTxnAborted(TSHttpTxn txnp)
>
> Propsed change:
> TSReturn
--enable-debug means that the code will be compiled without the -O3 option,
that is to say, no optimization. It's not related to whether trace/debug
output is configured on or off. You can enable trace/debug output even if
you did not specify --enable-debug when you run configure.
On Tue, Apr 20
If I remember correctly, I don't think, in ATS9, you can load the same
plugin in both plugin.config and remap.config. But I'm not sure that's a
new restriction in 9 versus 7.
On Fri, Mar 19, 2021 at 9:19 PM Alan Carroll
wrote:
> Yes, sorry, I'm OOO this week. You can disable it in "records.conf
https://github.com/apache/trafficserver/pull/7452
This PR changes TS API. It introduces this new type:
typedef struct TSFDbgCtl_s {
char volatile on; // Flag
char const *tag;
} TSFDbgCtl;
And this function:
tsapi TSFDbgCtl const *TSFDbgCtlCreate(char const *tag);
And this new printf-like
The other option would be to write tutorials. If it's easier to do talks,
hopefully they would be recorded. We could scrape together money for a
tech writer and get written tutorials from the videos.
On Tue, Feb 2, 2021 at 4:35 PM Evan Zelkowitz wrote:
> Can put me down as interested in all of
e" is not used). "pristine" will mean the
pristine URL is used in place of the remapped, for matching as well as
substitution.
On Fri, Nov 13, 2020 at 12:54 PM Walt Karas wrote:
> 1. Two-character string substitutions can begin with ^ as well as $. If
> ^ is used, and
1. Two-character string substitutions can begin with ^ as well as $. If ^
is used, and the substitution is a URL component, the component will be the
one in the pristine, rather than the remapped, URL. So, for example, $h is
the host in the remapped URL, and ^h is the host in the pristine URL.
Note also that the PR included an implementation of read/write locking that
avoids writer starvation, which apparently is an issue with
std::shared_mutex and pthreads rwlock.
On Mon, Nov 2, 2020 at 10:20 AM Walt Karas wrote:
> Since this was mentioned during the summit, I just wanted
Since this was mentioned during the summit, I just wanted to highlight that
there was an issue opened for this, I created a PR, but it was never
merged: https://github.com/apache/trafficserver/issues/6150
> On Tue, Oct 6, 2020 at 3:22 PM Walt Karas .invalid>
> wrote:
>
> > So, when I call the current TSUrlSchemeGet() for these two requests:
> >
> > printf "GET / HTTP/1.1\r\nHost: mYhOsT.teSt:61000\r\n\r\n" | nc localhost
> > 61001
> > printf
lRawPortGet that returns 0
> if the port is not explicitly present in the URL.
>
> On Tue, Sep 29, 2020 at 9:28 AM Walt Karas
> wrote:
>
>> This gets the port string in the URL. If the port is not in the URL, it
>> returns nullptr (and sets length to zeor). Note this is
edstrom wrote:
> >> >
> >> > The point here being to make a new API that replaces the old, without
> >> breaking compatibility? And this new API has special semantics on a
> cache
> >> hit vs cache miss?
> >> >
> >> > This seems
> +1
> >
> > No, that's basically it. Except I see no reason this information
> shouldn't
> > be accessible.
> >
> > On Mon, Sep 28, 2020 at 7:06 PM Walt Karas > .invalid>
> > wrote:
> >
> > > Yes, that makes sense, if you are readin
This gets the port string in the URL. If the port is not in the URL, it
returns nullptr (and sets length to zeor). Note this is subtly different
from TSUrlPortGet which always returns a valid port, the canonical port for
the scheme if the port is not specified. Currently there is no way to
detect t
This should get the scheme for the request. This differs from
`TSUrlSchemeGet` in that it gets the scheme even if it is not in the URL of
the request. For most proxy requests, the ATS core will remove the host and
scheme in the request while tracking it internally. In such a case a plugin
cannot di
> type and call the appropriated Get (TSMgmtIntGet, TSMgmtStringGet, etc).
>
> As someone who implemented something similar but for the internal
> RPC(jsonrpc) this function could be handy.
>
>
> Thanks,
> Damian.
>
> On Mon, Sep 28, 2020 at 10:02 PM Walt Karas
>
guration variable name is not
> known at compile time.
>
> On Mon, Sep 28, 2020 at 3:46 PM Walt Karas .invalid>
> wrote:
>
> > So, more concretely, is it for future safety? For example, if the value
> is
> > a percentage, and it's currently an int, but you suspect it
whether
> to call TSMgmtIntGet or *TSMgmtFloatGet*. There is currently no way to know
> programmatically. The code has to "just know" which it is.
>
> On Mon, Sep 28, 2020 at 2:10 PM Walt Karas .invalid>
> wrote:
>
> > Can you describe an example situation where
Can you describe an example situation where this would be useful?
On Mon, Sep 28, 2020 at 1:59 PM Damian Meden
wrote:
> Hi Guys.
>
> I would like to propose adding a new API function to bring the record data
> type from a particular record.
>
> A brief description of this new proposed API:
>
>
>
+1
On Wed, Sep 9, 2020 at 11:57 AM Bryan Call wrote:
> +1
>
> -Bryan
>
>
> > On Sep 8, 2020, at 10:04 AM, Aaron Canary
> wrote:
> >
> > I'd like to propose adding API calls for the remaining methods in diag.h:
> > TSStatus(const char *fmt, ...) // prints to diags log (informational)
> > TSNote(
Would traffic replay use this information? More generally, what I'm
wondering is, how does traffic dump coordinate with TS's logging capability?
I think typically, the TS API provides these sorts of handles to plugins so
they can change the processing of the transaction/session/etc. We could
als
+1
On Thu, Jul 30, 2020 at 6:29 PM Brian Neradt wrote:
> Hi dev@trafficserver.apache.org,
>
> We currently run clang-format as a part of our pre-commit hook. This is a
> helpful tool for applying our formatting standards on our C++ files. I
> suggest we extend the hook to also inspect any Python
+1 as long as it doesn't cause uncommented commits.
On Mon, Jun 15, 2020 at 9:43 AM Steven R. Feltner
wrote:
> +1
>
> On 6/14/20, 11:32 AM, "Bryan Call" wrote:
>
> Notice: This email is from an external sender.
>
>
>
> I would like to propose that we switch to "Squash and Merge" for
>
Hmm I think if you forgot to call 'Transaction::addPlugin()' you would just
leak the plugin object, I don't think it would cause the crash you saw.
On Mon, May 18, 2020 at 6:38 PM Sudheer Vinukonda
wrote:
> We recently ran into a core dump issue due to one of our
> TransactionPlugin's continuati
make HostDB timing/updates
> considerably more readable.
>
> On Tue, Mar 31, 2020 at 4:58 PM Walt Karas
> wrote:
>
>> Should we add a utility like this to include/ts/util ?
>>
>> class Throttle
>> {
>> public:
>> Throttle(unsigned secondsBetween =
Should we add a utility like this to include/ts/util ?
class Throttle
{
public:
Throttle(unsigned secondsBetween = 60);
// Returns true the first time it's called, and if the time since the
last time it returned true is
// more than secondsBetween seconds.
//
bool operator () ();
//
Here is some (simplistic) example code using NoStale:
https://github.com/ywkaras/MiscRepo/blob/master/NoStale/example.cc
On Thu, Mar 26, 2020 at 11:53 AM Walt Karas wrote:
> https://github.com/ywkaras/MiscRepo/blob/master/NoStale/NoStale.h
>
I was having problems with this too in a new plugin I was writing. I had
to make this small change to get it to work:
https://github.com/apache/trafficserver/pull/6489/files#diff-8c09c39a3b13e183ba1bfd1e590cfb21
I found that I had to use TSContScheduleOnPool() instead of
TSContSchedule().
On Thu
https://github.com/ywkaras/MiscRepo/blob/master/NoStale/NoStale.h
Some questions about null_transform.c (the mother of all transform plugins).
Is this,
https://github.com/apache/trafficserver/blob/d9f647ca7c15d0eb4687fa59706ab246f49ece1b/example/plugins/c-api/null_transform/null_transform.c#L192
, really a reliable way to make sure all transform-related resource
12:31 PM Leif Hedstrom wrote:
>
> >
> >
> > > On Mar 4, 2020, at 11:17 AM, Walt Karas .INVALID>
> > wrote:
> > >
> > > So why do you like this?
> >
> > - Less code
> > - Fewer APIs
> > - Generalizes the concept
> >
>
So why do you like this?
- Breaks lots of existing code.
- Less typesafe.
- Makes use more verbose.
It's good how the API has avoided the use of void pointers. We should not
reverse that design goal.
On Wed, Mar 4, 2020 at 12:03 PM Leif Hedstrom wrote:
>
>
> > On Feb 27, 2020, at 10:13 AM, Le
I'm thinking perhaps we should instead pass a const pointer to:
typedef struct {
TSReturnCode (*globalArgIndexReserve)(const char * name, const char *
description, int * arg_idx);
TSReturnCode (*globalArgIndexNameLookup)(const char * name, int *
arg__idx, const char ** description);
TSRetur
Did you mean:
void TSGlobalArgSet(int arg_idx, void * arg)
void * TSGlobalArgGet(int arg_idx)
???
On Thu, Feb 27, 2020 at 11:13 AM Leif Hedstrom wrote:
> Hi all,
>
> This is an idea from Bryan Call, which he suggested as a solution for
> reloadable plugins changes that are now in 9.0.x. I re
Sudheer, can you create a branch in your trafficserver fork, that switches
an existing plugin from using TxnArg to GlobalArg? I don't see how that
would work typically. I believe the point is that you want a different
value for the same arg index for each transaction.
On Thu, Feb 27, 2020 at 11:
Using async seems roughly equivalent to scheduling a Continuation. Calling
it will likely create a thread or a thread pool, on top of the ones in the
ATS core. atscppapi also has a C++ wrapper for TSCont (in
Continuation.h). I tried to get in some improvements to this (
https://github.com/apache
1 - 100 of 287 matches
Mail list logo
