+1 On Wed, Sep 9, 2020 at 11:57 AM Bryan Call <bc...@apache.org> wrote:
> +1 > > -Bryan > > > > On Sep 8, 2020, at 10:04 AM, Aaron Canary <acan...@verizonmedia.com> > wrote: > > > > I'd like to propose adding API calls for the remaining methods in diag.h: > > TSStatus(const char *fmt, ...) // prints to diags log (informational) > > TSNote(const char *fmt, ...) // prints to diags log (implies > significance) > > TSWarning(const char *fmt, ...) // prints to diags log (implies concern) > > TSAlert(const char *fmt, ...) // exit and restart, prints to diags log > (implies needs attention) > > > > The following are already exposed through the API: > > TSDebug(const char* tag, const char *fmt, ...) // print to stderr > > TSError(const char *fmt, ...) // prints to diags log (implies operation > failure, causes test fail in CI) > > TSFatal(const char *fmt, ...) // exit and restart, prints to diags log > > TSEmergeny(const char *fmt, ...). // exit and don't restart, prints to > diags log > > > > I'd like to add these to the TS API, and update the documentation to > directly describe the uses of each. I'm not interested in changing any > functionality of diags.h/.cc at the moment, just exposing for plugins to > use. > > > > Corrections? Major objections or concerns? > > I'll reply here with the PR when it's ready. That might be a better > forum to discuss the details. > >
