Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Duncan Jones
On Fri, 9 Jun 2017 at 02:35, Gary Gregory wrote: > On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote: > > > There is a one other compatibility issue, which can be seen in the > attached > > code: > > > > import java.nio.charset.StandardCharsets; > > > > public class Weasel { > > > > private

Re: [text] Correct RandomStringGenerator description of thread safety/immutability

2017-06-04 Thread Duncan Jones
> On 3 Jun 2017, at 09:55, sebb wrote: > > On 3 June 2017 at 08:40, Gilles wrote: >> Hi Duncan. >> >> Can we really say that "RandomStringBuilder instances >> are _immutable_ [...] if using the default random number >> generator"? >> Calling "nextInt" on the instance returned by >> ThreadLoca

Re: [lang] Appetite for new method StringUtils.toCamelCase(String str, char delimiter, boolean capitalizeFirstLetter)

2017-06-01 Thread Duncan Jones
On Thu, 1 Jun 2017 at 16:31, Amey Jadiye wrote: > +1 seems good to have in toolbox. pretty similar method I have seen in > Commons text WordUtils.capitalize() almost similar logic we will need here > ,just not to capitalize first word and join them all, I'm in favour of > having this in WordUtils

Re: [lang] Appetite for new method StringUtils.toCamelCase(String str, char delimiter, boolean capitalizeFirstLetter)

2017-06-01 Thread Duncan Jones
On Thu, 1 Jun 2017 at 15:27, Gary Gregory wrote: > IMO camel casing is all about words so [text] WordUtils. But why not have a > CamelCaseUtils instead? > > Gary +1. IMO it belongs in TEXT (if anywhere) and we should avoid classes with static methods. Per our other conservation about case conv

Re: [TEXT] How do we want to handle case conversions?

2017-05-25 Thread Duncan Jones
for removal in 2.0? > > Cheers > Bruno > [] https://codepoints.net/U+1D52B?lang=en > [] https://en.wikipedia.org/wiki/Ch_(digraph)#Czech > [] https://en.wikipedia.org/wiki/Van_(Dutch)#Collation_and_capitalisation > > From: Duncan Jones &g

[LANG] Unsafe use of varargs (LANG-1295/1296)

2017-05-23 Thread Duncan Jones
Hi everyone, I would welcome some comments on LANG-1295 [1] and LANG-1296 [2], which I raised about unsafe use of varargs in ArrayUtils.toArray(T... items) and ArrayUtils.addAll(T[] array1, T... array2). Should we deprecate these methods (to be removed in 4.0), since they can cause a ClassCast

Re: [TEXT] How do we want to handle case conversions?

2017-05-21 Thread Duncan Jones
rectly for English at the moment, which would normally capitalise “The Life of Reilly” rather than “The Life Of Reilly”. Other languages have completely different conventions or additional complexities. > > On May 21, 2017 5:06 AM, "Duncan Jones" wrote: > >> Hi everyo

Re: [TEXT] How do we want to handle case conversions?

2017-05-21 Thread Duncan Jones
> others could implement the ones the desire as needs arise. Nice idea, I’ll see what’s possible. > > On 21 May 2017 16:48, "Benedikt Ritter" wrote: > >> Hi, >> >>> Am 21.05.2017 um 08:06 schrieb Duncan Jones : >>> >>> Hi everyone

[TEXT] How do we want to handle case conversions?

2017-05-21 Thread Duncan Jones
Hi everyone, I’ve found some time to continue breaking WordUtils into separate classes (eschewing the “big collection of static methods” approach). However, as I read more about case handling in Unicode, I realise how simplistic the WordUtils methods are and how complex a full solution would ne

Re: [VOTE] Promote TEXT to Proper

2017-01-04 Thread Duncan Jones
+1 (non-binding) > On 4 Jan 2017, at 06:46, Benedikt Ritter wrote: > > Hello Rob, > > Rob Tompkins schrieb am Di., 3. Jan. 2017 um 20:40 Uhr: > >> Hello all, >> >> I propose that we move [text] to Commons Proper. >> >> -- >>

Re: [TEXT] Pull WordUtils from 1.0?

2017-01-02 Thread Duncan Jones
> On 2 Jan 2017, at 19:34, Rob Tompkins wrote: > > >> On Jan 2, 2017, at 1:32 PM, Duncan Jones wrote: >> >> Hi all, >> >> I'm currently refactoring WordUtils into several classes containing instance >> methods. > > Any rough e

[TEXT] Pull WordUtils from 1.0?

2017-01-02 Thread Duncan Jones
Hi all, I'm currently refactoring WordUtils into several classes containing instance methods. Should we pull it from 1.0 to avoid releasing it in 1.0 and deprecating in 1.1 or 1.2? Duncan - To unsubscribe, e-mail: dev-unsubs

Re: [text] Complete test coverage for RandomStringGenerator

2016-12-27 Thread Duncan Jones
> On 27 Dec 2016, at 10:29, Gilles wrote: > > Hi. > > On Tue, 27 Dec 2016 09:54:29 + (UTC), djo...@apache.org wrote: >> Repository: commons-text >> Updated Branches: >> refs/heads/master 1b3e44809 -> 0b1ca53b3 >> >> >> Complete test coverage for RandomStringGenerator >> >> Project: http

Re: [text] Rename RandomStringBuilder and make it immutable and thread-safe.

2016-12-27 Thread Duncan Jones
> On 27 Dec 2016, at 08:45, djo...@apache.org wrote: > > Repository: commons-text > Updated Branches: > refs/heads/master 6f6da3467 -> 08ac56a50 > > > Rename RandomStringBuilder and make it immutable and thread-safe. > > The RandomStringBuilder class was renamed to RandomStringGenerator. The

Re: [TEXT] Items to port from Lang

2016-12-22 Thread Duncan Jones
> On 21 Dec 2016, at 19:06, Gary Gregory wrote: > > On Wed, Dec 21, 2016 at 11:02 AM, Duncan Jones > wrote: > >> >> >>> On 21 Dec 2016, at 18:57, Gary Gregory wrote: >>> >>> On Wed, Dec 21, 2016 at 12:17 AM, Duncan Jones >>>

Re: [TEXT] Items to port from Lang

2016-12-21 Thread Duncan Jones
> On 21 Dec 2016, at 18:57, Gary Gregory wrote: > > On Wed, Dec 21, 2016 at 12:17 AM, Duncan Jones > wrote: > >> Hi, >> >> Looking through Lang, I don’t see too much that needs to come across to >> Text. >> >> - The string distance algori

Re: [text] Clarify whether varargs are being used in test (squashes warning).

2016-12-21 Thread Duncan Jones
> On 21 Dec 2016, at 08:28, djo...@apache.org wrote: > > Repository: commons-text > Updated Branches: > refs/heads/master 120409051 -> 322fe2723 > > > Clarify whether varargs are being used in test (squashes warning). Note: I’m really not a big fan of using reflection to inspect fields in a u

[TEXT] Items to port from Lang

2016-12-21 Thread Duncan Jones
Hi, Looking through Lang, I don’t see too much that needs to come across to Text. - The string distance algorithms have already moved and can be deprecated in StringUtils, once 1.0 is released - The remainder of StringUtils doesn’t feel like it belongs in Text - RandomStringUtils has been por

[TEXT] Support for generating random strings?

2016-12-18 Thread Duncan Jones
Hi, A recent discussion on LANG/RNG[1] seems to have concluded that RandomStringUtils doesn’t belong in LANG and almost certainly not in RNG either. Would there be any interest in creating a similar class within TEXT? I’d be happy to work on this and produce a first draft class. To give a flav

Re: [LANG] [RNG] New Unicode-capable additions to RandomStringUtils

2016-12-18 Thread Duncan Jones
> On 18 Dec 2016, at 10:51, sebb wrote: > > On 18 December 2016 at 10:40, Pascal Schumacher > wrote: >> Am 18.12.2016 um 11:23 schrieb sebb: >>> >>> It's definitely too specialised for LANG. >> >> I do not think this is too specialized for LANG. RandomStringUtils has been >> part of LANG sinc

Re: [LANG] [RNG] New Unicode-capable additions to RandomStringUtils

2016-12-17 Thread Duncan Jones
in Lang or perhaps moving to Text. Duncan > > On Dec 17, 2016 10:39 PM, "Duncan Jones" wrote: > >> On reflection, a bad choice of subject line. The other methods are >> Unicode-capable, but just very rooted in thinking about char data types. >> >>>

Re: [LANG] New Unicode-capable additions to RandomStringUtils

2016-12-17 Thread Duncan Jones
On reflection, a bad choice of subject line. The other methods are Unicode-capable, but just very rooted in thinking about char data types. > On 18 Dec 2016, at 06:38, Duncan Jones wrote: > > Hi all, > > I’ve created a variation of RandomStringUtils.random(), which generates t

[LANG] New Unicode-capable additions to RandomStringUtils

2016-12-17 Thread Duncan Jones
Hi all, I’ve created a variation of RandomStringUtils.random(), which generates the specified number of code points (rather than chars). Implementation can be seen here (https://gist.github.com/dmjones500/da2f61a0234f428748417bf1443c0dff). Signature is: public static String randomUnicode(f

Re: [LANG] Support recursion in ReflectionToStringBuilder and deprecate RecursiveToStringStyle?

2016-12-04 Thread Duncan Jones
> On 24 Nov 2016, at 22:13, Pascal Schumacher wrote: > > Am 23.11.2016 um 21:29 schrieb Duncan Jones: >> To create a deep toString() representation of an object, one must use a >> combination of ReflectionToStringBuilder and RecursiveToStringStyle. IMO >>

[LANG] Support recursion in ReflectionToStringBuilder and deprecate RecursiveToStringStyle?

2016-11-23 Thread Duncan Jones
Hi all, To create a deep toString() representation of an object, one must use a combination of ReflectionToStringBuilder and RecursiveToStringStyle. IMO this confuses behaviour and presentation. LANG-1249 is an example of the problems the original design can cause - it’s not clear from the Ref

Re: [text][lang] string escaping

2016-11-19 Thread Duncan Jones
> On 19 Nov 2016, at 15:38, Rob Tompkins wrote: > > >> On Nov 19, 2016, at 6:33 AM, Benedikt Ritter wrote: >> >> Hello Gray, >> >> Gary Gregory schrieb am Sa., 19. Nov. 2016 um >> 01:07 Uhr: >> >>> Just a thought: >>> >>> Does all the current (and future) string escaping code (XML, HTML,

Re: [lang] Proposal: Allow extending DiffResult

2016-03-05 Thread Duncan Jones
On 3 March 2016 at 18:49, rgm wrote: > No, because ToStringStyle affects the rendering of only one of the object's > toString methods and cannot change the "left differs from right" output, > although it could change the rendering of either "left" or "right." The > inclusion of two objects and th

Re: [lang] Use of "Review Patch"

2015-04-15 Thread Duncan Jones
I wasn't trying to rock the boat too much with this suggestion. But if others agree, I'd be happy to make a more substantial change that involves moving to Jira labels too. Duncan > > > Cheers, > Paul > > On Wed, Apr 15, 2015 at 3:18 PM, Duncan Jones wrote: > >>

[lang] Use of "Review Patch"

2015-04-15 Thread Duncan Jones
Hi folks, Currently the "Review Patch" fix version seems to be applied whenever code has been supplied in an issue. This includes situations where agreement hasn't yet been reached on fixing the issue and where the supplied "patch" is minimal at best. I would prefer if we only use this marker on

Re: svn commit: r1672833 - in /commons/proper/lang/trunk/src: changes/changes.xml main/java/org/apache/commons/lang3/CharSet.java test/java/org/apache/commons/lang3/CharSetTest.java

2015-04-13 Thread Duncan Jones
On 13 April 2015 at 12:19, Benedikt Ritter wrote: > Hello Duncan, > > 2015-04-11 8:02 GMT+02:00 : > >> Author: djones >> Date: Sat Apr 11 06:02:34 2015 >> New Revision: 1672833 >> >> URL: http://svn.apache.org/r1672833 >> Log: >> Update for LANG-1069: CharSet.getInstance documentation does not cle

[lang] testTimeZoneStrategyPattern() runs twice for no apparent gain

2015-04-11 Thread Duncan Jones
Hi everyone, Lang takes a few minutes to build on my system, so I was examining execution times of tests to see if anything can be improved. I noticed that FastDateParserTest.testTimeZoneStrategyPattern() takes quite a long time to execute (over 40 seconds for me). Then I noticed this is executed

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC2

2015-04-04 Thread Duncan Jones
+0 (non-binding) Built from zipped sources, digests look fine. JDK 1.8.0_40 on Win 8.1. (Site build fails as mentioned already). Site builds fine from JDK 1.7.0_75. For me the FindBugs page is blank, not sure if that's to be expected? 97 skipped tests seems a little high (think this was mentioned

Re: [PROPOSAL] Create new sandbox component "Commons Crypto"

2015-04-02 Thread Duncan Jones
On 18 March 2015 at 15:47, Phil Steitz wrote: > > On 3/18/15 5:57 AM, Duncan Jones wrote: >> Hi everyone, >> >> I would like to begin work on a new sandbox component, Commons Crypto, >> that makes it easier for developers to use crypto from the standard >> Java

[PROPOSAL] Create new sandbox component "Commons Crypto"

2015-03-18 Thread Duncan Jones
Hi everyone, I would like to begin work on a new sandbox component, Commons Crypto, that makes it easier for developers to use crypto from the standard Java libraries. The component would have two goals: 1) To make it harder for users to make typical crypto errors, 2) To make it easier to perform

Re: [VOTE][LAZY] Migrate Apache Commons Lang to git

2015-03-05 Thread Duncan Jones
On 5 March 2015 at 10:13, Benedikt Ritter wrote: > Hi, > > 2015-03-05 0:40 GMT+01:00 sebb AT ASF : > >> On 3 March 2015 at 17:51, Benedikt Ritter wrote: >> > Hi, >> > >> > 2015-03-01 19:04 GMT+01:00 Benedikt Ritter : >> > >> >> Hello, >> >> >> >> 2015-01-06 18:55 GMT+01:00 sebb : >> >> >> >>> On

Re: [ALL] Too much traffic on the "dev" ML

2015-01-17 Thread Duncan Jones
On 17 January 2015 at 16:59, Ole Ersoy wrote: > GIlles, > > Well said as always. > > With respect to the goal of growing the community, I think everyone agrees > that that's a good goal. > So if we pick tools that developers are most likely to be used to, then they > are more likely to join. > > T

Re: [ALL] Too much traffic on the "dev" ML

2015-01-16 Thread Duncan Jones
On 16 January 2015 at 14:54, Torsten Curdt wrote: >> Concerning [Math], when the possibility was raised, the majority >> thought that development within Commons had practical advantages >> (through shared burden of the development environment). >> >> I'm stating again the fact that nobody is invol

Re: [DISCUSS] Jira karma for ASF committers? (Was: Re: [ANNOUNCEMENT] Apache Commons grants write access to all ASF committers)

2014-12-18 Thread Duncan Jones
On 18 December 2014 at 13:03, Mark Thomas wrote: > On 18/12/2014 11:37, Jochen Wiedmann wrote: >>> You're bringing up a valid point here... If ASF committers can change the >>> code/fix bugs/implement new features, they should be able to modify the >>> corresponding jira tickets. >> >> They should

Re: [DRAFT][ANNOUNCE] Apache Commons grants write access to all ASF committers

2014-12-15 Thread Duncan Jones
On 15 December 2014 at 08:25, Benedikt Ritter wrote: > 2014-12-15 4:02 GMT+01:00 Gary Gregory : >> >> Nice feedback all around. Here is a version that includes some of these >> thoughts: >> -- >> >> Dear fellow committers, >> >> The Apache Commons Team is pleased to announce that write access to t

Re: [ALL] Do we need help?

2014-11-30 Thread Duncan Jones
On 29 Nov 2014 10:53, "Benedikt Ritter" wrote: > > Hi all, > > currently I feel really overwhelmed by the stuff I'd like to do at commons > and the little time I can spend for it. Here is an (incomplete) list of the > things I'd like to work on: > > - get a new release of the build plugin out of t

Re: LANG-1052: Multiline recursive to string style

2014-11-07 Thread Duncan Jones
Hi Jan, On 7 November 2014 05:39, Jan Matèrne (jhm) wrote: > ping :) > > Jan All the Lang developers are quite active on the mailing list, so you can assume we've read your earlier email. However, we are busy people with lives outside Apache Commons (the horror!), so it may take us a few days to

Re: [lang] New compare() methods in LANG-536 pull request match Java source - is this ok?

2014-10-19 Thread Duncan Jones
On 19 October 2014 07:04, Duncan Jones wrote: > On 18 October 2014 06:25, Duncan Jones wrote: >> On 17 October 2014 23:41, James Sawle wrote: >>> How do you create new implementations of such basic functionality that is >>> so explicitly defined within the API? It

Re: [lang] New compare() methods in LANG-536 pull request match Java source - is this ok?

2014-10-18 Thread Duncan Jones
On 18 October 2014 06:25, Duncan Jones wrote: > On 17 October 2014 23:41, James Sawle wrote: >> How do you create new implementations of such basic functionality that is so >> explicitly defined within the API? It is like suggesting that we write 1+1 >> as 1+((1+1)-1) j

Re: [lang] New compare() methods in LANG-536 pull request match Java source - is this ok?

2014-10-17 Thread Duncan Jones
o precious Java versions. I think that the methods >>> should be removed as of Lang4 or if Java 7 becomes supported in Lang3 to >>> support this point. >> >> Yes, they should probably be removed when no longer needed. >> If they can be excluded from the public

Re: [lang] Differences in commons-lang (2.x) and commons-lang3 prevent TomEE project from migrating completely (Was: Re: [JCS] release?)

2014-10-17 Thread Duncan Jones
On 17 Oct 2014 21:11, "Romain Manni-Bucau" wrote: > > Yes, that what i said we were not impacted even if the stack is big. > > Once again in theory you are right but in practise that's boring and > creates averhead for nothing. You're not making a lot of sense here. Sebb explained a problem with

[lang] New compare() methods in LANG-536 pull request match Java source - is this ok?

2014-10-17 Thread Duncan Jones
Hi, James has authored a fine patch for LANG-536 (see below), but it does include some code that exactly matches Java 7 source. Specifically, the various compare(primitive, primitive) methods that have been added to BooleanUtils, NumberUtils and CharUtils are identical to the methods provided in J

Re: [ALL] How to handle GitHub pull requests

2014-10-17 Thread Duncan Jones
On 17 October 2014 09:07, Emmanuel Bourg wrote: > Le 17/10/2014 09:44, Duncan Jones a écrit : > >> Is there a preferred approach to take here? I have a GitHub account, >> so presumably I could be given rights to the repositories I commit to >> (lang) and this would allow

[ALL] How to handle GitHub pull requests

2014-10-17 Thread Duncan Jones
Hi everyone, Some of our contributors like to use GitHub pull requests (PRs) as a means of providing patches. Until now, I've tended to access the .patch version of these pull requests and apply them in SVN. Is there a preferred approach to take here? I have a GitHub account, so presumably I coul

Re: [lang] LANG-975

2014-10-14 Thread Duncan Jones
On 14 October 2014 14:07, Duncan Jones wrote: > On 9 October 2014 19:17, Benedikt Ritter wrote: >> I'm not fond that we need this method. However you're raising a good point. >> BooleanUtils only "talks" english. It understands "yes" and "no&

Re: [lang] LANG-975

2014-10-14 Thread Duncan Jones
method >> signature to simplify the conversion from Strings to Booleans based upon a >> single true boolean String. This is therefore unlike the other methods, >> which either take no parameters (use a prebuilt list of true and false >> values), or require the user to p

Re: svn commit: r1628921 - /commons/proper/lang/trunk/src/changes/changes.xml

2014-10-02 Thread Duncan Jones
Thanks Benedikt, I'd better poke my IDE with a sharp stick. The XML settings must be wrong. On 2 October 2014 11:07, wrote: > Author: britter > Date: Thu Oct 2 10:07:11 2014 > New Revision: 1628921 > > URL: http://svn.apache.org/r1628921 > Log: > Remove tab characters > > Modified: > common

Re: [LANG] Thoughts on LANG-1039

2014-09-26 Thread Duncan Jones
t; >> Hi Duncan, >> Does it make sense to create a method specifically for array types, >> which calls reflectonHashCode on each element to compute a final hash code? >> This would solve the poster's problem and avoid polluting >> reflectionHashCode with the beha

[LANG] Thoughts on LANG-1039

2014-09-26 Thread Duncan Jones
Hi folks, I'd welcome someone else's viewpoint on LANG-1039. The question is: what should HashCodeBuilder.reflectionHashCode() do when given an array object as input. My argument is that the intended use of this method is for overriding Object.hashCode() and so it should never be the case than an

Re: [lang] Any objections to implementing LANG-1037?

2014-09-11 Thread Duncan Jones
. >> >> Agreed. >> > > I see room in Commons for a [text] component for this kind of work. > > I would -1 this change and +1 [text]. > > Gary Ok, this sounds like a better idea. Thanks for the input. > > >> >> > Gary >> >

[lang] Any objections to implementing LANG-1037?

2014-09-11 Thread Duncan Jones
Hi, I raised https://issues.apache.org/jira/browse/LANG-1037 recently, which would add support to StringUtils for joining lists of strings with a different end separator. The idea is to support use cases such as: join(["a", "b", "c"], ", ", " and ") = "a, b and c". Does anyone have any objection

[lang] Remove JDK 1.3 workaround from FieldUtils

2014-08-26 Thread Duncan Jones
Hi Benedikt, On 26 August 2014 12:53, wrote: > Author: britter > Date: Tue Aug 26 11:53:51 2014 > New Revision: 1620579 > > URL: http://svn.apache.org/r1620579 > Log: > Add fixme regarding a JDK 1.3 workaround > > Modified: > > commons/proper/lang/trunk/src/main/java/org/apache/commons/lang

[lang] Fully recursive equals methods

2014-08-07 Thread Duncan Jones
Hi folks, I'd like to implement recursive equals building [1] at some point in the near future - I've seen a few people requesting/discussing this feature on Stack Overflow. Does anyone have any objections or reservations about this feature? Kind regards, Duncan [1] https://issues.apache.org/j

Re: [ALL] Logo contest for Commons?

2014-08-01 Thread Duncan Jones
On 19 July 2014 05:04, Phil Steitz wrote: > On 7/18/14, 1:55 AM, Benedikt Ritter wrote: >> Hi all, >> >> the Apache Commons project currently does not have it's own logo! We are >> simply reusing the Apache logo with the feather. I even remember a guy from >> legal say, that they don't like it ver

Re: [lang] Any objections to LANG-1012?

2014-05-14 Thread Duncan Jones
be returning the tested object too. Duncan [1] http://piotrjagielski.com/blog/google-guava-vs-apache-commons-for-argument-validation/ > Original message From: Duncan Jones > Date:05/13/2014 16:06 (GMT-05:00) > To: Commons Developers List > Subject: [lang]

[lang] Any objections to LANG-1012?

2014-05-14 Thread Duncan Jones
Hi, Does anyone have any objections to me implementing https://issues.apache.org/jira/browse/LANG-1012? The goal is to introduce: Validate.isFalse() Validate.largerThan() // isLargerThan() ?? Validate.smallerThan() // isSmallerThan() ?? The isFalse() is just the natural counterpart to isTr

Re: [lang]

2014-05-13 Thread Duncan Jones
On 13 May 2014 02:02, Phil Steitz wrote: > > >> On May 6, 2014, at 10:51 PM, Duncan Jones wrote: >> >>> On 7 May 2014 01:52, "Paul Benedict" wrote: >>> >>> When you dereference a null pointer, you get an NPE. We can agree to that. >>

Re: Re: [lang]

2014-05-12 Thread Duncan Jones
that throws it rather than a bug > > in the code that calls it. > > > > There is nothing inherently wrong with using IAE for reporting a null > > argument. > > I think it was a mistake to suggest using NPE for that. > > One might as well throw ArithmeticExc

Re: Re: [lang]

2014-05-12 Thread Duncan Jones
the code that calls it. > >> > >> There is nothing inherently wrong with using IAE for reporting a null > >> argument. > >> I think it was a mistake to suggest using NPE for that. > >> One might as well throw ArithmeticException for a zero argumen

Re: Re: [lang]

2014-05-06 Thread Duncan Jones
On 6 May 2014 22:27, "Michael Osipov" <1983-01...@gmx.net> wrote: > > Am 2014-05-06 15:27, schrieb Benedikt Ritter: > >> Hi Thiago, >> >> >> 2014-05-06 14:53 GMT+02:00 Thiago Andrade : >> >>> Hello people, >>> >>> Analizing the JIRA issue https://issues.apache.org/jira/browse/LANG-1008the >>> contr

Re: [lang]

2014-05-06 Thread Duncan Jones
On 6 May 2014 20:41, Phil Steitz wrote: > On 5/6/14, 10:09 AM, sebb wrote: >> On 6 May 2014 14:27, Benedikt Ritter wrote: >>> Hi Thiago, >>> >>> >>> 2014-05-06 14:53 GMT+02:00 Thiago Andrade : >>> Hello people, Analizing the JIRA issue https://issues.apache.org/jira/browse/LANG-100

Re: [lang]

2014-05-06 Thread Duncan Jones
On 6 May 2014 19:19, Paul Benedict wrote: > NPE is implicit if the method does not allow an argument to be null. This > doesn't have to be the case. This has nothing to do with the JDK vs. 3rd > party source. It's just about the contract. As long as you document which > arguments can be null, then

Re: svn commit: r1588859 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java

2014-04-25 Thread Duncan Jones
On 25 April 2014 08:45, Benedikt Ritter wrote: > Nice! But you seem to have auto-formating enabled, which leads to unrelated > changes (see below). For larger changes you should enabled auto-formating > only for edited lines or make a separate reformat commit. > > Regards, > Benedikt Thanks for t

Re: [all] Dependency resolution.

2014-04-22 Thread Duncan Jones
On 22 April 2014 15:45, Duncan Jones wrote: > Hi Paul, > > On 22 April 2014 15:25, Paul Benedict wrote: >> Yup. I have depend on Lang 3 for my own code and many of my transitive >> dependencies relies on Lang 2. There's no problem with having both >> libraries i

Re: [all] Dependency resolution.

2014-04-22 Thread Duncan Jones
Hi Paul, On 22 April 2014 15:25, Paul Benedict wrote: > Yup. I have depend on Lang 3 for my own code and many of my transitive > dependencies relies on Lang 2. There's no problem with having both > libraries in your code. I haven't fully understood your description of the problem. You say you've

[lang] Rationale for multiplying by one in Conversion?

2014-04-21 Thread Duncan Jones
Hi everyone, The Conversion class has numerous instances in which a value is multiplied by one (e.g. line 1054): shift = i * 1 + dstPos; I suspect this is a copy/paste issue, since other parts of the class follow a similar pattern, e.g. line 881: shift = i * 8 + dstPos; The unit tests pass wit

Re: [LANG] Releasing 3.3.2

2014-04-03 Thread Duncan Jones
On 3 April 2014 07:39, Benedikt Ritter wrote: > Hi all, > > we have discussed this before. Thanks to Niall, all the JavaDoc issues are > now resolved, so I'm hoping to find the time this weekend to roll out an > RC. > > There is one issue that we could consider for inclusion: LANG-990 - Avoid > St

Re: svn commit: r1577332 - in /commons/proper/lang/trunk/src: changes/changes.xml main/java/org/apache/commons/lang3/time/DateUtils.java test/java/org/apache/commons/lang3/time/DateUtilsFragmentTest.j

2014-03-15 Thread Duncan Jones
On 15 Mar 2014 10:27, "Benedikt Ritter" wrote: > > 2014-03-15 11:25 GMT+01:00 Benedikt Ritter : > > > I guess this one was introduced by me when I tried to fix LANG-951 :-) > > > > The reporter doesn't seem to be amused... Does this call for a quit bug fix > release? I could prepare a RC today. M

Re: svn commit: r1568612 - in /commons/proper/lang/trunk/src: changes/ main/java/org/apache/commons/lang3/ main/java/org/apache/commons/lang3/text/translate/ test/java/org/apache/commons/lang3/

2014-02-18 Thread Duncan Jones
On 18 February 2014 15:58, Benedikt Ritter wrote: > 2014-02-18 16:28 GMT+01:00 Duncan Jones : > >> On 15 February 2014 10:35, wrote: >> > Author: britter >> > Date: Sat Feb 15 10:35:35 2014 >> > New Revision: 1568612 >> > >> > UR

Re: svn commit: r1568612 - in /commons/proper/lang/trunk/src: changes/ main/java/org/apache/commons/lang3/ main/java/org/apache/commons/lang3/text/translate/ test/java/org/apache/commons/lang3/

2014-02-18 Thread Duncan Jones
On 15 February 2014 10:35, wrote: > Author: britter > Date: Sat Feb 15 10:35:35 2014 > New Revision: 1568612 > > URL: http://svn.apache.org/r1568612 > Log: > LANG-977: NumericEntityEscaper incorrectly encodes supplementary characters. > Thanks to Chris Karcher. Chris isn't listed as a contribu

Re: [LANG] Towards 3.3

2014-02-07 Thread Duncan Jones
ork to implement some of the "missing" methods in that class. I therefore suggest that LANG-341 should be ignored for 3.3 and shouldn't hold up your plans to release. Duncan > > > 2014/1/31 Duncan Jones > >> On 31 January 2014 04:37, Henri Yandell wrote: >&

Re: svn commit: r1563259 - in /commons/proper/lang/trunk: pom.xml src/changes/changes.xml src/main/java/org/apache/commons/lang3/math/NumberUtils.java src/test/java/org/apache/commons/lang3/math/Numbe

2014-02-01 Thread Duncan Jones
On 31 January 2014 22:44, Jörg Schaible wrote: > > -1 > > Please revert, we have that already in org.apache.commons.lang3.Conversion Thanks for pointing that out. I've reverted. I agree it looks like Conversion might be a better place to put the functionality. It seems what I've added is equival

Re: [io] Addition of a TrailerInputStream class?

2014-01-31 Thread Duncan Jones
Hi Oliver, On 29 January 2014 20:25, Oliver Heger wrote: > Hi Duncan, > > Am 28.01.2014 22:18, schrieb Duncan Jones: >> Hi all, >> >> For a project of mine I developed a class named TrailerInputStream, >> which reads from an InputStream whilst retaining a buffer

Re: [LANG] Towards 3.3

2014-01-30 Thread Duncan Jones
ing probably :) >> > >> > Our license gives us a right to contributions under Apache 2.0 unless >> > stated otherwise; the ICLA is playing safer. We can also simply take >> > anything under a compatible license and include (with suitable >> licensing). >>

Re: [lang] RuntimeException types

2014-01-30 Thread Duncan Jones
On 30 Jan 2014 16:38, "Matt Benson" wrote: > > How do we feel about changing the type of a thrown RTE? Specifically, we > have agreed to standardize on the idea that Validate.notNull() throws > NullPointerException, but the recently added > FieldUtils#removeFinalModifier() method validates the in

[io] Addition of a TrailerInputStream class?

2014-01-28 Thread Duncan Jones
Hi all, For a project of mine I developed a class named TrailerInputStream, which reads from an InputStream whilst retaining a buffer of N bytes (the trailer), Once the stream has been exhausted, the final N bytes are obtained by calling the getTrailer() method. I found it helpful for reading str

[LANG] Etiquette for clearing warnings

2014-01-27 Thread Duncan Jones
Hi, Currently Eclipse is showing me 20 warnings for the lang code-base, mostly unnecessary imports and unnecessary (or missing) @SuppressWarnings statements. Is it generally acceptable to file a commit that attempts to swot a few (or all) of these in one go? And perhaps more importantly, do othe

Re: [LANG] Towards 3.3

2014-01-26 Thread Duncan Jones
On 26 January 2014 19:47, Duncan Jones wrote: > On 26 January 2014 18:49, Benedikt Ritter wrote: >> Hi Duncan, >> >> >> 2014/1/26 Duncan Jones >> >>> On 26 January 2014 13:33, Benedikt Ritter wrote: >>> > Hi all, >>> > >>

Re: [LANG] Towards 3.3

2014-01-26 Thread Duncan Jones
On 26 January 2014 18:49, Benedikt Ritter wrote: > Hi Duncan, > > > 2014/1/26 Duncan Jones > >> On 26 January 2014 13:33, Benedikt Ritter wrote: >> > Hi all, >> > >> > we've fixed some bugs and we have some nice new features implemented

Re: [LANG] Towards 3.3

2014-01-26 Thread Duncan Jones
On 26 January 2014 13:33, Benedikt Ritter wrote: > Hi all, > > we've fixed some bugs and we have some nice new features implemented > (DiffBuilder, Jaro-Winkler Distance, RandomUtils, ClassPathUtils), so I'm > planning to cut a RC in the first week of February. > > I just wanted to know if there i

Re: [ANNOUNCE] Welcome Duncan Jones, committer

2014-01-25 Thread Duncan Jones
On 25 January 2014 08:51, Thomas Neidhart wrote: > On 01/24/2014 04:20 PM, Gary Gregory wrote: >> Hi All, >> >> Please give a warm welcome to Duncan Jones, our latest committer. >> >> Welcome aboard Duncan! > > Well, you have been around for some time, but w

Re: [LANG] Handling of empty string in StringUtils

2014-01-14 Thread Duncan Jones
On 14 January 2014 11:17, Benedikt Ritter wrote: > 2014/1/13 Gary Gregory > >> On Mon, Jan 13, 2014 at 12:45 PM, sebb wrote: >> >> > What does the Javadoc say? >> > >> >> The Javadoc describes the current behavior, which is whacky IMO. This could >> be a case where the docs documents the code, e

Re: [LANG] Next steps

2014-01-02 Thread Duncan Jones
On 2 January 2014 14:40, Gary Gregory wrote: > +1 to it all. > > Gary > > Original message > From: Benedikt Ritter > Date:01/02/2014 05:29 (GMT-05:00) > To: Commons Developers List > Subject: [LANG] Next steps > > Hi all, > > I've successfully gone through my first release (w

[LANG] Snap-shot version in website header

2014-01-02 Thread Duncan Jones
Hi all, The top of the commons-lang web page reads: "Last Published: 01 January 2014 | Version: 3.3-SNAPSHOT " Shouldn't that read: "Last Published: 01 January 2014 | Version: 3.2 " ?? Or are we changing the site between releases, thus necessitating that we build a site using the current (sn

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Duncan Jones
On 23 Dec 2013 18:32, "Matt Benson" wrote: > > Bene pointed out to me that he did build w/ Java 7; of course the target > setting in the POM is the reason the classfiles are Java 6 compatible, > which is the important thing in any case. Presumably that means the Javadocs have a Java 7 style? Is t

Re: [ALL] Stack Overflow are offering free open source adverts - should we partake?

2013-12-09 Thread Duncan Jones
On 9 December 2013 11:48, Benedikt Ritter wrote: > 2013/12/9 Henri Yandell > >> On Sat, Dec 7, 2013 at 12:43 AM, Benedikt Ritter > >wrote: >> >> > >> > >> > Send from my mobile device >> > >> > > Am 06.12.2013 um 18:11 sch

Re: [ALL] Stack Overflow are offering free open source adverts - should we partake?

2013-12-06 Thread Duncan Jones
On 6 December 2013 12:51, Benedikt Ritter wrote: > 2013/12/6 Gilles > >> Hi. >> >> >> On Fri, 6 Dec 2013 12:26:57 +, Duncan Jones wrote: >> >>> Hi everyone, >>> >>> Stack Overflow allows open source projects to creat

[ALL] Stack Overflow are offering free open source adverts - should we partake?

2013-12-06 Thread Duncan Jones
Hi everyone, Stack Overflow allows open source projects to create a free advert to encourage participation in their project. The rules are clearly explained in the following post: http://meta.stackoverflow.com/questions/210389/open-source-advertising-sidebar-1h-2014. In summary, we create a 220x2

Re: [lang] ImmutablePair is final

2013-10-23 Thread Duncan Jones
On 23 Oct 2013 01:26, "Gary Gregory" wrote: > > On Tue, Oct 22, 2013 at 4:53 PM, Duncan Jones wrote: > > > On 22 October 2013 21:07, Gary Gregory wrote: > > > On Tue, Oct 22, 2013 at 3:59 PM, Matt Benson > > wrote: > > > > > >> So

Re: [lang] ImmutablePair is final

2013-10-22 Thread Duncan Jones
On 22 October 2013 21:07, Gary Gregory wrote: > On Tue, Oct 22, 2013 at 3:59 PM, Matt Benson wrote: > >> So what is having a non-generic runtime class accomplishing for you? >> > > The subclass "is a kind of" pair AND it is domain typed to my app. > > Gary Sebb is correct - composition would wor

Re: Lang: ObjectUtils

2013-07-05 Thread Duncan Jones
On 4 July 2013 19:43, Rafael Santini wrote: > Hi, > > I would like to propose a method in ObjectUtils class that receives an array > of objects and returns true if all objects are not null. I have implemented > the following: > > public static boolean isNull(Object object) { >return object ==

Re: [LANG] Method to return random byte array?

2013-06-17 Thread Duncan Jones
On 15 June 2013 14:58, Duncan Jones wrote: > On 14 June 2013 07:55, Duncan Jones wrote: >> On 13 June 2013 21:26, Phil Steitz wrote: >>> On 6/13/13 1:03 AM, Duncan Jones wrote: > >> >>> I am not sure where this little method would fit in [lang]; but it migh

Re: [LANG] Method to return random byte array?

2013-06-15 Thread Duncan Jones
what is required from Commons Lang and adds functionality that is missing from the base classes. Duncan > > > On Sat, Jun 15, 2013 at 9:58 AM, Duncan Jones wrote: > >> On 14 June 2013 07:55, Duncan Jones wrote: >> > On 13 June 2013 21:26, Phil Steitz wrote: >>

Re: [LANG] Method to return random byte array?

2013-06-15 Thread Duncan Jones
On 14 June 2013 07:55, Duncan Jones wrote: > On 13 June 2013 21:26, Phil Steitz wrote: >> On 6/13/13 1:03 AM, Duncan Jones wrote: > >> I am not sure where this little method would fit in [lang]; but it might >> make sense to add there in the simple form above (with RA

Re: [LANG] Method to return random byte array?

2013-06-13 Thread Duncan Jones
On 13 June 2013 21:26, Phil Steitz wrote: > On 6/13/13 1:03 AM, Duncan Jones wrote: >> Hi, >> >> A piece of code I write far too often is: >> >> == >> public static byte[] getRandomBytes(int length) { >> // validate length is non-neg

[LANG] Method to return random byte array?

2013-06-13 Thread Duncan Jones
Hi, A piece of code I write far too often is: == public static byte[] getRandomBytes(int length) { // validate length is non-negative byte[] result = new byte[length]; RANDOM.nextBytes(result); return result; } == Is there a place for something like this in Commons Lang? Or, bet

  1   2   >