On 3 April 2014 07:39, Benedikt Ritter <brit...@apache.org> wrote: > Hi all, > > we have discussed this before. Thanks to Niall, all the JavaDoc issues are > now resolved, so I'm hoping to find the time this weekend to roll out an > RC. > > There is one issue that we could consider for inclusion: LANG-990 - Avoid > String allocation in StrBuilder.append(CharSequence) [1]. This looks like a > nice improvement, so I'd like to include it. I've suggested to make some > performance measurments, but I won't have the time to do them myself. I'd > like to hear your opinion: do we need to measure the acutal performance > improvment or can we include it, because it looks like an improvement and > doesn't break anything?
Perhaps I'm overly cautious, but as LANG-990 is a performance tweak and not a bug fix, I'd prefer to see it subjected to some minimal performance testing before we include it. Although I agree the improvements seem fairly self-evident to the eye. I was intending to take the lead on that testing, but sadly I've not found time yet to tackle it. I would propose you cut the release without LANG-990, unless someone has time to put some metrics together. I suggested the patch author might do this to speed up the commit process [1], but so far he's not taken up the challenge. Duncan [1] https://issues.apache.org/jira/browse/LANG-990?focusedCommentId=13954637 > > Benedikt > > [1] https://issues.apache.org/jira/browse/LANG-990 > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
