Hi everyone,

The Conversion class has numerous instances in which a value is
multiplied by one (e.g. line 1054):

shift = i * 1 + dstPos;

I suspect this is a copy/paste issue, since other parts of the class
follow a similar pattern, e.g. line 881:

shift = i * 8 + dstPos;

The unit tests pass with these multiplications removed. Can anyone
suggest a reason to keep them? I'm loathe to remove something so odd
in case it has a reason for being there...

Duncan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to