Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature

/component/test_dedicate_public_ip_range.py PRE-CREATION tools/marvin/marvin/config/test_data.py ade8657 tools/marvin/marvin/lib/base.py 99a541a Diff: https://reviews.apache.org/r/23819/diff/ Testing --- Yes Thanks, Girish Shilamkar

Re: Review Request 23986: Fixed 18 Test Case failures in test_egress_fw_rules.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23986/#review51277 --- Ship it! Ship It! - Girish Shilamkar On Aug. 20, 2014, 6:36 p.m

Review Request 23819: CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature

-CREATION tools/marvin/marvin/config/test_data.py 3cd4b6c tools/marvin/marvin/lib/base.py 1a32275 Diff: https://reviews.apache.org/r/23819/diff/ Testing --- Yes Thanks, Girish Shilamkar

Re: Review Request 22955: CLOUDSTACK-6985: Re-enabling test_02_deploy_vm_root_resize

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22955/#review46721 --- Ship it! Ship It! - Girish Shilamkar On June 25, 2014, 1:32 p.m

Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/#review46530 --- Ship it! Ship It! - Girish Shilamkar On June 24, 2014, 3:04 p.m

Shrink data volume support

The specifications at [1] show that data volume shrink is only supported on KVM and that too for QCOW2 disk types. However, I see the option to shrink on VMware too. Can anybody point me to the matrix which specifies grow/shrink support per hypervisor type? Currently I am seeing "unexpected exc

Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20316/#review45925 --- Ship it! Ship It! - Girish Shilamkar On June 6, 2014, 9:40 a.m

Re: Review Request 22549: CLOUDSTACK-6887: Fixing account cleanup issue across multiple test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22549/#review45609 --- Ship it! Ship It! - Girish Shilamkar On June 13, 2014, 7:42 a.m

Re: Review Request 21905: Fixing syntax error in base library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21905/#review43920 --- Ship it! Ship It! - Girish Shilamkar On May 26, 2014, 9:13 a.m

Re: Review Request 21263: CLOODSTACK-6282: Added tests to IP Addess and divided test_escalations into individual files

+ (16:16 +0530) committer Girish Shilamkar Mon, 19 May 2014 06:15:17 + (02:15 -0400) commit ef2012677c8eb47e083a7220dfc30ac001e91567 tree069cc35e4e03d69bc910f4b358f5a7fe01fc2e1btree | snapshot parent b4ad709d321b79f532721cd65f9ecf9584d68ee6 4.4-forward

Re: Review Request 21009: Added Network API tests to test_escalation.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/#review42401 --- Could you please rebase the patch to 4.4-forward ? - Girish

Re: Review Request 19993: CLOUDSTACK-5674: Minor fixes to BVT test cases in marvin branch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19993/#review39525 --- Ship it! Ship It! - Girish Shilamkar On April 3, 2014, 12:28

Re: Review Request 17999: Added few changes for CLOUDSTACK-5674

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17999/#review35517 --- Ship it! Ship It! - Girish Shilamkar On Feb. 25, 2014, 12:24

Re: Review Request 18419: Added changes related to CLOUDSTACK-6160

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18419/#review35273 --- Ship it! Ship It! - Girish Shilamkar On Feb. 24, 2014, 10:53

Re: Review Request 18413: Added fix for CLOUDSTACK-6158

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18413/#review35270 --- Ship it! Ship It! - Girish Shilamkar On Feb. 23, 2014, 5:03 p.m

Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for Persistent Networks feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17702/#review35143 --- Ship it! Committed to master and 4.3-forward - Girish Shilamkar

Re: Review Request 18074: Added few changes for CLOUDSTACK-5674

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18074/#review34457 --- Ship it! Ship It! - Girish Shilamkar On Feb. 13, 2014, 12:57

Re: Review Request 17996: Added changes for 6082

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17996/#review34455 --- Ship it! Ship It! - Girish Shilamkar On Feb. 12, 2014, 10:47

Re: Review Request 17998: Added few changes related to 5674

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17998/#review34454 --- Ship it! Ship It! - Girish Shilamkar On Feb. 12, 2014, 10:51

Re: Review Request 18000: Added misc changes for 5674

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18000/#review34456 --- Ship it! Ship It! - Girish Shilamkar On Feb. 12, 2014, 10:56

Re: Review Request 17900: CLOUDSTACK-6066: Improved migration code to handle scenarios according to hypervisor type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17900/#review34267 --- Ship it! Committed to master and 4.3-forward - Girish Shilamkar

Re: Review Request 17847: CLOUDSTACK-5978: Changes in get_template function to make it independent of ostype passed through test case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17847/#review34055 --- Committed to 4.3-forward and master - Girish Shilamkar On Feb. 7

Re: Review Request 17841: CLOUDSTACK-5959: Fixed cascading failures in portable IP test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17841/#review34051 --- Ship it! Committed to 4.3-forward and master - Girish Shilamkar

Re: Review Request 17658: Added Few changes for CLOUDSTACK-5980

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17658/#review33578 --- Ship it! Committed to marvin branch. - Girish Shilamkar On Feb

Re: Disks in ACS Vmware

Thanks for the reply Erik. So sd[a-z] are the disks which will be added if default Centos template is used ? Regards, Girish On 31-Jan-2014, at 1:48 PM, Erik Weber wrote: > On Fri, Jan 31, 2014 at 7:46 AM, Girish Shilamkar wrote: > >> Hello, >> >> In ACS KVM the v

Re: Review Request 17533: Added changes as per CLOUDSTACK-6006

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17533/#review33567 --- Ship it! Committed to marvin branch - Girish Shilamkar On Feb

Re: Review Request 17533: Added changes as per CLOUDSTACK-6006

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17533/#review33568 --- Ship it! Committed to marvin branch - Girish Shilamkar On Feb

Re: Review Request 17535: Added few fixes for CLOUDSTACK-5973

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17535/#review33565 --- Ship it! Pushed to marvin branch - Girish Shilamkar On Jan. 30

Disks in ACS Vmware

Hello, In ACS KVM the volumes attached are seen as normal disk /dev/vda /dev/vdb and so on. But with vmware it seems Volume Groups are being used. The root device is /dev/mapper/VolGroup00-LogVol100 which previously it was /dev/hda. So now when I attach a new datadisk to vm running on vmware wha

Re: master not building

I still see problems with latest master while building marvin. Not sure if this is also related checkstyle [root@pun-lsfs21-node02 cloudstack]# /usr/local/apache-maven-3.1.1/bin/mvn -P developer -e -pl :cloud-marvin [INFO] Error stacktraces are turned on. [INFO] Scanning for projects... [INFO]

Re: Review Request 17452: Added Fi for CLOUDSTACK-5963

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17452/#review33100 --- Merged to marvin branch - Girish Shilamkar On Jan. 28, 2014, 10

Re: Review Request 17452: Added Fi for CLOUDSTACK-5963

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17452/#review33099 --- Ship it! Ship It! - Girish Shilamkar On Jan. 28, 2014, 10:47

Re: Review Request 17447: Fix for CLOUDSTACK-5948

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17447/#review33098 --- Ship it! Merged to marvin branch. - Girish Shilamkar On Jan. 28

Re: Review Request 17116: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500( Fixed Few issues in patch 17113 )

will need a patch which will apply on top of 17113. Could you please fetch the marvin branch and create the patch. Thanks, Girish - Girish Shilamkar On Jan. 20, 2014, 9:26 a.m., Santhosh Edukulla wrote: > > --- > This is an auto

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

please post a patch on top of the old one ? Regards, Girish - Girish Shilamkar On Jan. 20, 2014, 8:42 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 17113: Phase1 Marvin Changes.Fix-for-CLOUDSTACK-5674, 5498, 5500

in discrete functional units. So that it is easier to review the change. Thanks ! - Girish Shilamkar On Jan. 20, 2014, 6:36 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 15746: Service Offering being created without host tags due to mismatch with base for test_vpc_vm_life_cycle.py.

> On Nov. 26, 2013, 8:17 a.m., Girish Shilamkar wrote: > > Ship It! Parth, Could you please close this item. Thanks, Girish - Girish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test cases for security group in advanced zone feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16178/#review31716 --- Ship it! Ship It! - Girish Shilamkar On Jan. 14, 2014, 8:51 a.m

Re: Review Request 16737: CLOUDSTACK-5619: Egress Firewall rules - Increased timeout for router to come up

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16737/#review31371 --- Ship it! Committed to 4.3 and master - Girish Shilamkar On Jan

Re: Review Request 16684: CLOUDSTACK-5802: Increased timeout for template state to become ready, improved assertion messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16684/#review31364 --- Ship it! Committed to 4.3 and master - Girish Shilamkar On Jan

Re: Review Request 16733: CLOUDSTACK-5630: Fixed snapshots' test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16733/#review31361 --- Ship it! Committed to 4.3 and master - Girish Shilamkar On Jan

Re: CreateVPCOffering API without SourceNat service

Thanks a lot Alena ! Regards, Girish On 07-Jan-2014, at 10:58 PM, Alena Prokharchyk wrote: > Yes, it does as sourceNat is required service for VPC > > -Alena. > > From: Girish Shilamkar > Reply-To: "dev@cloudstack.apache.org" > Date: Tuesday, Januar

Re: Review Request 16684: CLOUDSTACK-5802: Increased timeout for template state to become ready, improved assertion messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16684/#review31345 --- Ship it! Committed to 4.3 and master - Girish Shilamkar On Jan

Re: Review Request 16683: CLOUDSTACK-5805: Increasing timeout period for VM to come to running state

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16683/#review31341 --- Ship it! Committed to 4.3 and master - Girish Shilamkar On Jan

CreateVPCOffering API without SourceNat service

Hello,Does createVPCOffering API by default creates VPC with SourceNat service even if it is not specified in API ?I tried this out where Services  = {DHPC, DNS, PF, VPN, LB, UserData and StaticNat} and called createVPCOffering API. But the API created VPC with SourceNat service even though it was

httpd server in vms

Hello, Is it safe to assume that whenever a vm instance is created in Cloudstack with default Centos template, httpd server will running once the vm has booted ? On Xen I see that Apache http server is not installed. And therefore some of regression tests fail as they use http server. Regards,

Re: Review Request 16570: CLOUDSTACK-5185: Fixed test script related to cleanup in test_egress_fw_rules.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16570/#review31112 --- Ship it! Committed to 4.3 and master - Girish Shilamkar On Jan

Re: Review Request 16568: CLOUDSTACK-5633: Fixed network cleanup issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16568/#review31110 --- Ship it! Committed to 4.3 and master. - Girish Shilamkar On Jan

Re: Review Request 16541: CLOUDSTACK-5636: Fixed issue 'Failed to upgrade network offering' in test_vpc_network test suite

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16541/#review31021 --- Ship it! Committed to 4.3 and master. - Girish Shilamkar On Dec

Re: Migrating a ROOT volume

; > -Original Message- > From: Girish Shilamkar [mailto:gir...@clogeny.com] > Sent: Tuesday, December 31, 2013 11:40 AM > To: dev@cloudstack.apache.org > Subject: Migrating a ROOT volume > > Hello, > > As per CS admin guide ROOT volume can be migrated. But in UI I

Migrating a ROOT volume

Hello, As per CS admin guide ROOT volume can be migrated. But in UI I don't see an option to detach disk from a stopped disk. And if I try to detach using API, it fails stating "please specify a datadisk" Can someone please clarify. Regards, Girish

Re: Review Request 16513: CLOUDSTACK-5635: Fixed issue (Max volumes has been exceeded for domain during test) in test_resource_limits.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16513/#review30961 --- Committed to 4.3 and master - Girish Shilamkar On Dec. 30, 2013

Re: Review Request 16513: CLOUDSTACK-5635: Fixed issue (Max volumes has been exceeded for domain during test) in test_resource_limits.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16513/#review30959 --- Ship it! Ship It! - Girish Shilamkar On Dec. 30, 2013, 12:23

Re: Review Request 16513: CLOUDSTACK-5635: Fixed issue (Max volumes has been exceeded for domain during test) in test_resource_limits.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16513/#review30957 --- Ship it! Ship It! - Girish Shilamkar On Dec. 30, 2013, 12:23

Re: Review Request 16513: CLOUDSTACK-5635: Fixed issue (Max volumes has been exceeded for domain during test) in test_resource_limits.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16513/#review30960 --- Ship it! Ship It! - Girish Shilamkar On Dec. 30, 2013, 12:23

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16481/#review30948 --- Ship it! Committed to 4.3 and master. - Girish Shilamkar On Dec

Re: Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16481/#review30934 --- Ship it! Commited to 4.3 and master - Girish Shilamkar On Dec

Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test cases for security group in advanced zone feature

.org/r/16178/ > --- > > (Updated Dec. 16, 2013, 10:01 a.m.) > > > Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-2237 > https://issues.apache.org/jira/browse/CLOUDSTACK-2237 > >

Re: Review Request 16467: CLOUDSTACK-5638: Fixed code to check router state

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16467/#review30901 --- Ship it! Committed to 4.3 and master. - Girish Shilamkar On Dec

Re: Review Request 16386: CLOUDSTACK-5518: Fixing non contiguous vlan test case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16386/#review30818 --- Ship it! Committed to 4.3 and master - Girish Shilamkar On Dec

Re: Review Request 16324: CLOUDSTACK-4780: Changes related to checking snapshot on NFS server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16324/#review30816 --- Ship it! Committed to 4.3 and master - Girish Shilamkar On Dec

Re: Review Request 16386: CLOUDSTACK-5518: Fixing non contiguous vlan test case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16386/#review30817 --- Ship it! Ship It! - Girish Shilamkar On Dec. 19, 2013, 3:34 p.m

Re: Review Request 16240: CLOUDSTACK-5487: Fixing indentation issues in test_portable_ip

change. - Girish Shilamkar On Dec. 13, 2013, 6:02 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 16177: Fixed CLOUDSTACK-5443

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16177/#review30261 --- Ship it! Committed to 4.2, 4.3 and marvin. - Girish Shilamkar

Re: Review Request 16086: Added a temp sleep fix for vm start command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16086/#review30181 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar

Re: Review Request 16085: Fixed an Issue reported by xen server team

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16085/#review30179 --- Ship it! Merged to 4.2-forward branch only. - Girish Shilamkar

Re: Review Request 16127: Fixed CLOUDSTACK-5411

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16127/#review30009 --- Ship it! COmmitted to 4.2, 4.3 and master. - Girish Shilamkar

Re: Review Request 16121: Added Fix for CLOUDSTACK-5269, CLOUDSTACK-5378

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16121/#review30006 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 16120: Fixed-CLOUDSTACK-5411

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16120/#review30002 --- Ship it! Pushed to 4.2, 4.3 and master. - Girish Shilamkar On

Re: Template not in ready state

The problem is fixed. The CS was setup to use internal webserver for downloading the template and it was running. Regards, Girish On 09-Dec-2013, at 2:54 PM, Rafael Weingartner wrote: > What states are the templates in ? > > > 2013/12/9 Girish Shilamkar > >> Tallur

Re: Template not in ready state

VM,+templates,+Se >> c >> ondary+storage+troubleshooting >> >> >> ~Talluri >> >> On 07/12/13 4:07 pm, "Girish Shilamkar" wrote: >> >>> Hello, >>> >>> I am trying to get a CS setup up, zones etc are setup. But templ

Template not in ready state

Hello, I am trying to get a CS setup up, zones etc are setup. But templates are not in ready state. I tried various things like: - Checking agent status - Running ssvm health check - Checked ssvm logs for errors, nothing useful In db template_host_ref is empty. But I can see templates listed in

Re: Review Request 15922: Enhanced few features under Marvin

Fixed in 4.2, 4.3 and master. Regards, Girish On 07-Dec-2013, at 12:47 PM, Girish Shilamkar wrote: > Mea culpa. I will push the missed out files. > > Regards, > Girish > > On 07-Dec-2013, at 12:34 PM, Santhosh Edukulla > wrote: > >> I was thinking that it wa

Re: Review Request 15922: Enhanced few features under Marvin

amstev...@gmail.com] on behalf of Will > Stevens [wstev...@cloudops.com] > Sent: Saturday, December 07, 2013 12:24 AM > To: Santhosh Edukulla > Cc: dev@cloudstack.apache.org; Girish Shilamkar > Subject: Re: Review Request 15922: Enhanced few features under Marvin > > If you l

Re: Review Request 15922: Enhanced few features under Marvin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15922/#review29875 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar

Re: Review Request 16036: CLOUDSTACK-5377: Fixed test case dependency issue in snapshots test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16036/#review29802 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar

Re: Review Request 15999: CLOUDSTACK-5364: Resolving network cleanup issue in egress fw rules test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15999/#review29728 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/#review29720 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar

Re: Review Request 15963: CLOUDSTACK-5347: Resolved issue related to snapshot state

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/#review29714 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar

Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29709 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar

Re: Review Request 15962: CLOUDSTACK-5346: Fixed shared network cleanup issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/#review29705 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Deleting Primary Storage, where host was removed.

Hello, In my test ACS setup I am stuck due to this problem https://issues.apache.org/jira/browse/CLOUDSTACK-4402 where I cannot delete primary storage, as the last host with which it was associated was removed. Is there a workaround for this issue ? Like deleting the entries from database. Ple

Re: Review Request 15746: Service Offering being created without host tags due to mismatch with base for test_vpc_vm_life_cycle.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15746/#review29426 --- Ship it! Ship It! - Girish Shilamkar On Nov. 21, 2013, 1:28 a.m

Re: Review Request 15833: CLOUDSTACK-5257: Fixed Network ACL issue related to Egress traffic

Ok, I will merge it to 4.2 as well. Regards, Girish On 26-Nov-2013, at 12:33 PM, Santhosh Edukulla wrote: > But, its better to merge when tests are run in future for that branch as > well. > > Santhosh > ____ > From: Girish Shilamkar [

Re: Review Request 15833: CLOUDSTACK-5257: Fixed Network ACL issue related to Egress traffic

Santhosh > ____ > From: Girish Shilamkar [nore...@reviews.apache.org] on behalf of Girish > Shilamkar [gir...@clogeny.com] > Sent: Tuesday, November 26, 2013 1:41 AM > To: Girish Shilamkar; Srikanteswararao Talluri > Cc: Ashutosh Kelkar; cloudstack > Subject: Re: Review Request

Re: Review Request 15833: CLOUDSTACK-5257: Fixed Network ACL issue related to Egress traffic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15833/#review29422 --- Ship it! Committed to 4.3 and master. - Girish Shilamkar On Nov

Re: Review Request 15668: CLOUDSTACK-5201: Corrected code related to schedule of recurring snapshot policy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15668/#review29220 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar

Re: Review Request 15672: CLOUDSTACK-5204: test_routers - fixed ssh issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15672/#review29216 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15715: CLOUDSTACK-5215: Correcting and refactoring code related to getting free vlan

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15715/#review29212 --- Ship it! Committed to 4.2, 4.2 and master - Girish Shilamkar On

Re: Review Request 15645: CLOUDSTACK-5194: portable ip - Improving cleanup code to avoid cascading failures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15645/#review29101 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15611: CLOUDSTACK-5186: Increasing the waiting time for router to come up

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15611/#review29015 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the test case if vm deployment failed instead of going on executing rest of the test case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15610/#review29011 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15610: CLOUDSTACK-5185: test_egress_fw_rules - failed the test case if vm deployment failed instead of going on executing rest of the test case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15610/#review29010 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15569: CLOUDSTACK-5179: Fixed test script issue related to detach volume

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15569/#review28963 --- Ship it! COmmitted to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15452: CLOUDSTACK-5147: Removing basic and sg tags from test case which is invalid for basic zone

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15452/#review28958 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15570: CLOUDSTACK-5180: Increasing the timeout for uploading volume

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15570/#review28954 --- Ship it! COmmitted to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15516: CLOUDSTACK-5169: Egress rules - Improved assertion code related to SSH to avoid assertion error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15516/#review28944 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15514: CLOUDSTACK-5168: Fixed test script issue related to SSH command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15514/#review28940 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On

Re: Review Request 15513: CLOUDSTACK-5166: Fixed test script issue related to egress rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15513/#review28937 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar

Re: Review Request 15513: CLOUDSTACK-5166: Fixed test script issue related to egress rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15513/#review28935 --- Ship it! Ship It! - Girish Shilamkar On Nov. 14, 2013, 11:46

  1   2   3   >