----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15610/#review29010 -----------------------------------------------------------
Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On Nov. 16, 2013, 9:23 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15610/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2013, 9:23 a.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5185 > https://issues.apache.org/jira/browse/CLOUDSTACK-5185 > > > Repository: cloudstack-git > > > Description > ------- > > Few test cases from suite test_egress_fw_rules failed due to > 'TestEgressFWRules' object has no attribute 'virtual_machine'. > This issue arises when VM deployment has already failed in previous step. > > Test case should fail if VM deployment fails which could happen if there is > setup issue. (Insufficient server capacity.) > > This change will indicate proper reason for test case failure. > > > Diffs > ----- > > test/integration/component/test_egress_fw_rules.py 0aed957 > > Diff: https://reviews.apache.org/r/15610/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
