----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29709 -----------------------------------------------------------
Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15942/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2013, 2:57 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5333 > https://issues.apache.org/jira/browse/CLOUDSTACK-5333 > > > Repository: cloudstack-git > > > Description > ------- > > test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project > was failing with error "Check Snapshot state is Running or not". > The snapshot state does not really matter here, as we are checking the > limits. Instead of checking the snapshot state from all the possible options, > just list the snapshots under the project and check if exactly one snapshot > exists. > > > Diffs > ----- > > test/integration/component/test_project_limits.py c497311 > > Diff: https://reviews.apache.org/r/15942/diff/ > > > Testing > ------- > > Tested locally on XenServer advanced setup. > > Log: > test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) > Test Limit number of guest account specific networks ... skipped 'skip' > test_01_project_limits (test_project_limits_fixed.TestProjectLimits) > Test project limits for domain admin ... skipped 'skip' > test_02_project_limits_normal_user > (test_project_limits_fixed.TestProjectLimits) > Test project limits for normal user ... skipped 'skip' > test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) > Test VM limit per project ... skipped 'Skip' > test_04_publicip_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Public IP limit per project ... skipped 'Skip' > test_05_snapshots_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Snapshot limit per project ... ok > test_06_volumes_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Volumes limit per project ... skipped 'Skip' > test_07_templates_per_project > (test_project_limits_fixed.TestResourceLimitsProject) > Test Templates limit per project ... skipped 'Skip' > > ---------------------------------------------------------------------- > Ran 8 tests in 360.690s > > OK (skipped=7) > > > Thanks, > > Gaurav Aradhye > >
