----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15514/#review28940 -----------------------------------------------------------
Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On Nov. 14, 2013, 12:21 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15514/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 12:21 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5168 > https://issues.apache.org/jira/browse/CLOUDSTACK-5168 > > > Repository: cloudstack-git > > > Description > ------- > > test_egress_rules.TestRevokeEgressRule.test_revoke_egress_rule > This test case fails die to assertion error. > Ping to outside world should be allowed when egress rule is present and it > should not be allowed after revoking to egress rule. The code related to this > was interchanged before. > Fixed the test script issues. > > This test case will still fail due to product bug filed --> > https://issues.apache.org/jira/browse/CLOUDSTACK-5167 > > > Diffs > ----- > > test/integration/component/test_egress_rules.py 34995ff > > Diff: https://reviews.apache.org/r/15514/diff/ > > > Testing > ------- > > Tested locally on Xenserver Basic Zone setup > > > Thanks, > > Ashutosh Kelkar > >
