----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17841/#review34051 -----------------------------------------------------------
Ship it! Committed to 4.3-forward and master - Girish Shilamkar On Feb. 7, 2014, 10:56 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17841/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 10:56 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5959 > https://issues.apache.org/jira/browse/CLOUDSTACK-5959 > > > Repository: cloudstack-git > > > Description > ------- > > Failure in firewall creation is leading to incomplete cleanup and eventually > cascading failure of the test cases. > Made changes so that even in case of failure in one test case, other test > cases are not affected and cleanup is performed gracefully. > > Also did > 1) Code cleanup > 2) Modifying imports > 3) Adding FS and test plan links > 4) Refactoring code > > > Diffs > ----- > > test/integration/component/test_portable_ip.py d397ec4 > tools/marvin/marvin/integration/lib/common.py 550de1a > > Diff: https://reviews.apache.org/r/17841/diff/ > > > Testing > ------- > > Tested on VMware > > > Thanks, > > Gaurav Aradhye > >
