----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16568/#review31110 -----------------------------------------------------------
Ship it! Committed to 4.3 and master. - Girish Shilamkar On Jan. 2, 2014, 10:52 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16568/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 10:52 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5633 > https://issues.apache.org/jira/browse/CLOUDSTACK-5633 > > > Repository: cloudstack-git > > > Description > ------- > > Network has been added twice in the cleanup list which leads to failure. > > Changes: > 1) Remove the extra entry of network in cleanup list. > 2) Add Domain to cleanup list (was missing) instead of service offering > belonging to domain (which will be automatically removed when domain is > removed) > > > Diffs > ----- > > test/integration/component/test_project_resources.py 1838269 > > Diff: https://reviews.apache.org/r/16568/diff/ > > > Testing > ------- > > Tested locally. > > Log: > test_03_network_create (test_project_resources_fixed.TestNetwork) > Test create network in project ... ok > test_01_service_offerings (test_project_resources_fixed.TestOfferings) > Test service offerings in a project ... skipped 'skip' > test_02_project_disk_offerings (test_project_resources_fixed.TestOfferings) > Test project disk offerings ... skipped 'skip' > test_07_associate_public_ip (test_project_resources_fixed.TestPublicIpAddress) > Test associate public IP within the project ... skipped 'skip' > test_08_security_group (test_project_resources_fixed.TestSecurityGroup) > Test security groups in project ... skipped 'skip' > test_06_create_snapshots_in_project > (test_project_resources_fixed.TestSnapshots) > Test create snapshots in project ... skipped 'skip' > test_04_public_template_use_in_project > (test_project_resources_fixed.TestTemplates) > Test Templates creation in projects ... skipped 'skip' > test_05_use_private_template_in_project > (test_project_resources_fixed.TestTemplates) > Test use of private template in a project ... skipped 'skip' > > ---------------------------------------------------------------------- > Ran 8 tests in 452.545s > > OK (skipped=7) > > > Thanks, > > Gaurav Aradhye > >
