----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17535/#review33565 -----------------------------------------------------------
Ship it! Pushed to marvin branch - Girish Shilamkar On Jan. 30, 2014, 1:14 p.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17535/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 1:14 p.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5973 > https://issues.apache.org/jira/browse/CLOUDSTACK-5973 > > > Repository: cloudstack-git > > > Description > ------- > > Added the below changes to topic branch. > 1. Disabled network offering before delete, we followed this in few cases and > missed at a case. > 2. Removed few deletes for network. > 3. The log messages at place seems to out of context for with, leads to > exception,added that. > 4. Fixed an and issue. Added few exception levels and to sshClient > > > Diffs > ----- > > test/integration/component/test_add_remove_network.py 6eef71e > tools/marvin/marvin/sshClient.py 588c978 > > Diff: https://reviews.apache.org/r/17535/diff/ > > > Testing > ------- > > Tested pep8 for sshClient and python import for both. Will test on topic > branch post other changes. > > > Thanks, > > Santhosh Edukulla > >
