----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17447/#review33098 -----------------------------------------------------------
Ship it! Merged to marvin branch. - Girish Shilamkar On Jan. 28, 2014, 8:34 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17447/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 8:34 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5948 > https://issues.apache.org/jira/browse/CLOUDSTACK-5948 > > > Repository: cloudstack-git > > > Description > ------- > > Fixed the issue 5948 > 1. Added a generic way of verifying isk volumes. > 2. Now, detach volume is called post the assert. > 3. Added a sleep post detach volume to facilitate list volumes to have some > time for detach operation. > 4. Added a fix for a log check. > > > Diffs > ----- > > test/integration/smoke/test_volumes.py 8f41803 > tools/marvin/marvin/integration/lib/utils.py e870158 > tools/marvin/marvin/marvinInit.py 36d907e > tools/marvin/marvin/sshClient.py fd8726c > > Diff: https://reviews.apache.org/r/17447/diff/ > > > Testing > ------- > > 1. Testing on separate topic branch will be done post other fixes. > 2. Verified the script for any import errors. > > > Thanks, > > Santhosh Edukulla > >
