On Thu, 5 Dec 2024 03:08:36 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Thu, 5 Dec 2024 03:08:36 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initialized by VM with
> value set at build time, and then l
On Wed, 4 Dec 2024 19:00:33 GMT, Henry Jen wrote:
>> In fact, VM no longer sets this property. This should be updated to simply
>> do `props.put`.
>
> It is just for compatibility with other VM implementation. We don't set the
> property in hotspot with this PR.
Is it part of the implementat
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 18:27:45 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/VersionProps.java.template line 128:
>>
>>> 126:
>>> 127: // In case VM is not yet set this property
>>> 128: props.putIfAbsent("java.vm.vendor", VENDOR_VM);
>>
>> Can this system prope
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 18:24:26 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up adapting review comments
>
> src/java.base/share/classes/java/lang/VersionProps.java.template line 128:
>
>> 126:
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 18:03:42 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up adapting review comments
>
> make/autoconf/spec.gmk.template line 276:
>
>> 274:
>> 275: ifneq ($(COMPANY_NAME),
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initialized by VM with
> value set at build time, and then l
On Wed, 4 Dec 2024 06:15:56 GMT, Henry Jen wrote:
>> Or are you assuming/expecting the VersionProps value is null unless being
>> overridden? You could initialize the VersionProps value to be the same as
>> what VENDOR is at build time and always use it to set the
>> Abstract_VM_Version field
On Wed, 4 Dec 2024 06:04:09 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/abstract_vm_version.cpp line 132:
>>
>>> 130:
>>> 131: static const char vm_vendor_string[sizeof(VENDOR) < VENDOR_PADDING ?
>>> VENDOR_PADDING : sizeof(VENDOR)] = VENDOR;
>>> 132: const char* Abstract_VM_Version:
On Wed, 4 Dec 2024 05:59:31 GMT, David Holmes wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Set java.vm.vendor from VersionProps.java
>
> src/hotspot/share/runtime/abstract_vm_version.cpp line 132:
>
>> 130:
>> 13
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initialized by VM with
> value set at build time, and then l
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initialized by VM with
> value set at build time, and then l
On Tue, 3 Dec 2024 17:01:06 GMT, Severin Gehwolf wrote:
>> I think the issue is not the default value, but the special treatment with
>> default value. Is there a reason we didn't set COMPANY_NAME to "N/A" as in
>> branding.conf?
>> https://github.com/openjdk/jdk/blame/master/make/autoconf/spec
On Tue, 3 Dec 2024 16:29:52 GMT, Henry Jen wrote:
> Instead of default to "N/A", personally I think "OpenJDK" as an organization
> can be used?
OpenJDK is a source only distribution. As such vendor being set to OpenJDK for
the binary doesn't make sense. It's the downstream distro shipping the
On Tue, 3 Dec 2024 14:28:22 GMT, Magnus Ihse Bursie wrote:
>> src/java.base/share/classes/java/lang/VersionProps.java.template line 131:
>>
>>> 129: // Default branding.conf value is "N/A", which did not affect
>>> java.vm.vendor
>>> 130: if (! VENDOR_VM.equals("N/A")) {
>>> 131
On Mon, 2 Dec 2024 18:40:58 GMT, Alan Bateman wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was i
On Mon, 2 Dec 2024 19:59:51 GMT, David Holmes wrote:
>> I agree. This is to minimize change on behavior.
>>
>> Not sure what kind of requirement is there for java.vm.vendor, would it be
>> OK for VM not the set this value and wait until loading of VersionProps
>> class?
>>
>> The update is n
On Mon, 2 Dec 2024 19:52:36 GMT, David Holmes wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was i
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Mon, 2 Dec 2024 18:53:12 GMT, Henry Jen wrote:
>> src/hotspot/share/runtime/threads.cpp line 654:
>>
>>> 652: initialize_java_lang_classes(main_thread, CHECK_JNI_ERR);
>>> 653: // Update the java.vm.vendor property with
>>> java.lang.VersionProps.VM_VENDOR
>>> 654: Arguments::update_vm
On Mon, 2 Dec 2024 18:34:49 GMT, Alan Bateman wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was i
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
Add jlink plugins to allow branding change for java.vendor, java.vm.vendor and
java.vendor.url.
The jlink plugin will change the value in java.lang.VersionProps, which will
set those property values. The `java.vm.vendor` was initialized by VM with
value set at build time, and then later be repl
35 matches
Mail list logo
