On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen <henry...@openjdk.org> wrote:

>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor 
>> and java.vendor.url.
>> 
>> The jlink plugin will change the value in java.lang.VersionProps, which will 
>> set those property values. The `java.vm.vendor` was initialized by VM with 
>> value set at build time, and then later be replaced with value from 
>> VersionProps.
>> 
>> To keep current behavior, we treat 'N/A' value as no-op to mimic current 
>> build behavior. Perhaps we don't really need this, as proper value should be 
>> set with `branding.conf` in official build.
>
> Henry Jen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Clean up adapting review comments

The copyright headers need to be updated.  `@bug` in VendorInfoPluginsTest.java 
should also be updated.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21964#pullrequestreview-2479666243

Reply via email to