On Thu, 5 Dec 2024 03:08:36 GMT, Henry Jen <henry...@openjdk.org> wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor >> and java.vendor.url. >> >> The jlink plugin will change the value in java.lang.VersionProps, which will >> set those property values. The `java.vm.vendor` was initialized by VM with >> value set at build time, and then later be replaced with value from >> VersionProps. >> >> To keep current behavior, we treat 'N/A' value as no-op to mimic current >> build behavior. Perhaps we don't really need this, as proper value should be >> set with `branding.conf` in official build. > > Henry Jen has updated the pull request incrementally with one additional > commit since the last revision: > > Adapt review feedback Update ebed0185 looks okay, much cleaner now. src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties line 262: > 260: vendor-vm.description=\ > 261: Override the vendor string baked into the build, if any.\n\ > 262: The value of the system property "java.vm.vendor" will be <vendor>. This is a copy of vendor.description, I assume it should be adjusted to say vendor VM. Same comment in vendor-vm.usage. test/jdk/tools/jlink/plugins/VendorInfoPluginsTest.java line 2: > 1: /* > 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. This should be "2019, 2014," Also you can bump the date on the module-info.java. ------------- PR Review: https://git.openjdk.org/jdk/pull/21964#pullrequestreview-2481502468 PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1871266352 PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1871267713
