On Thu, 5 Dec 2024 03:08:36 GMT, Henry Jen <henry...@openjdk.org> wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor >> and java.vendor.url. >> >> The jlink plugin will change the value in java.lang.VersionProps, which will >> set those property values. The `java.vm.vendor` was initialized by VM with >> value set at build time, and then later be replaced with value from >> VersionProps. >> >> To keep current behavior, we treat 'N/A' value as no-op to mimic current >> build behavior. Perhaps we don't really need this, as proper value should be >> set with `branding.conf` in official build. > > Henry Jen has updated the pull request incrementally with one additional > commit since the last revision: > > Adapt review feedback Need to bump the copyright end year of VersionProps.java.template, plugins.properties and module-info.java src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties line 262: > 260: vendor-vm.description=\ > 261: Override the vendor string baked into the build, if any.\n\ > 262: The value of the system property "java.vm.vendor" will be <vendor>. Suggestion: Override the vendor VM string baked into the build, if any.\n\ The value of the system property "java.vm.vendor" will be <vendor-vm>. src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties line 268: > 266: \ Override the vendor string baked into the > build,\n\ > 267: \ if any. The value of the system property\n\ > 268: \ "java.vm.vendor" will be <vendor>. Suggestion: \ --vendor-vm <vendor-vm>\n\ \ Override the vendor VM string baked into the build,\n\ \ if any. The value of the system property\n\ \ "java.vm.vendor" will be <vendor-vm>. ------------- PR Review: https://git.openjdk.org/jdk/pull/21964#pullrequestreview-2482487949 PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1871848891 PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1871850330
