On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen <henry...@openjdk.org> wrote:

> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor 
> and java.vendor.url.
> 
> The jlink plugin will change the value in java.lang.VersionProps, which will 
> set those property values. The `java.vm.vendor` was initialized by VM with 
> value set at build time, and then later be replaced with value from 
> VersionProps.
> 
> To keep current behavior, we treat 'N/A' value as no-op to mimic current 
> build behavior. Perhaps we don't really need this, as proper value should be 
> set with `branding.conf` in official build.

I think it's cleaner to explore defining the VM related branding configuration 
`make/conf/branding.conf` where the OpenJDK value of system properties in 
VersionProps.java.template are defined.    One idea is to add .template file in 
`src/hotspot` that the build can patch the values before starting building VM 
so that it will not depend on VersionProps class to be loaded.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21964#issuecomment-2512713166

Reply via email to