Re: [I] [FEATURE] CAN and CAN FD bittiming/bitrate calculation consolidation and CAN drivers updates goals [nuttx]

2025-01-29 Thread via GitHub
acassis commented on issue #15567: URL: https://github.com/apache/nuttx/issues/15567#issuecomment-2621809903 Hi Pavel, I think this is a great achievement! Kudos to @michallenc and you for working to integrate it on RTEMS. I hope it be integrated on NuttX as well! -- This is an automat

[PR] examples:hello_nim: fix comment syntax [nuttx-apps]

2025-01-29 Thread via GitHub
kubo39 opened a new pull request, #2981: URL: https://github.com/apache/nuttx-apps/pull/2981 ## Summary The comment syntax of hello_nim example is wrong and fixed. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Mpfs ddr training refinement [nuttx]

2025-01-29 Thread via GitHub
acassis commented on PR #15714: URL: https://github.com/apache/nuttx/pull/15714#issuecomment-2621840259 @jlaitine there is an issue: Configuring... Building NuttX... ./chip/mpfs_start.c:40:10: fatal error: hardware/mpfs_wdog.h: No such file or directory 40 | #include "

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2621399977 > > 4. sched/spinlock: removed the semantics of disable preemption from default spin_lock > > > > In the RTOS environment, spin_lock is simplified as much as possible to improve per

[I] [BUG] Make: sim:quickjs fails to build [nuttx]

2025-01-29 Thread via GitHub
simbit18 opened a new issue, #15712: URL: https://github.com/apache/nuttx/issues/15712 ### Description / Steps to reproduce the issue sim:quickjs Cmake is ok while Make fails to build with this Error: LN: platform/board to /github/workspace/sources/apps/platform/dummy Downloa

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on code in PR #15705: URL: https://github.com/apache/nuttx/pull/15705#discussion_r1933724025 ## fs/inode/fs_files.c: ## @@ -72,9 +72,9 @@ static FAR struct file *files_fget_by_index(FAR struct filelist *list, FAR struct file *filep; irqstate_t flags; -

Re: [I] website is not mobile friendly [nuttx-website]

2025-01-29 Thread via GitHub
adityalaxkar123 closed issue #128: website is not mobile friendly URL: https://github.com/apache/nuttx-website/issues/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] [BUG] check_esptool.py does not find esptool if it was installed with pipx [nuttx]

2025-01-29 Thread via GitHub
fdcavalcanti commented on issue #15690: URL: https://github.com/apache/nuttx/issues/15690#issuecomment-2621298898 Try "which pip" on your terminal. See if it shows two pip installations. If it shows more than one, I recommend you uninstall the `esptool 4.7.0` since it is outdated anyway.

[PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
occam25 opened a new pull request, #15715: URL: https://github.com/apache/nuttx/pull/15715 ## Summary Add support for network statistics for CAN. It includes counters for receive, sent and drop frames. ## Testing Tested using a Ubuntu 22.04 as a host and a stm32h7 cust

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on code in PR #15705: URL: https://github.com/apache/nuttx/pull/15705#discussion_r1933726046 ## include/nuttx/spinlock.h: ## @@ -278,8 +278,6 @@ spin_lock_nopreempt(FAR volatile spinlock_t *lock) #ifdef CONFIG_SPINLOCK static inline_function void spin_lock(FAR

Re: [PR] arch/risc-v/src/mpfs/mpfs_cache.c: Move l2zerodevice to use cache ways starting from 0 [nuttx]

2025-01-29 Thread via GitHub
nuttxpr commented on PR #15713: URL: https://github.com/apache/nuttx/pull/15713#issuecomment-2621748034 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

Re: [PR] Mpfs ddr training refinement [nuttx]

2025-01-29 Thread via GitHub
nuttxpr commented on PR #15714: URL: https://github.com/apache/nuttx/pull/15714#issuecomment-2621744778 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, th

Re: [I] [FEATURE] CAN and CAN FD bittiming/bitrate calculation consolidation and CAN drivers updates goals [nuttx]

2025-01-29 Thread via GitHub
ppisa commented on issue #15567: URL: https://github.com/apache/nuttx/issues/15567#issuecomment-2621160125 For your information (@raiden00pl, @acassis, @radek-pesina, @tmedicci ), the CAN FD stack developed for RTEMS by @michallenc has undergone [review](https://gitlab.rtems.org/rtems/rtos/

Re: [PR] arm: Support hardware debugging of ARM architecture [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 commented on code in PR #15616: URL: https://github.com/apache/nuttx/pull/15616#discussion_r1933783197 ## arch/arm/src/armv7-a/arm_hwdebug.c: ## @@ -0,0 +1,627 @@ +/ + * arch/arm/src/armv

[PR] Mpfs ddr training refinement [nuttx]

2025-01-29 Thread via GitHub
jlaitine opened a new pull request, #15714: URL: https://github.com/apache/nuttx/pull/15714 ## Summary Refining MPFS DDR training error handling - Reset with WDT after completely failed training to avoid leaving "soft reset" status in the boot reason register - Avoid unneces

[PR] arch/risc-v/src/mpfs/mpfs_cache.c: Move l2zerodevice to use cache ways starting from 0 [nuttx]

2025-01-29 Thread via GitHub
jlaitine opened a new pull request, #15713: URL: https://github.com/apache/nuttx/pull/15713 ## Summary We recently found out that it is possible to get memory corruption in scratchpad memory area (0x0a00 ->) by writes to DRAM (0xa000). The memory corruption looks as if th

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2622074717 > > https://docs.kernel.org/locking/locktypes.html contain the detailed information, here is the keypoint: https://private-user-images.githubusercontent.com/18066964/407624628-9c33

Re: [PR] arch: use raw_spin_[un]lock to replace spin_[un]lock, fix regression b69111d16a2a330fa272af8175c832e08881844b of https://github.com/apache/nuttx/pull/14578 [nuttx]

2025-01-29 Thread via GitHub
eren-terzioglu commented on PR #15691: URL: https://github.com/apache/nuttx/pull/15691#issuecomment-2621007863 Checking finished, you can merge this if it is good for you too @xiaoxiang781216. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] examples: add blecent and bleprph similar to mynewt-nimble apps [nuttx-apps]

2025-01-29 Thread via GitHub
cederom commented on PR #2807: URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2623386622 ping @maxikrie :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] examples:spislave_test: Improve example [nuttx-apps]

2025-01-29 Thread via GitHub
cederom commented on PR #2820: URL: https://github.com/apache/nuttx-apps/pull/2820#issuecomment-2623385484 ping :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] tools: Optimize size by wasm-opt [nuttx-apps]

2025-01-29 Thread via GitHub
cederom commented on PR #2858: URL: https://github.com/apache/nuttx-apps/pull/2858#issuecomment-2623377393 ping :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] treewide: silent download, unpack and others [nuttx-apps]

2025-01-29 Thread via GitHub
cederom commented on PR #1630: URL: https://github.com/apache/nuttx-apps/pull/1630#issuecomment-2623390895 ping :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Os spinlock test [nuttx-apps]

2025-01-29 Thread via GitHub
cederom commented on PR #2375: URL: https://github.com/apache/nuttx-apps/pull/2375#issuecomment-2623390255 who is familiar with spinlock and can update? looks like config/headers need fix? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Add iptlite packet filter app [nuttx-apps]

2025-01-29 Thread via GitHub
cederom commented on PR #1399: URL: https://github.com/apache/nuttx-apps/pull/1399#issuecomment-2623391648 ping :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] interpreters/micropython: Add Micropython support to NuttX (WIP) [nuttx-apps]

2025-01-29 Thread via GitHub
cederom commented on PR #840: URL: https://github.com/apache/nuttx-apps/pull/840#issuecomment-2623394528 Okay, so we now have full Python ported to NuttX in https://github.com/apache/nuttx-apps/pull/2879 and actively developed by @tmedicci. I was initially also interested in MicroPython.. b

Re: [PR] ostest: fix cmake build break [nuttx-apps]

2025-01-29 Thread via GitHub
XuNeo commented on PR #2979: URL: https://github.com/apache/nuttx-apps/pull/2979#issuecomment-2623422290 The CI reports error: ``` === FAILURES === __ test_ltp_interfaces_lio_listio_3_1

[PR] gdb/workqueue: add basic workqueue dump support [nuttx]

2025-01-29 Thread via GitHub
XuNeo opened a new pull request, #15723: URL: https://github.com/apache/nuttx/pull/15723 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary ``` (gdb) worker hpwork@0x40424b40, idle, 2 threads, 0 work

[PR] gdb/wdog: add basic wdog dump command [nuttx]

2025-01-29 Thread via GitHub
XuNeo opened a new pull request, #15722: URL: https://github.com/apache/nuttx/pull/15722 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary List all wdog timers registered. ``` (gdb) wdog

Re: [PR] ostest: fix cmake build break [nuttx-apps]

2025-01-29 Thread via GitHub
lupyuen commented on PR #2979: URL: https://github.com/apache/nuttx-apps/pull/2979#issuecomment-2623432204 Might be an intermittent error, lemme restart the CI Test. If it still fails, we might need to Rebase with Master Branch. -- This is an automated message from the Apache Git Service.

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
acassis commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1934645756 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +config ZY

[PR] boards/rv-virt: use modlib gnu-elf.ld [nuttx]

2025-01-29 Thread via GitHub
yf13 opened a new pull request, #15724: URL: https://github.com/apache/nuttx/pull/15724 ## Summary This drops board specific gnu-elf.ld for rv-virt as the preprocessed modlib gnu-elf.ld works fine. ## Impacts Board rv-virt KERNEL configs ## Testing - local

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623557988 > > Yes, but you need first change the exuction of ALL IRQ from the interupt context to the thread context. Before that happen, the sched lock must be taken at the same time we ho

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623616378 >No, it isn't truth. the critical section is a big lock which is a well known SMP isssue and should be replaced by the fine grant lock step by step: https://en.wikipedia.org/wiki/Giant_l

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623638885 The current API definition is perfect, and the function name can identify the implementation details of each function. ``` spin_lock: spin lock spin_lock_nopreempt: spin_lock +

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623699281 > Ok, could you give me an example, when can you use spin_lock API? the interrupt can be happened without your control, which mean spin_lock CAN'T BE CALLED in any thread context.

Re: [I] [BUG] Make: sim:quickjs fails to build [nuttx]

2025-01-29 Thread via GitHub
lupyuen commented on issue #15712: URL: https://github.com/apache/nuttx/issues/15712#issuecomment-2623314845 @simbit18 You're right, `sim:quickjs` won't build correctly with `make` on Ubuntu with Docker: https://gist.github.com/lupyuen/e18229d879a99a5a0b582a35f09004e6 ```text sudo d

Re: [PR] gdb/wdog: add basic wdog dump command [nuttx]

2025-01-29 Thread via GitHub
nuttxpr commented on PR #15722: URL: https://github.com/apache/nuttx/pull/15722#issuecomment-2623482377 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX requiremen

Re: [PR] gdb/workqueue: add basic workqueue dump support [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #15723: URL: https://github.com/apache/nuttx/pull/15723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (69495f8a40 -> d3c4f4ec52)

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 69495f8a40 docs: Add Rust examples including JSON handling and Slint UI framework add d3c4f4ec52 gdb/workqueue

(nuttx) branch master updated (d3c4f4ec52 -> eddc22c47f)

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from d3c4f4ec52 gdb/workqueue: add basic workqueue dump support add eddc22c47f gdb/wdog: add basic wdog dump command

Re: [PR] gdb/wdog: add basic wdog dump command [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #15722: URL: https://github.com/apache/nuttx/pull/15722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (7240565ca3 -> 69495f8a40)

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 7240565ca3 boards/linum-stm32h753bi: Fix LVGL video memory allocation add 69495f8a40 docs: Add Rust examples in

Re: [PR] arch/risc-v/src/mpfs/mpfs_cache.c: Move l2zerodevice to use cache ways starting from 0 [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #15713: URL: https://github.com/apache/nuttx/pull/15713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (eddc22c47f -> f53afd174e)

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from eddc22c47f gdb/wdog: add basic wdog dump command add f53afd174e arch/risc-v/src/mpfs/mpfs_cache.c: Move l2zerod

(nuttx) branch master updated (f53afd174e -> cde21ae8bf)

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from f53afd174e arch/risc-v/src/mpfs/mpfs_cache.c: Move l2zerodevice to use cache ways starting from 0 add cde21ae8

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 commented on code in PR #15715: URL: https://github.com/apache/nuttx/pull/15715#discussion_r1935039666 ## net/can/can_callback.c: ## @@ -236,6 +234,7 @@ uint16_t can_datahandler(FAR struct net_driver_s *dev, else { nerr("ERROR: Failed to queue the

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 commented on code in PR #15715: URL: https://github.com/apache/nuttx/pull/15715#discussion_r1935040031 ## net/procfs/net_statistics.c: ## @@ -40,7 +40,7 @@ #if defined(CONFIG_NET_IPv4) || defined(CONFIG_NET_IPv6) || \ defined(CONFIG_NET_TCP) || defined(CO

Re: [PR] docs: Add Rust examples including JSON handling and Slint UI framework [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #15719: URL: https://github.com/apache/nuttx/pull/15719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] samv7: support RX/TX DMA for UART peripherals [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #15716: URL: https://github.com/apache/nuttx/pull/15716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (4fa5e294ac -> ef875d7d9e)

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 4fa5e294ac boards/samv7/common: add support for UART RX DMA polling add f3b0e68124 arch/risc-v/src/mpfs: Add ha

(nuttx) branch master updated (ef875d7d9e -> 48b93b8dc8)

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from ef875d7d9e arch/risc-v/src/mpfs/mpfs_ddr.c: Re-try DDR training on any error add 48b93b8dc8 boards/rv-virt: us

Re: [PR] boards/rv-virt: use modlib gnu-elf.ld [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #15724: URL: https://github.com/apache/nuttx/pull/15724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Mpfs ddr training refinement [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #15714: URL: https://github.com/apache/nuttx/pull/15714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (cde21ae8bf -> 4fa5e294ac)

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from cde21ae8bf w25qxxxjv: fix missing QSPI locking add 7af7655234 samv7/serial: allow TX/RX DMA for UART drivers

Re: [PR] w25qxxxjv: fix missing QSPI locking [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #15717: URL: https://github.com/apache/nuttx/pull/15717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
zouboan commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1935096261 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +config ZY

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
zouboan commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1935093548 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +config ZY

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
zouboan commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1935093232 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +config ZY

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
zouboan commented on PR #15720: URL: https://github.com/apache/nuttx/pull/15720#issuecomment-2623662635 > Please add commit log messages. done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
zouboan commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1935094280 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +config ZY

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
zouboan commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1935096048 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +config ZY

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623667231 > The current API definition is perfect, and the function name can identify the implementation details of each function. > > ``` > spin_lock: spin lock > spin_lock_nop

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
zouboan commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1935098726 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +config ZY

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
zouboan commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1935099349 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +config ZY

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623678901 > so, you don't read my reply carefully, let me copy the example again: > > 1. thread0 on CPU0 hold a spinlock without hold sched lock > 2. thread1 on CPU1 wake up thread2 >

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623681422 if your code does not enable the interrupt controller and schedler at boot time, why does spin_lock require sched_lock and irq_save? -- This is an automated message from the Apache Git S

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623684303 I hope you read my reply carefully. Which of the following 2 options do you pick? ``` spin_lock: spin lock spin_lock_nopreempt: spin_lock + sched_lock spin_lock_irqsave: spi

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
xiaoxiang781216 commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623689075 > > so, you don't read my reply carefully, let me copy the example again: > > > > 1. thread0 on CPU0 hold a spinlock without hold sched lock > > 2. thread1 on CPU1 wake up

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623690211 The advantage of the first option is that all code does not need to be changed, including the ESP third-party library, and the historical API behavior is the same as before. For the

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623693610 > > > so, you don't read my reply carefully, let me copy the example again: > > > > > > 1. thread0 on CPU0 hold a spinlock without hold sched lock > > > 2. thread1 on CPU1 wake up

Re: [PR] zynq-mpsoc: add support for ethernet [nuttx]

2025-01-29 Thread via GitHub
hartmannathan commented on code in PR #15720: URL: https://github.com/apache/nuttx/pull/15720#discussion_r1934531268 ## arch/arm64/src/zynq-mpsoc/Kconfig: ## @@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1 ---help--- Select to enable support for UART1. +con

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623338648 > Yes, but you need first change the exuction of ALL IRQ from the interupt context to the thread context. Before that happen, the sched lock must be taken at the same time we hold spin

Re: [PR] arch: use raw_spin_[un]lock to replace spin_[un]lock, fix regression b69111d16a2a330fa272af8175c832e08881844b of https://github.com/apache/nuttx/pull/14578 [nuttx]

2025-01-29 Thread via GitHub
anchao commented on code in PR #15691: URL: https://github.com/apache/nuttx/pull/15691#discussion_r1934905496 ## arch/arm/src/cxd56xx/cxd56_cpustart.c: ## @@ -122,7 +122,7 @@ static void appdsp_boot(void) irq_attach(CXD56_IRQ_SMP_CALL, cxd56_smp_call_handler, NULL); up_ena

Re: [PR] docs: Add Rust examples including JSON handling and Slint UI framework [nuttx]

2025-01-29 Thread via GitHub
no1wudi commented on PR #15719: URL: https://github.com/apache/nuttx/pull/15719#issuecomment-2623355435 > @no1wudi please include a picture of Slint running in the board, it will spark interest of people to try it OK -- This is an automated message from the Apache Git Service. To r

Re: [PR] arch: use raw_spin_[un]lock to replace spin_[un]lock, fix regression b69111d16a2a330fa272af8175c832e08881844b of https://github.com/apache/nuttx/pull/14578 [nuttx]

2025-01-29 Thread via GitHub
anchao commented on code in PR #15691: URL: https://github.com/apache/nuttx/pull/15691#discussion_r1933750551 ## arch/arm/src/cxd56xx/cxd56_cpustart.c: ## @@ -122,7 +122,7 @@ static void appdsp_boot(void) irq_attach(CXD56_IRQ_SMP_CALL, cxd56_smp_call_handler, NULL); up_ena

Re: [PR] sched/spin_lock: rename raw_spin_* to spin_*_notrace [nuttx]

2025-01-29 Thread via GitHub
anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2621436685 > https://docs.kernel.org/locking/locktypes.html contain the detailed information, here is the keypoint: https://private-user-images.githubusercontent.com/18066964/407624628-9c3314ff-e647-4

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
nuttxpr commented on PR #15715: URL: https://github.com/apache/nuttx/pull/15715#issuecomment-2621892159 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX r

Re: [PR] arch: use raw_spin_[un]lock to replace spin_[un]lock, fix regression b69111d16a2a330fa272af8175c832e08881844b of https://github.com/apache/nuttx/pull/14578 [nuttx]

2025-01-29 Thread via GitHub
tmedicci commented on code in PR #15691: URL: https://github.com/apache/nuttx/pull/15691#discussion_r1934046834 ## arch/arm/src/cxd56xx/cxd56_cpustart.c: ## @@ -122,7 +122,7 @@ static void appdsp_boot(void) irq_attach(CXD56_IRQ_SMP_CALL, cxd56_smp_call_handler, NULL); up_e

Re: [I] [BUG] Make: sim:quickjs fails to build [nuttx]

2025-01-29 Thread via GitHub
simbit18 commented on issue #15712: URL: https://github.com/apache/nuttx/issues/15712#issuecomment-2622145320 Hi @acassis currently on Linux is built with Cmake. ``` Cmake in present: sim/quick

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
occam25 commented on code in PR #15715: URL: https://github.com/apache/nuttx/pull/15715#discussion_r1934226080 ## net/can/can_callback.c: ## @@ -236,6 +234,7 @@ uint16_t can_datahandler(FAR struct net_driver_s *dev, else { nerr("ERROR: Failed to queue the I/O buff

Re: [PR] docs: Add Rust examples including JSON handling and Slint UI framework [nuttx]

2025-01-29 Thread via GitHub
nuttxpr commented on PR #15719: URL: https://github.com/apache/nuttx/pull/15719#issuecomment-2622252174 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. T

Re: [PR] Initial STM32H5 ICACHE Commit [nuttx]

2025-01-29 Thread via GitHub
nuttxpr commented on PR #15718: URL: https://github.com/apache/nuttx/pull/15718#issuecomment-2622261174 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[I] [BUG] stdlib.h: `system` prototype [nuttx]

2025-01-29 Thread via GitHub
tmedicci opened a new issue, #15721: URL: https://github.com/apache/nuttx/issues/15721 ### Description / Steps to reproduce the issue ## The Error While trying to build Python with `system` function during the [`pass2dep`](https://github.com/apache/incubator-nuttx/blob/5e2fc181

Re: [PR] Mpfs ddr training refinement [nuttx]

2025-01-29 Thread via GitHub
jlaitine commented on PR #15714: URL: https://github.com/apache/nuttx/pull/15714#issuecomment-2622463390 > @jlaitine there is an issue: Sorry, I fumbled the PR, the commit adding the header file was left out; fixing ... -- This is an automated message from the Apache Git Service. T

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
acassis commented on code in PR #15715: URL: https://github.com/apache/nuttx/pull/15715#discussion_r1934149682 ## net/procfs/net_statistics.c: ## @@ -40,7 +40,7 @@ #if defined(CONFIG_NET_IPv4) || defined(CONFIG_NET_IPv6) || \ defined(CONFIG_NET_TCP) || defined(CONFIG_NET

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
acassis commented on PR #15715: URL: https://github.com/apache/nuttx/pull/15715#issuecomment-2622043072 Nice work Javier! Really well done PR and very detailed PR summary! Kudos!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] [BUG] Make: sim:quickjs fails to build [nuttx]

2025-01-29 Thread via GitHub
acassis commented on issue #15712: URL: https://github.com/apache/nuttx/issues/15712#issuecomment-2622047244 @simbit18 did you try to find which commit broke it? It was working some time ago! -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
acassis commented on code in PR #15715: URL: https://github.com/apache/nuttx/pull/15715#discussion_r1934149682 ## net/procfs/net_statistics.c: ## @@ -40,7 +40,7 @@ #if defined(CONFIG_NET_IPv4) || defined(CONFIG_NET_IPv6) || \ defined(CONFIG_NET_TCP) || defined(CONFIG_NET

[PR] samv7: support RX/TX DMA for UART peripherals [nuttx]

2025-01-29 Thread via GitHub
michallenc opened a new pull request, #15716: URL: https://github.com/apache/nuttx/pull/15716 ## Summary So far only USART drivers could use TX/RX DMA. This commit adds the support for UART drivers as well (with the exception of serial console). UART peripheral does not have time

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
occam25 commented on code in PR #15715: URL: https://github.com/apache/nuttx/pull/15715#discussion_r1934226080 ## net/can/can_callback.c: ## @@ -236,6 +234,7 @@ uint16_t can_datahandler(FAR struct net_driver_s *dev, else { nerr("ERROR: Failed to queue the I/O buff

[PR] docs: Add Rust examples including JSON handling and Slint UI framework [nuttx]

2025-01-29 Thread via GitHub
no1wudi opened a new pull request, #15719: URL: https://github.com/apache/nuttx/pull/15719 ## Summary - Added two new Rust example applications to the documentation: - `hello` example showcasing JSON serialization/deserialization, async runtime usage, and C interoperability in a Nutt

[PR] Initial STM32H5 ICACHE Commit [nuttx]

2025-01-29 Thread via GitHub
kywwilson11 opened a new pull request, #15718: URL: https://github.com/apache/nuttx/pull/15718 ## Summary Add support for the STM32H5 ICACHE peripheral. The CortexM33 does not have typical embedded icache and dcache. Instead STM32H5 provides the ICACHE as a separate peripheral that n

Re: [PR] samv7: support RX/TX DMA for UART peripherals [nuttx]

2025-01-29 Thread via GitHub
nuttxpr commented on PR #15716: URL: https://github.com/apache/nuttx/pull/15716#issuecomment-2622131869 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR mostly meets the NuttX requirements but is missi

[PR] w25qxxxjv: fix missing QSPI locking [nuttx]

2025-01-29 Thread via GitHub
michallenc opened a new pull request, #15717: URL: https://github.com/apache/nuttx/pull/15717 ## Summary There was a missing QSPI locking for `w25qxxxjv_get_die_from_addr` function. We can't have the lock directly in `w25qxxxjv_get_die_from_addr` because the function is called from alrea

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
occam25 commented on code in PR #15715: URL: https://github.com/apache/nuttx/pull/15715#discussion_r1934212247 ## include/nuttx/net/can.h: ## @@ -43,6 +44,7 @@ #include #include +#include Review Comment: there is where net_stats_t type (needed in can_stats_s new struc

(nuttx-apps) branch master updated: examples:hello_nim: fix comment syntax

2025-01-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new b43fd50ff examples:hello_nim: fix comment

Re: [PR] examples:hello_nim: fix comment syntax [nuttx-apps]

2025-01-29 Thread via GitHub
xiaoxiang781216 merged PR #2981: URL: https://github.com/apache/nuttx-apps/pull/2981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [I] website is not mobile friendly [nuttx-website]

2025-01-29 Thread via GitHub
cederom commented on issue #128: URL: https://github.com/apache/nuttx-website/issues/128#issuecomment-2622629640 Thanks @adityalaxkar123 for interest, the website is really trivial, if you can make it mobile friendly please provide patches over Pull Request for review :-) Please note

Re: [I] [BUG] Make: sim:quickjs fails to build [nuttx]

2025-01-29 Thread via GitHub
acassis commented on issue #15712: URL: https://github.com/apache/nuttx/issues/15712#issuecomment-2622175208 Understood! I think moving some configs to be tested only with a building system "maker" will end up with issues like this -- This is an automated message from the Apache Git Servi

Re: [PR] net/can/: add statistics for recv, sent and drop [nuttx]

2025-01-29 Thread via GitHub
occam25 commented on code in PR #15715: URL: https://github.com/apache/nuttx/pull/15715#discussion_r1934192191 ## net/procfs/net_statistics.c: ## @@ -40,7 +40,7 @@ #if defined(CONFIG_NET_IPv4) || defined(CONFIG_NET_IPv6) || \ defined(CONFIG_NET_TCP) || defined(CONFIG_NET

  1   2   >