acassis commented on code in PR #15720:
URL: https://github.com/apache/nuttx/pull/15720#discussion_r1934645756
##########
arch/arm64/src/zynq-mpsoc/Kconfig:
##########
@@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1
---help---
Select to enable support for UART1.
+config ZYNQ_ENET
+ bool "Ethernet"
+ default n
+ select ARCH_HAVE_PHY
+ select ARCH_HAVE_NETDEV_STATISTICS
+
endmenu # XILINX ZYNQ_MPSOC Peripheral Selection
+menu "Ethernet Configuration"
+ depends on ZYNQ_ENET
+
+choice
+ prompt "ZYNQ Ethernet Interface"
+ default ZYNQ_ENET4
Review Comment:
Why does ENET4 is default instead of ENET1?
##########
arch/arm64/src/zynq-mpsoc/Kconfig:
##########
@@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1
---help---
Select to enable support for UART1.
+config ZYNQ_ENET
+ bool "Ethernet"
+ default n
+ select ARCH_HAVE_PHY
+ select ARCH_HAVE_NETDEV_STATISTICS
+
endmenu # XILINX ZYNQ_MPSOC Peripheral Selection
+menu "Ethernet Configuration"
+ depends on ZYNQ_ENET
+
+choice
+ prompt "ZYNQ Ethernet Interface"
+ default ZYNQ_ENET4
+ depends on ZYNQ_ENET
+
+config ZYNQ_ENET1
+ bool "ENET 1"
+
+config ZYNQ_ENET2
+ bool "ENET 2"
+
+config ZYNQ_ENET3
+ bool "ENET 3"
+
+config ZYNQ_ENET4
+ bool "ENET 4"
+
+endchoice # ZYNQ Ethernet Interface
+
+config ZYNQ_GMAC_NRXBUFFERS
+ int "Number of RX buffers"
+ default 16
Review Comment:
Is there a upper limit for those 128 bytes blocks? If so, please include a
range i.e. 1 to 32
##########
arch/arm64/src/zynq-mpsoc/Kconfig:
##########
@@ -35,6 +35,136 @@ config ZYNQ_MPSOC_UART1
---help---
Select to enable support for UART1.
+config ZYNQ_ENET
+ bool "Ethernet"
+ default n
+ select ARCH_HAVE_PHY
+ select ARCH_HAVE_NETDEV_STATISTICS
+
endmenu # XILINX ZYNQ_MPSOC Peripheral Selection
+menu "Ethernet Configuration"
+ depends on ZYNQ_ENET
+
+choice
+ prompt "ZYNQ Ethernet Interface"
+ default ZYNQ_ENET4
+ depends on ZYNQ_ENET
+
+config ZYNQ_ENET1
+ bool "ENET 1"
+
+config ZYNQ_ENET2
+ bool "ENET 2"
+
+config ZYNQ_ENET3
+ bool "ENET 3"
+
+config ZYNQ_ENET4
+ bool "ENET 4"
+
+endchoice # ZYNQ Ethernet Interface
+
+config ZYNQ_GMAC_NRXBUFFERS
+ int "Number of RX buffers"
+ default 16
+ ---help---
+ GMAC buffer memory is segmented into 128 byte units (not
+ configurable). This setting provides the number of such 128
byte
+ units used for reception. This is also equal to the number of
RX
+ descriptors that will be allocated The selected value must be
an
+ even power of 2.
+
+config ZYNQ_GMAC_NTXBUFFERS
+ int "Number of TX buffers"
+ default 8
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
