anchao commented on PR #15705: URL: https://github.com/apache/nuttx/pull/15705#issuecomment-2623638885
The current API definition is perfect, and the function name can identify the implementation details of each function. ``` spin_lock: spin lock spin_lock_nopreempt: spin_lock + sched_lock spin_lock_irqsave: spin lock + irq save spin_lock_irqsave_nopreempt: spin_lock + irq save + sched_lock ``` And your expected API ``` spin_lock: spin lock + sched_lock <--- why? spin_lock_preempt: spin lock <--- why? ``` nuttx is not Linux, please do not introduce the old implementation in Linux into Nuttx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
