Re: [PR] fix kernel-smp cannot run in qemu-virt arm-v7a, mmu should be enabled again. [nuttx]

2025-04-26 Thread via GitHub
jasonbu commented on code in PR #16263: URL: https://github.com/apache/nuttx/pull/16263#discussion_r2062357578 ## arch/arm/src/common/arm_allocateheap.c: ## @@ -39,6 +39,9 @@ #include "arm_internal.h" #include "chip.h" +#ifdef CONFIG_BUILD_KERNEL +#include "mmu.h" Review Co

(nuttx) 01/05: Documentation/reference/user/02_task_scheduling: fixed function name

2025-04-26 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 4ad0a5b30a6629847d13d0d18bfff6092afa8bb4 Author: Kerogit AuthorDate: Mon Apr 7 20:43:13 2025 +0200 Documentation/

Re: [PR] arch/risc-v: save/restore fpu registers always when CONFIG_ARCH_LAZYFPU is off [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 merged PR #16266: URL: https://github.com/apache/nuttx/pull/16266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: arch/risc-v: save/restore fpu registers always when CONFIG_ARCH_LAZYFPU is off

2025-04-26 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5ce0e93637 arch/risc-v: save/restore fpu regis

(nuttx) 02/05: arch/avr: fixed typo in Kconfig

2025-04-26 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 958b18f25e13fc6e8c1ce69942b089fb6e6f5d31 Author: Kerogit AuthorDate: Thu Mar 13 20:44:01 2025 +0100 arch/avr: fix

(nuttx) 05/05: arch/avr: fixed PC load on chips with more than 128kB program memory

2025-04-26 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit dd828c8920cf7b43a89ece3cf10697963519d3e9 Author: Kerogit AuthorDate: Sat Apr 5 23:41:54 2025 +0200 arch/avr: fixe

(nuttx) branch master updated (fb29f568d1 -> dd828c8920)

2025-04-26 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from fb29f568d1 boards/arm/stm32f401rc-rs485: Add support to ST7735 LCD new 4ad0a5b30a Documentation/reference/user/

(nuttx) 03/05: arch/avr: save RAMPZ register into thread context

2025-04-26 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 88a66f18e67af40f19355ba8d27b469484fb33da Author: Kerogit AuthorDate: Mon Mar 17 12:20:35 2025 +0100 arch/avr: sav

Re: [PR] boards/arm/stm32f401rc-rs485: Add support to ST7735 LCD [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 merged PR #16270: URL: https://github.com/apache/nuttx/pull/16270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) 04/05: nuttx/compiler: replace AVR __flash qualifier with __memx for some chips

2025-04-26 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit cc9febb4533e350aeac95329bda5239b956da73c Author: Kerogit AuthorDate: Mon Mar 24 22:43:33 2025 +0100 nuttx/compile

Re: [PR] arch/avr: Fixes before adding support to AVRDB [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 merged PR #16268: URL: https://github.com/apache/nuttx/pull/16268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: boards/arm/stm32f401rc-rs485: Add support to ST7735 LCD

2025-04-26 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new fb29f568d1 boards/arm/stm32f401rc-rs485: Add s

Re: [I] [HELP] Why is clock_nanosleep not actually high precision? [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on issue #16265: URL: https://github.com/apache/nuttx/issues/16265#issuecomment-2833141538 Linux support two set of timer: 1. timer(https://www.kernel.org/doc/html/v4.9/driver-api/basics.html#c.add_timer) use tick unit 2. hrtimer(https://docs.kernel.org/t

Re: [I] [HELP] Why is clock_nanosleep not actually high precision? [nuttx]

2025-04-26 Thread via GitHub
acassis commented on issue #16265: URL: https://github.com/apache/nuttx/issues/16265#issuecomment-2832832949 @xiaoxiang781216 @anchao @raiden00pl ^ @dejavudwh I think not all microcontrollers have hrtimer. I know some families of STM32 has support to it. -- This is an automated mes

Re: [PR] fix kernel-smp cannot run in qemu-virt arm-v7a, mmu should be enabled again. [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16263: URL: https://github.com/apache/nuttx/pull/16263#discussion_r2062186739 ## arch/arm/src/common/arm_allocateheap.c: ## @@ -39,6 +39,9 @@ #include "arm_internal.h" #include "chip.h" +#ifdef CONFIG_BUILD_KERNEL +#include "mmu.h" R

Re: [I] [HELP] Why is clock_nanosleep not actually high precision? [nuttx]

2025-04-26 Thread via GitHub
dejavudwh commented on issue #16265: URL: https://github.com/apache/nuttx/issues/16265#issuecomment-2832910339 > All nuttx timeout use tick unit, so you need just CONFIG_USEC_PER_TICK to match your precision. > But please note that you have to switch tickless mode to reduce the timer int

Re: [I] [HELP] Why is clock_nanosleep not actually high precision? [nuttx]

2025-04-26 Thread via GitHub
dejavudwh commented on issue #16265: URL: https://github.com/apache/nuttx/issues/16265#issuecomment-2832909782 > [@xiaoxiang781216](https://github.com/xiaoxiang781216) [@anchao](https://github.com/anchao) [@raiden00pl](https://github.com/raiden00pl) ^ > > [@dejavudwh](https://github.

Re: [I] [HELP] Why is clock_nanosleep not actually high precision? [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on issue #16265: URL: https://github.com/apache/nuttx/issues/16265#issuecomment-2832886039 All nuttx timeout use tick unit, so you need just CONFIG_USEC_PER_TICK to match your precision. But please note that you have to switch tickless mode to reduce the timer i

Re: [I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-04-26 Thread via GitHub
acassis commented on issue #16269: URL: https://github.com/apache/nuttx/issues/16269#issuecomment-2832831726 @tmedicci could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[I] [BUG] qemu riscv64 bootup hang [nuttx]

2025-04-26 Thread via GitHub
jinliangli opened a new issue, #16272: URL: https://github.com/apache/nuttx/issues/16272 ### Description / Steps to reproduce the issue In the lastest code in master branch, bootup qemu riscv hang lijinliang1@pc0:~/work/nuttx$ cmake -B build -DBOARD_CONFIG=rv-virt:nsh64 -GNinj

Re: [PR] boards/arm/stm32f401rc-rs485: Add support to ST7735 LCD [nuttx]

2025-04-26 Thread via GitHub
nuttxpr commented on PR #16270: URL: https://github.com/apache/nuttx/pull/16270#issuecomment-2832531637 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. Th

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: c12aa5663d3046138eb975a8bc872d8348c73e21

2025-04-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 3db1a80a8 Publishing web: 16e1777

[PR] boards/arm/stm32f401rc-rs485: Add support to ST7735 LCD [nuttx]

2025-04-26 Thread via GitHub
rcsim opened a new pull request, #16270: URL: https://github.com/apache/nuttx/pull/16270 ## Summary This commit adds support for the LCD based on ST7735 controller on the STM32F401RC-RS485 board and updates the board documentation accordingly. ## Impact Is new feature ad

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
TimJTi commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061518502 ## include/nuttx/video/fb.h: ## @@ -47,183 +47,183 @@ /* Monochrome Formats ***/ -#define FB_FMT_Y1

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061518812 ## include/nuttx/video/fb.h: ## @@ -47,183 +47,183 @@ /* Monochrome Formats ***/ -#define FB_FMT_Y1

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
TimJTi commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061513638 ## include/nuttx/video/fb.h: ## @@ -47,183 +47,183 @@ /* Monochrome Formats ***/ -#define FB_FMT_Y1

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061510842 ## include/nuttx/video/fb.h: ## @@ -47,183 +47,183 @@ /* Monochrome Formats ***/ -#define FB_FMT_Y1

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
TimJTi commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061506732 ## include/nuttx/video/fb.h: ## @@ -47,183 +47,183 @@ /* Monochrome Formats ***/ -#define FB_FMT_Y1

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
TimJTi commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061506251 ## include/nuttx/video/rgbcolors.h: ## @@ -33,10 +33,9 @@ /* Color Creation and Conversion Macros */ -/* This macro creates RGB2

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
TimJTi commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061505752 ## include/nuttx/video/rgbcolors.h: ## @@ -33,10 +33,9 @@ /* Color Creation and Conversion Macros */ -/* This macro creates RGB2

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
TimJTi commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061504942 ## include/nuttx/video/fb.h: ## @@ -892,47 +930,94 @@ struct fb_fix_screeninfo struct fb_bitfield { - uint32_t offset;/* Beginning of bitfield */ - uint32_t le

Re: [I] [BUG] RP2350 ostest stuck when SMP enabled [nuttx]

2025-04-26 Thread via GitHub
avgoor commented on issue #16133: URL: https://github.com/apache/nuttx/issues/16133#issuecomment-2832464040 @shtirlic I honestly just used `pimoroni-pico-2-plus:smp` configuration and added debugging options. That's it, nothing more. I connect via UART0, so maybe this is why it works. But `

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
TimJTi commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061500163 ## include/nuttx/video/fb.h: ## @@ -232,258 +232,296 @@ * fb_cursorattrib_s */ # define FBIOPUT_CURSOR _

Re: [PR] drivers/video/fb.c: Add startup splashscreen option [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16257: URL: https://github.com/apache/nuttx/pull/16257#discussion_r2061494596 ## include/nuttx/video/rgbcolors.h: ## @@ -33,10 +33,9 @@ /* Color Creation and Conversion Macros */ -/* This macro cre

Re: [I] [BUG] RP2350 ostest stuck when SMP enabled [nuttx]

2025-04-26 Thread via GitHub
keever50 commented on issue #16133: URL: https://github.com/apache/nuttx/issues/16133#issuecomment-2832424873 I still believe that the issue isn't even centered around SMP specifically. These issues are completely random. Every patch, every PR, the issue just gets moved around in memory.

Re: [I] [BUG] RP2350 ostest stuck when SMP enabled [nuttx]

2025-04-26 Thread via GitHub
keever50 commented on issue #16133: URL: https://github.com/apache/nuttx/issues/16133#issuecomment-2832420467 ostest also still fails for me on the RP2350 - usbnsh. It does not get any further than this: ![Image](https://github.com/user-attachments/assets/4eb3da3b-d0ec-4fb6-afae-8ce6de

Re: [I] [BUG] RP2350 ostest stuck when SMP enabled [nuttx]

2025-04-26 Thread via GitHub
shtirlic commented on issue #16133: URL: https://github.com/apache/nuttx/issues/16133#issuecomment-2832366275 @avgoor I have at least one successful full run of `ostest` after this commit c12aa5663d3046138eb975a8bc872d8348c73e21 . I’m still very interested to hear how you’re able to get rp2

Re: [PR] drivers/lcd/ili9341: Add custom width/height display options [nuttx]

2025-04-26 Thread via GitHub
shtirlic commented on code in PR #16267: URL: https://github.com/apache/nuttx/pull/16267#discussion_r2061413716 ## drivers/lcd/ili9341.c: ## @@ -287,20 +287,26 @@ /* General fix display resolution */ -#define ILI9341_XRES 240 -#define ILI9341_YRES 320 +#

Re: [PR] fix kernel-smp cannot run in qemu-virt arm-v7a, mmu should be enabled again. [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16263: URL: https://github.com/apache/nuttx/pull/16263#discussion_r2061363030 ## arch/arm/src/common/arm_allocateheap.c: ## @@ -39,6 +39,7 @@ #include "arm_internal.h" #include "chip.h" +#include "mmu.h" Review Comment: but need a

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061222786 ## sched/semaphore/sem_recover.c: ## @@ -104,7 +105,23 @@ void nxsem_recover(FAR struct tcb_s *tcb) * place. */ - atomic_fetch_add(NXSEM_

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061217016 ## sched/semaphore/sem_holder.c: ## @@ -876,7 +876,9 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem) { /* Check our assumptions */ - DEBUG

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061353160 ## libs/libc/semaphore/sem_trywait.c: ## @@ -128,8 +129,9 @@ int nxsem_trywait(FAR sem_t *sem) #endif ) { - int32_t old = 1; - return ato

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061338927 ## libs/libc/misc/lib_mutex.c: ## @@ -195,9 +140,11 @@ bool nxmutex_is_hold(FAR mutex_t *mutex) * **

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061340132 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAI

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2832245430 > @xiaoxiang781216 I disagree on your request for removing the const in many places. what is the reason why you want that? it just tells both the compiler and reader that the valu

Re: [I] [BUG] RP2350 ostest stuck when SMP enabled [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on issue #16133: URL: https://github.com/apache/nuttx/issues/16133#issuecomment-2832244158 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] arch/risc-v: save/restore fpu registers always when CONFIG_ARCH_LAZYFPU is off [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on PR #16266: URL: https://github.com/apache/nuttx/pull/16266#issuecomment-2832238064 but if the thread should skip the fpu context save if it doesn't use any fpu instruction in this time slice. -- This is an automated message from the Apache Git Service. To resp

(nuttx-apps) branch master updated (f94bccf11 -> f14249d1d)

2025-04-26 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from f94bccf11 canutils/slcan: explicitly manage the interface. new 84d4fe0bf system/uorb: using UORB_LOOP_MAX_EV

(nuttx-apps) 02/04: system/uorb: add eventfd to notify loop exit.

2025-04-26 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit d6708057583c47419f3fd2dce64adce883b3b523 Author: dongjiuzhu1 AuthorDate: Wed Dec 11 21:32:13 2024 +0800 system

(nuttx-apps) 01/04: system/uorb: using UORB_LOOP_MAX_EVENTS to config loop function

2025-04-26 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 84d4fe0bfd5fb94ee5ebef1224b781629a0a6916 Author: dongjiuzhu1 AuthorDate: Tue Dec 17 22:33:53 2024 +0800 system

(nuttx-apps) 03/04: system/uORB: Fix orb_loop_s undeclared error

2025-04-26 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 3b0181dbd036f4115af6a8e047609a1217999618 Author: wangjianyu3 AuthorDate: Thu Apr 24 20:33:43 2025 +0800 system

(nuttx-apps) 04/04: system/uORB: Add API for sending loop exit event

2025-04-26 Thread cederom
This is an automated email from the ASF dual-hosted git repository. cederom pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit f14249d1d341fb1345e74b257bdea636a1777996 Author: wangjianyu3 AuthorDate: Wed Apr 16 21:10:50 2025 +0800 system

Re: [PR] system/uORB: Add support for exiting loop by writing eventfd [nuttx-apps]

2025-04-26 Thread via GitHub
cederom merged PR #3064: URL: https://github.com/apache/nuttx-apps/pull/3064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061257154 ## sched/semaphore/sem_post.c: ## @@ -73,10 +73,12 @@ int nxsem_post_slow(FAR sem_t *sem) { FAR struct tcb_s *stcb = NULL; irqstate_t flags; - int32_t sem_coun

Re: [PR] arch/avr: Fixes before adding support to AVRDB [nuttx]

2025-04-26 Thread via GitHub
nuttxpr commented on PR #16268: URL: https://github.com/apache/nuttx/pull/16268#issuecomment-2832042838 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

Re: [PR] drivers/lcd/ili9341: Add custom width/height display options [nuttx]

2025-04-26 Thread via GitHub
acassis commented on code in PR #16267: URL: https://github.com/apache/nuttx/pull/16267#discussion_r2061262908 ## drivers/lcd/ili9341.c: ## @@ -287,20 +287,26 @@ /* General fix display resolution */ -#define ILI9341_XRES 240 -#define ILI9341_YRES 320 +#i

[I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-04-26 Thread via GitHub
abisop opened a new issue, #16269: URL: https://github.com/apache/nuttx/issues/16269 ### Description Device - ESP32-s3 config - esp32s3-devkit:wifi using the command "wapi scan wlan0" fails resulting in cpu reset (most of the time) and using wapi pscan wlan0 results

[PR] arch/avr: Fixes before adding support to AVRDB [nuttx]

2025-04-26 Thread via GitHub
acassis opened a new pull request, #16268: URL: https://github.com/apache/nuttx/pull/16268 ## Summary These are fixes created by kr@kerogit.eu who also added support to AVRDB (that will come next) ## Impact Improvements ## Testing AVR8 -- Thi

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061255959 ## libs/libc/semaphore/sem_trywait.c: ## @@ -128,8 +129,9 @@ int nxsem_trywait(FAR sem_t *sem) #endif ) { - int32_t old = 1; - return atomic_try

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061256889 ## libs/libc/semaphore/sem_wait.c: ## @@ -156,8 +157,9 @@ int nxsem_wait(FAR sem_t *sem) # endif ) { - int32_t old = 1; - if (atomic_try_cmpxch

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061256667 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_I

Re: [PR] fix kernel-smp cannot run in qemu-virt arm-v7a, mmu should be enabled again. [nuttx]

2025-04-26 Thread via GitHub
jasonbu commented on code in PR #16263: URL: https://github.com/apache/nuttx/pull/16263#discussion_r2061258200 ## arch/arm/src/common/arm_allocateheap.c: ## @@ -39,6 +39,7 @@ #include "arm_internal.h" #include "chip.h" +#include "mmu.h" Review Comment: try add #include "

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2832026530 @xiaoxiang781216 I disagree on your request for removing the const in many places. what is the reason why you want that? it just tells both the compiler and reader that the value is not

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061257731 ## libs/libc/misc/lib_mutex.c: ## @@ -195,9 +140,11 @@ bool nxmutex_is_hold(FAR mutex_t *mutex) * *

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061257020 ## sched/semaphore/sem_destroy.c: ## @@ -61,6 +61,9 @@ int nxsem_destroy(FAR sem_t *sem) { int32_t old; + const bool mutex = NXSEM_IS_MUTEX(sem); Review Comment

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061256810 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_I

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061256356 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAITLIST_I

Re: [PR] drivers/lcd/ili9341: Add custom width/height display options [nuttx]

2025-04-26 Thread via GitHub
nuttxpr commented on PR #16267: URL: https://github.com/apache/nuttx/pull/16267#issuecomment-2832000675 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-26 Thread via GitHub
xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061204544 ## include/nuttx/semaphore.h: ## @@ -45,23 +45,42 @@ /* semcount, flags, waitlist, hhead */ #define NXSEM_INITIALIZER(c, f) \ - {(c), (f), SEM_WAI

Re: [I] [BUG] esp32-devkitc:smp fails on ostest after #16030 [nuttx]

2025-04-26 Thread via GitHub
jlaitine commented on issue #16193: URL: https://github.com/apache/nuttx/issues/16193#issuecomment-2831971376 @tmedicci could you check if the PR#16262 affects your issue? It was the cause for our crashes in signest test, and can also cause it to get stuck (test forever sleeping in semaphor

Re: [I] [BUG] RP2350 ostest stuck when SMP enabled [nuttx]

2025-04-26 Thread via GitHub
avgoor commented on issue #16133: URL: https://github.com/apache/nuttx/issues/16133#issuecomment-2831942815 Hi @xiaoxiang781216 and @pussuw, I've seen you closed this issue as resolved by #16262. I've rebuilt everything from scratch with the fresh master branch including this specific commi