jasonbu commented on code in PR #16263: URL: https://github.com/apache/nuttx/pull/16263#discussion_r2062357578
########## arch/arm/src/common/arm_allocateheap.c: ########## @@ -39,6 +39,9 @@ #include "arm_internal.h" #include "chip.h" +#ifdef CONFIG_BUILD_KERNEL +#include "mmu.h" Review Comment: because there is many board included by chip.h, and all possible using or not using mmu, previous chip.h works as expect, so not modify it should be better? in arm_allocateheap.c, we add a reference about PGTABLE_SIZE only if CONFIG_BUILD_KERNEL && CONFIG_ARCH_PGPOOL_PBASE. add a mmu.h in arm_allocateheap.c if CONFIG_BUILD_KERNEL is defined should be safe, as we will always have mmu support when try use kernel build. and will be more common for all board/chip. the CI error is weird, cannot reproduce in my local environment, will try rebase and run once again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
