acassis commented on code in PR #16267: URL: https://github.com/apache/nuttx/pull/16267#discussion_r2061262908
########## drivers/lcd/ili9341.c: ########## @@ -287,20 +287,26 @@ /* General fix display resolution */ -#define ILI9341_XRES 240 -#define ILI9341_YRES 320 +#if CONFIG_LCD_ILI9341_NINTERFACES < 1 Review Comment: I think this is not necessary because the menuconfig already defines LCD_ILI9341_NINTERFACES to range 1 - 2. So LCD_ILI9341_NINTERFACES < 1 is an error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
