nuttxpr commented on PR #16268: URL: https://github.com/apache/nuttx/pull/16268#issuecomment-2832042838
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR description does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details in several sections. Here's a breakdown of what's missing: **Summary:** * **Missing:** A clear explanation of *what* fixes were implemented. Vague phrases like "These are fixes" are insufficient. Each fix needs a brief description. What problem did it solve? * **Missing:** What functional part of the code was changed? Was it the scheduler? A driver? A specific file? * **Missing:** How the changes work. What code was modified, and what is the new behavior? * **Missing (but understandable if not applicable):** Issue references. **Impact:** While stating "Improvements" is a start, it's too general. Each "Impact" sub-item needs to be addressed explicitly with either "NO" or "YES" followed by a description if "YES". For example: * **Impact on user:** NO / YES (if YES: Will users need to reconfigure anything? Will they see different behavior?) * **Impact on build:** NO / YES (if YES: Do any build flags need to be changed? Are new dependencies introduced?) * **Impact on hardware:** YES (AVR8 support is mentioned elsewhere, but it needs to be stated explicitly here. Which AVR8 chips are supported?) * **Impact on documentation:** NO / YES (if YES: What documentation was updated or needs to be updated?) * **Impact on security, compatibility:** Address these explicitly. **Testing:** * **Insufficient:** Simply stating "AVR8" is not enough. Provide specifics. * **Missing:** Build host details. What OS, CPU architecture, and compiler version were used for building? * **Missing:** Target details. *Which* AVR8 board and configuration were used for testing? Model numbers, clock speeds, and any specific settings are important. * **Missing:** Actual testing logs. The template provides placeholders for these, but they are empty. Include relevant output from your tests, both before and after the changes. This could include console output, debug messages, or other metrics that demonstrate the fixes. **In short, the PR description needs to be significantly more detailed and follow the template more closely to be acceptable.** Provide concrete information for each section, replacing vague statements with specifics. This will allow reviewers to understand the changes, assess their impact, and verify the testing results effectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
