jlaitine commented on code in PR #16194:
URL: https://github.com/apache/nuttx/pull/16194#discussion_r2061257731


##########
libs/libc/misc/lib_mutex.c:
##########
@@ -195,9 +140,11 @@ bool nxmutex_is_hold(FAR mutex_t *mutex)
  *
  ****************************************************************************/
 
-int nxmutex_get_holder(FAR mutex_t *mutex)
+pid_t nxmutex_get_holder(FAR mutex_t *mutex)

Review Comment:
   could do.. but if inlined function generates more code than a branch to the 
function, it increases code size, especially if it is frequently used. I only 
inlined functions for which I was sure that the code size doesn't increase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to